From patchwork Tue Jul 2 13:41:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Zhu X-Patchwork-Id: 93239 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89497389941E for ; Tue, 2 Jul 2024 13:42:25 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from nisdydeair.tail4cdaa.ts.net (unknown [IPv6:2605:52c0:2:e9a:307b:dbff:fe9d:66cf]) by sourceware.org (Postfix) with ESMTP id 397133861878 for ; Tue, 2 Jul 2024 13:41:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 397133861878 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=nisdydeair.tail4cdaa.ts.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 397133861878 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2605:52c0:2:e9a:307b:dbff:fe9d:66cf ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719927717; cv=none; b=nWb4RMsOc/l0y7RookG7FX1jNzALyXCpzGS6ltvGou5pBZJD6c+KKLlhZnwsDPsPSzX7mKywURmQc5jsvxWuYkVs4agofnhzm5sXMGAKTrf8qWkXHZJMP4PvDRMyip4qDDsdKnwChNMxSTulv/t0GkumMH/iCjsDT/X18h/R1R4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719927717; c=relaxed/simple; bh=0kbbJLgdI6Ayv0OxHrK/Vzh2v1zvjKuofoEGDiu/0/g=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=O7UO/jcbmhhCCcHP6E24QRa4dKqMNtYUPWBhRQ4qfRZgBFlSk/Oa0gf179ZdJlDnc/F8AGiYNlwPVQTMXUfJePAjWY8LJhUa39SFAad3aeZPnYJ144KStwGfrDgvBAXmd7F5Fd4kLW5a+XqlZTrOe/xv8TAN1u6HtQkp6Q305GE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by nisdydeair.tail4cdaa.ts.net (Postfix, from userid 501) id BE5272876C5F; Tue, 2 Jul 2024 21:41:52 +0800 (CST) From: Julian Zhu To: libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, xry111@xry111.site, Julian Zhu Subject: [PATCH 1/3] RISC-V: Add a macro definition file to check whether the compiler supports extensions. Date: Tue, 2 Jul 2024 21:41:22 +0800 Message-ID: <20240702134124.74121-1-jz531210@gmail.com> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Spam-Status: No, score=-8.7 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KAM_SHORT, KHOP_HELO_FCRDNS, MAY_BE_FORGED, NML_ADSP_CUSTOM_MED, NO_DNS_FOR_FROM, SPF_HELO_NONE, SPF_NONE, SPOOFED_FREEMAIL, SPOOF_GMAIL_MID, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Some extensions of RISC-V are only available in relatively newer compiler. These macro definition can prevent the use of extensions in unsupported compiler. Signed-off-by: Julian Zhu --- sysdeps/riscv/compiler-ext-avail.h | 53 ++++++++++++++++++++++++++++++ 1 file changed, 53 insertions(+) create mode 100644 sysdeps/riscv/compiler-ext-avail.h diff --git a/sysdeps/riscv/compiler-ext-avail.h b/sysdeps/riscv/compiler-ext-avail.h new file mode 100644 index 0000000000..6b2d92e437 --- /dev/null +++ b/sysdeps/riscv/compiler-ext-avail.h @@ -0,0 +1,53 @@ +/* Copyright (C) 2024 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + This file is used to define whether extensions are available + in the compiler. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library. If not, see + . */ + +#ifndef _COMPILER_EXT_AVAIL_H +#define _COMPILER_EXT_AVAIL_H 1 + +/* Zba, Zbb, Zbc, and Zbs are available after gcc 12 or llvm 14 */ + +#if (defined __GNUC__ \ + && (__GNUC__ > 12 || (__GNUC__ >= 12 && __GNUC_MINOR__ >= 1))) \ + || (defined __clang__ && __clang_major__ >= 14) +# define COMPILER_ZBA_AVAIL 1 +# define COMPILER_ZBB_AVAIL 1 +# define COMPILER_ZBC_AVAIL 1 +# define COMPILER_ZBS_AVAIL 1 +#else +# define COMPILER_ZBA_AVAIL 0 +# define COMPILER_ZBB_AVAIL 0 +# define COMPILER_ZBC_AVAIL 0 +# define COMPILER_ZBS_AVAIL 0 +#endif + +/* XTHeadBa, XTHeadBb, and XTHeadBs are available after gcc 13 or llvm 17 */ +#if (defined __GNUC__ \ + && (__GNUC__ > 13 || (__GNUC__ >= 13 && __GNUC_MINOR__ >= 1))) \ + || (defined __clang__ && __clang_major__ >= 17) +# define COMPILER_XTHEADBA_AVAIL 1 +# define COMPILER_XTHEADBB_AVAIL 1 +# define COMPILER_XTHEADBS_AVAIL 1 +#else +# define COMPILER_XTHEADBA_AVAIL 0 +# define COMPILER_XTHEADBB_AVAIL 0 +# define COMPILER_XTHEADBS_AVAIL 0 +#endif + +#endif /* compiler-ext-avail.h */ From patchwork Tue Jul 2 13:41:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Zhu X-Patchwork-Id: 93240 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B629C38102AA for ; Tue, 2 Jul 2024 13:42:26 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from nisdydeair.tail4cdaa.ts.net (unknown [IPv6:2605:52c0:2:e9a:307b:dbff:fe9d:66cf]) by sourceware.org (Postfix) with ESMTP id 827E03849785 for ; Tue, 2 Jul 2024 13:41:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 827E03849785 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=nisdydeair.tail4cdaa.ts.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 827E03849785 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2605:52c0:2:e9a:307b:dbff:fe9d:66cf ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719927719; cv=none; b=fZjWGbKhyGnpue7PxOhMrUY+UzBngw7y0rWQqcSU9jsyQVcAD9wbN3Fp74lWNcf8VE2iokKAwEONehF8PDO/zR1qD6O2o6Q8BLzOkaMLKhlAWvHGl03D+zLaosfjdoTnan40SObzGAmX1/+T1t4/CaAPnqVHpUBo2V8j8IpSeyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719927719; c=relaxed/simple; bh=woIguQ1/b/RNyhnZJaKS9n1Ko4ul5S1hVile7lYxYLQ=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=WnLugWBgOnIQEGRclL8wNPUDVQ4BP6kIno60BXrb2xQCrUZKCCffRqZkmWd01jRe8NipjhhWFFV+342/fYxLGwPQWdKQsRYkiU/YSWaw8yGcHrbiM3fBTK65YAtxHXxr6X4q/m1ybTrH/Gw68K8EsZFlZAO8v9n+ssVv1rxRKD0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by nisdydeair.tail4cdaa.ts.net (Postfix, from userid 501) id 373CB2876C63; Tue, 2 Jul 2024 21:41:54 +0800 (CST) From: Julian Zhu To: libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, xry111@xry111.site, Julian Zhu Subject: [PATCH 2/3] RISC-V: Add compiler support check in string-fza.h and string-fzi.h Date: Tue, 2 Jul 2024 21:41:23 +0800 Message-ID: <20240702134124.74121-2-jz531210@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240702134124.74121-1-jz531210@gmail.com> References: <20240702134124.74121-1-jz531210@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KHOP_HELO_FCRDNS, MAY_BE_FORGED, NML_ADSP_CUSTOM_MED, NO_DNS_FOR_FROM, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Add macros from `compiler-ext-avail.h` to avoid using Zbb or XTheadBb in unsupported compiler versions. Signed-off-by: Julian Zhu --- sysdeps/riscv/string-fza.h | 5 ++++- sysdeps/riscv/string-fzi.h | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/sysdeps/riscv/string-fza.h b/sysdeps/riscv/string-fza.h index ee5c31317f..57fe39e66a 100644 --- a/sysdeps/riscv/string-fza.h +++ b/sysdeps/riscv/string-fza.h @@ -19,7 +19,10 @@ #ifndef _RISCV_STRING_FZA_H #define _RISCV_STRING_FZA_H 1 -#if defined __riscv_zbb || defined __riscv_xtheadbb +#include "compiler-ext-avail.h" + +#if (defined COMPILER_ZBB_AVAIL && defined __riscv_zbb) \ + || (defined COMPILER_XTHEADBB_AVAIL && defined __riscv_xtheadbb) /* With bitmap extension we can use orc.b to find all zero bytes. */ # include # include diff --git a/sysdeps/riscv/string-fzi.h b/sysdeps/riscv/string-fzi.h index 66237c2f03..dccd759dca 100644 --- a/sysdeps/riscv/string-fzi.h +++ b/sysdeps/riscv/string-fzi.h @@ -19,7 +19,10 @@ #ifndef _STRING_RISCV_FZI_H #define _STRING_RISCV_FZI_H 1 -#if defined __riscv_zbb || defined __riscv_xtheadbb +#include "compiler-ext-avail.h" + +#if (defined COMPILER_ZBB_AVAIL && defined __riscv_zbb) \ + || (defined COMPILER_XTHEADBB_AVAIL && defined __riscv_xtheadbb) # include #else /* Without bitmap clz/ctz extensions, it is faster to direct test the bits From patchwork Tue Jul 2 13:41:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Zhu X-Patchwork-Id: 93242 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8646C38AA25C for ; Tue, 2 Jul 2024 13:43:21 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from nisdydeair.tail4cdaa.ts.net (unknown [IPv6:2605:52c0:2:e9a:307b:dbff:fe9d:66cf]) by sourceware.org (Postfix) with ESMTP id 3DE6F38102A5 for ; Tue, 2 Jul 2024 13:42:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3DE6F38102A5 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=nisdydeair.tail4cdaa.ts.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3DE6F38102A5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2605:52c0:2:e9a:307b:dbff:fe9d:66cf ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719927751; cv=none; b=FMU+Q2yY6cImwf1yeDD8AwJvU1qFNWJyM96dXNkaO6skmvdP3FhdJoPxpN+Q0Oqby+zqfJ6KOKd4K5xO/Edx2zBxSef5UHoRbU3ROM+Hw7z1aVYZr49+/noJEtA9qPRRXsiG5xnal2ihiN8RO8lbvAUdYphqiG5NqpveyYakb74= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719927751; c=relaxed/simple; bh=OKgqmPFJQ0+pS5tRDcJvGe5hB/P5m92jrJfPpc10lj0=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=ek9HRd5TfkPQS2YFLKQeSndwcqp/Z/5GoLTqqcNRhcJb8ApIfKTcgT3ZBXtqWEV1Spa5kkhP7ABYn7guBCpqzcrX1KTZRKXPIMmGlciEX7GoQDmMpmvYtJ+yf1s0rsBcgt5v54kzN2DFaGrshGPCjEGtyEzKLXQs3qhsBL+bvm4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by nisdydeair.tail4cdaa.ts.net (Postfix, from userid 501) id B46C02876C65; Tue, 2 Jul 2024 21:41:56 +0800 (CST) From: Julian Zhu To: libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, xry111@xry111.site, Julian Zhu Subject: [PATCH 3/3] RISC-V: Use builtins for ffs and ffsll while supported extension available Date: Tue, 2 Jul 2024 21:41:24 +0800 Message-ID: <20240702134124.74121-3-jz531210@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240702134124.74121-1-jz531210@gmail.com> References: <20240702134124.74121-1-jz531210@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, FORGED_GMAIL_RCVD, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_NONE, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KHOP_HELO_FCRDNS, MAY_BE_FORGED, NML_ADSP_CUSTOM_MED, NO_DNS_FOR_FROM, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Hardware ctz/ctzw instructions are available in the RISC-V Zbb extension, and the similar ctz instruction th.ff1 is available in the RISC-V XTheadBb extension. We can get more simplified code compared to the generic implement of ffs/ffsll. Signed-off-by: Julian Zhu --- sysdeps/riscv/math-use-builtins-ffs.h | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 sysdeps/riscv/math-use-builtins-ffs.h diff --git a/sysdeps/riscv/math-use-builtins-ffs.h b/sysdeps/riscv/math-use-builtins-ffs.h new file mode 100644 index 0000000000..e1ba6f76c7 --- /dev/null +++ b/sysdeps/riscv/math-use-builtins-ffs.h @@ -0,0 +1,10 @@ +#ifdef COMPILER_ZBB_AVAIL && defined __riscv_zbb +# define USE_FFS_BUILTIN 1 +# define USE_FFSLL_BUILTIN 1 +#elif COMPILER_XTHEADBB_AVAIL && defined __riscv_xtheadbb +# define USE_FFS_BUILTIN 0 +# define USE_FFSLL_BUILTIN 1 +#else +# define USE_FFS_BUILTIN 0 +# define USE_FFSLL_BUILTIN 0 +#endif