From patchwork Tue Oct 5 12:50:41 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tamar Christina X-Patchwork-Id: 45882 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3DD45385703A for ; Tue, 5 Oct 2021 12:51:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3DD45385703A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1633438297; bh=mA/XKiviZgL6np9OMXwfFNGD1P8I5aavMSYFrelacdM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=IMfUwgafsYThAUE/awE7bmSnELL5uy4Dx7HTv3N8uotGm9FgVsowT1K+zOReI4r0+ jeMillcWO+63pedJ0NdNbRGQgJR++E+rUQ+5tnWeKkTfKjecD7+/D37Hr+JiHr2gqF cPNYuoMEG1SlUsA6fcU9V6CR9sDDXy2Hr3UxfbJI= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140048.outbound.protection.outlook.com [40.107.14.48]) by sourceware.org (Postfix) with ESMTPS id 8DAC7385840B for ; Tue, 5 Oct 2021 12:51:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8DAC7385840B Received: from AS8PR04CA0200.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::25) by AS8PR08MB6677.eurprd08.prod.outlook.com (2603:10a6:20b:39a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Tue, 5 Oct 2021 12:51:00 +0000 Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::25) by AS8PR04CA0200.outlook.office365.com (2603:10a6:20b:2f3::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 12:51:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;gcc.gnu.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 12:50:59 +0000 Received: ("Tessian outbound d5def7722ff7:v103"); Tue, 05 Oct 2021 12:50:59 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 8c6568c31f97ac44 X-CR-MTA-TID: 64aa7808 Received: from f4bcfe8bed08.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E974FAA-FDE3-4E48-8F10-5CF9D47105C8.1; Tue, 05 Oct 2021 12:50:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f4bcfe8bed08.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Oct 2021 12:50:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UgefIB9t6Oj653nGbirabcs5GOUMqnOmMdWtVdCtyF4WjYhtrKLC6pZoTZHl5wdddgegA4nwESeFtxx0wQBd+7npT9CukLYi9+9A+PBJTpfvI269/p/AkuEOI3PnyCjM7rEhIE7DAursbJHFduHOQPNhPvTe4nA47bJDcIz4IPG8hhSJ31Iji+wFZVtPsHYM0Ydz05pi8MhN18MdlrCZUnRBYKdiAiEpfMQaS3JXJvfQQLDZJ9jpn9plU15ufNL8BmmAd79JOYhjXGubpALX7s25QrJZAUPiGKGOPt1kbZ83/VtIx2Za+lIIwlTsObALEj1yamHtBo+YZsSVfdRrhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mA/XKiviZgL6np9OMXwfFNGD1P8I5aavMSYFrelacdM=; b=GO4OiIerJF+2/DM0OgijNbu+zDSJrZaaqHhFuGMyT3/CE5TQgCG/mS6zRHkYs0Lh1BrXbLpw7DUvCJDPkINBRBOA0aUMlPcKh1OKzt/QmpWXc2rT+BNm7gPXzEmnHHLf4TPvXeofRY5arqJDgKnjLONqZwEzhlEpv3bECEeI7zliSw6WoSh4LRxNAevI6/blfvS6FEEs1O4Ng0Ryk9kaqE0/Y3nZvqy0p6bh4nWnrnY/pwY550BnMujOmFtofiZf3bxs4pJk0kLIZguFUVhHqtTRpoc1y05xG/LgeTIz2v52G+kWzUYcLDPVBUeksKSko49CVpi1k+hir8hO6sdHJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received: from AM0PR08MB5316.eurprd08.prod.outlook.com (2603:10a6:208:185::14) by AM0PR08MB4500.eurprd08.prod.outlook.com (2603:10a6:208:147::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Tue, 5 Oct 2021 12:50:50 +0000 Received: from AM0PR08MB5316.eurprd08.prod.outlook.com ([fe80::9c40:c69a:3ec5:88cc]) by AM0PR08MB5316.eurprd08.prod.outlook.com ([fe80::9c40:c69a:3ec5:88cc%6]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 12:50:49 +0000 Date: Tue, 5 Oct 2021 13:50:41 +0100 To: gcc-patches@gcc.gnu.org Subject: [PATCH]middle-end convert negate + right shift into compare greater. Message-ID: Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: SN4PR0201CA0057.namprd02.prod.outlook.com (2603:10b6:803:20::19) To AM0PR08MB5316.eurprd08.prod.outlook.com (2603:10a6:208:185::14) MIME-Version: 1.0 Received: from arm.com (217.140.106.55) by SN4PR0201CA0057.namprd02.prod.outlook.com (2603:10b6:803:20::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18 via Frontend Transport; Tue, 5 Oct 2021 12:50:47 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9e8f799-bf09-4c36-0bc6-08d987fec81f X-MS-TrafficTypeDiagnostic: AM0PR08MB4500:|AS8PR08MB6677: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:82;OLM:82; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: jPzIQ7NlFqNEplcLBDt9Zm2FjNY0vAi0ycNUbq/1AxqVxgNEYCDskE1GEGluVr4hBsanZxWIiwPA5v/2tKal0leb/h0R3RF3ofqv0hggXe4rEK2+6xKbJvJZWKaeFIErj1Eu15Og8ZF2haJJA4AJhznr/TFuFJGohzAZAlZxx/pjH/Oyw2LJsDo/0XFiaMYO3h55SItwo6bIyZ5Tub5XB5eoGCKQXuDLvfKYwltORUE7ROrgkLJGnOKwJ2joJC+taKDVF7pJ1ZoXSQDwoRd381mQAI6zdTC3MmU+d7A427n8/pL4ROjpWiAjZGKPI6igSWiohIulqjIQ6uTtR67InDvASBPenNDF2GWYR0kfrkgL4AvApE8xqPQdDlbUWPm8Xp6X0FD635re+SzBTW0v7v4EIhxBlVhjTM3o17UxMMxawbg37AwzhlUqVXVefLkynJkB6XufI3kGFAdycc6y9GpNgn+Mx1n7lzwh8r+ruR3nwJdbSfYogDXk/6zslAwXHAGl4QRhjeqiIpEmTZa4aHYp4KnE59CoGkP/1lPQhGa5kxpsIcRgJdszknFor9f3HV18R6bgkqHWZCwLYZ73Urb/Hno+Y1Nss514SAv5hGlC01lv5ZvUdyrNKQYa9fvbN5qkHTJGCX4Xz3TvmNDsLQDfKtVsqqirxozZrPncUCywynoSj52ZnLAJd24++0AXdYi2sMtmuDKaI0rulLHQWyukD4ORhP4b8OGfFi8fCDdL/nRtTlTy7dq3LFYmz54tQrpOCTALNzCwJJwCgKOx2rdCi3yRV7+bSXIpMzM2cp79cFKTcCNUQEvIXQD33z69jjYJMHR73esCn8FmBnrjxXadVXintleo54BayuJcZrux77EmDc70IwOMcRbJVtZM X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR08MB5316.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(44144004)(66476007)(66556008)(508600001)(316002)(38100700002)(2906002)(235185007)(86362001)(38350700002)(33964004)(8886007)(66946007)(186003)(8676002)(7696005)(36756003)(55016002)(6916009)(8936002)(6666004)(2616005)(26005)(52116002)(5660300002)(44832011)(956004)(4326008)(4216001)(2700100001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-Forked: True X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4500 Original-Authentication-Results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: ce5e2845-1449-4c71-9e47-08d987fec168 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YoEtX3+yD8/Do5fnFozMjgS6lEga6zvfMKCsAy/O4ZklnG3aAZMwQ3LdobVhBtjbBvJHCJBTzjsIKsIRuz/53USxw4KceUinc+/+8yyeezjqzimjbebs9tYyko0fqEIz5m1VH1BH8kAOqNKr0uzk51wJAVfWeSJdpf2oLhxihZckEetMXNVz73jbOSOHT4D9ZFFWgBMy8kLH5PtHk8dD8R2mYgTGe1QZYgQLxUXRYhbeXQbClEWm9CdINPsohGR0tmxIXB1bFkf+o07eUMks3qajs4hSOIwg1m7GIcwU18toyUKXqxdEiYd3BqgqKIBbwb2wgLNaiPWXXImiDSH346v8Wbv2ofdpDrF1d5qClsWRqnltK2zRBS+CvtnPyqAI4+ASstI+Q9N3udO0hJRq+5jVZzJ2uceahnPINf1ENxeKyFzq32dwZRId05HfD/XgN+r4gEyUzL3CurOTt52egnutQ4Sg3cdoxtpYM6sn5CAEzibzhsx+ecdBKOt5vIeoTW9/qQWg3TS50NwMA9tHVGOsRBGCUchVZX9v5uoTRcqeL2duvyQDuLi66uvxtMMIl00AwfyHrHjtpSx8H1lfmSw6+zQd80eGS4FMlE4Efuii20XFcat64ksZl0fe7fSOjNGC6s9YEn9JuSC9j0kvkaVxwvfGbdGpeJm9c60xlzOLSXXxJ9Uv/BQV44ZLIqCEOk0wT7Bc6fzjLKwG13jCSrCEbJ/344nE7+R+hG0R8nJrlSicnztfghVUl/ykxyd9ddIOn7NYVWnRI7KhUHl6wcXV8O9ksvnhJn+q52WrqJWlQ05rYWSc/2notiLMv6tM7xObS/EBwaVuhKzfUMKw/whgLwnJBIYYmMgAIZ6lNt9k6qhVhFrRzeifsNpoTsM7 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(44144004)(86362001)(356005)(8886007)(70586007)(6666004)(70206006)(2906002)(6916009)(7696005)(82310400003)(81166007)(33964004)(47076005)(4326008)(8676002)(8936002)(26005)(55016002)(36756003)(44832011)(316002)(5660300002)(107886003)(235185007)(36860700001)(2616005)(186003)(956004)(336012)(508600001)(4216001)(2700100001); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 12:50:59.7748 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f9e8f799-bf09-4c36-0bc6-08d987fec81f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6677 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_LOTSOFHASH, KAM_SHORT, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Tamar Christina via Gcc-patches From: Tamar Christina Reply-To: Tamar Christina Cc: nd@arm.com, rguenther@suse.de Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Hi All, This turns an inversion of the sign bit + arithmetic right shift into a comparison with 0. i.e. void fun1(int32_t *x, int n) { for (int i = 0; i < (n & -16); i++) x[i] = (-x[i]) >> 31; } now generates: .L3: ldr q0, [x0] cmgt v0.4s, v0.4s, #0 str q0, [x0], 16 cmp x0, x1 bne .L3 instead of: .L3: ldr q0, [x0] neg v0.4s, v0.4s sshr v0.4s, v0.4s, 31 str q0, [x0], 16 cmp x0, x1 bne .L3 Bootstrapped Regtested on aarch64-none-linux-gnu, x86_64-pc-linux-gnu and no regressions. Ok for master? Thanks, Tamar gcc/ChangeLog: * match.pd: New negate+shift pattern. gcc/testsuite/ChangeLog: * gcc.dg/signbit-2.c: New test. * gcc.dg/signbit-3.c: New test. * gcc.target/aarch64/signbit-1.c: New test. --- inline copy of patch -- diff --git a/gcc/match.pd b/gcc/match.pd index 7d2a24dbc5e9644a09968f877e12a824d8ba1caa..581436fe36dbacdcb0c2720b7190c96d14398143 100644 diff --git a/gcc/match.pd b/gcc/match.pd index 7d2a24dbc5e9644a09968f877e12a824d8ba1caa..581436fe36dbacdcb0c2720b7190c96d14398143 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -826,6 +826,37 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) { tree utype = unsigned_type_for (type); } (convert (rshift (lshift (convert:utype @0) @2) @3)))))) +/* Fold (-x >> C) into x > 0 where C = precision(type) - 1. */ +(for cst (INTEGER_CST VECTOR_CST) + (simplify + (rshift (negate:s @0) cst@1) + (with { tree ctype = TREE_TYPE (@0); + tree stype = TREE_TYPE (@1); + tree bt = truth_type_for (ctype); } + (switch + /* Handle scalar case. */ + (if (INTEGRAL_TYPE_P (ctype) + && !VECTOR_TYPE_P (ctype) + && !TYPE_UNSIGNED (ctype) + && canonicalize_math_after_vectorization_p () + && wi::eq_p (wi::to_wide (@1), TYPE_PRECISION (stype) - 1)) + (convert:bt (gt:bt @0 { build_zero_cst (stype); }))) + /* Handle vector case with a scalar immediate. */ + (if (VECTOR_INTEGER_TYPE_P (ctype) + && !VECTOR_TYPE_P (stype) + && !TYPE_UNSIGNED (ctype) + && wi::eq_p (wi::to_wide (@1), TYPE_PRECISION (stype) - 1)) + (convert:bt (gt:bt @0 { build_zero_cst (ctype); }))) + /* Handle vector case with a vector immediate. */ + (if (VECTOR_INTEGER_TYPE_P (ctype) + && VECTOR_TYPE_P (stype) + && !TYPE_UNSIGNED (ctype) + && uniform_vector_p (@1)) + (with { tree cst = vector_cst_elt (@1, 0); + tree t = TREE_TYPE (cst); } + (if (wi::eq_p (wi::to_wide (cst), TYPE_PRECISION (t) - 1)) + (convert:bt (gt:bt @0 { build_zero_cst (ctype); }))))))))) + /* Fold (C1/X)*C2 into (C1*C2)/X. */ (simplify (mult (rdiv@3 REAL_CST@0 @1) REAL_CST@2) diff --git a/gcc/testsuite/gcc.dg/signbit-2.c b/gcc/testsuite/gcc.dg/signbit-2.c new file mode 100644 index 0000000000000000000000000000000000000000..fc0157cbc5c7996b481f2998bc30176c96a669bb --- /dev/null +++ b/gcc/testsuite/gcc.dg/signbit-2.c @@ -0,0 +1,19 @@ +/* { dg-do assemble } */ +/* { dg-options "-O3 --save-temps -fdump-tree-optimized" } */ + +#include + +void fun1(int32_t *x, int n) +{ + for (int i = 0; i < (n & -16); i++) + x[i] = (-x[i]) >> 31; +} + +void fun2(int32_t *x, int n) +{ + for (int i = 0; i < (n & -16); i++) + x[i] = (-x[i]) >> 30; +} + +/* { dg-final { scan-tree-dump-times {\s+>\s+\{ 0, 0, 0, 0 \}} 1 optimized } } */ +/* { dg-final { scan-tree-dump-not {\s+>>\s+31} optimized } } */ diff --git a/gcc/testsuite/gcc.dg/signbit-3.c b/gcc/testsuite/gcc.dg/signbit-3.c new file mode 100644 index 0000000000000000000000000000000000000000..19e9c06c349b3287610f817628f00938ece60bf7 --- /dev/null +++ b/gcc/testsuite/gcc.dg/signbit-3.c @@ -0,0 +1,13 @@ +/* { dg-do assemble } */ +/* { dg-options "-O1 --save-temps -fdump-tree-optimized" } */ + +#include + +void fun1(int32_t *x, int n) +{ + for (int i = 0; i < (n & -16); i++) + x[i] = (-x[i]) >> 31; +} + +/* { dg-final { scan-tree-dump-times {\s+>\s+0;} 1 optimized } } */ +/* { dg-final { scan-tree-dump-not {\s+>>\s+31} optimized } } */ diff --git a/gcc/testsuite/gcc.target/aarch64/signbit-1.c b/gcc/testsuite/gcc.target/aarch64/signbit-1.c new file mode 100644 index 0000000000000000000000000000000000000000..3ebfb0586f37de29cf58635b27fe48503714447e --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/signbit-1.c @@ -0,0 +1,18 @@ +/* { dg-do assemble } */ +/* { dg-options "-O3 --save-temps" } */ + +#include + +void fun1(int32_t *x, int n) +{ + for (int i = 0; i < (n & -16); i++) + x[i] = (-x[i]) >> 31; +} + +void fun2(int32_t *x, int n) +{ + for (int i = 0; i < (n & -16); i++) + x[i] = (-x[i]) >> 30; +} + +/* { dg-final { scan-assembler-times {\tcmgt\t} 1 } } */