From patchwork Thu Jun 20 02:43:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YunQiang Su X-Patchwork-Id: 92476 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3A5FE3888839 for ; Thu, 20 Jun 2024 02:44:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A5FE3888839 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1718851455; bh=jWLkv4ff3JtD4YnAzE1csg7P6QXJJewas3a8dULNSpQ=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=fZPF6w68pzd8/lgBKhvSv+7VUfs3a8djynTZnC9FZjS8mzBQnVFKmfA60S1qY1van SahGlwZgCTpfH9JzaoQJ/9AMstN4I3G659+0XiMnrXh1WaZdN9HJihIND9A0ki4h/B U/f/iN2RgqsjFQwqN5OC914T8ksxrfAWk9vtrfP4= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by sourceware.org (Postfix) with ESMTPS id 1A9FF3858C41; Thu, 20 Jun 2024 02:43:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A9FF3858C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A9FF3858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718851415; cv=none; b=Tq6DSZZ0ULOOl0cYUNKxhub6dqth4yv+jML6+vqAP5dXK+xZHT/unOEE5ijXVto3/Dtqkdpztse/72+iDaH4DvTs/4k1SP40hAjJr45LntwcuTdv1NnR7rxAjSlW8aGwGCbeUM4mwluwmRoaegrfOecF2dEUvZvYSkKs9YcYLsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718851415; c=relaxed/simple; bh=xHUJW0JC/a+OwHjKJzABBZQwdBx62KjhgKBoAzeuv1U=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=iDIqtP6BUj4RtQB374LO2J2np8Wh+oD26iQk9gEFA4D3kTBwS67XEYACcDbxtjIByyU+Bww/mioR8DF9X9IXEB2P2XgtGt4fCF443dT1GgOOPWHx00eyydbDmx14RSadVfxCm1UuZswGjAQI1onAySnzC/V+8+o2S1UTVqxpl0Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f9885d5c04so3463965ad.0; Wed, 19 Jun 2024 19:43:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718851412; x=1719456212; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jWLkv4ff3JtD4YnAzE1csg7P6QXJJewas3a8dULNSpQ=; b=IsJSEv/XQdDXm/SQQ6UOqR+VnRCfUp4MdKQvZ3d1pq3bUrDh8/tusJwRh1DOsylLP1 6D0wJfqkScZKXw7yLZXAKK4inAlK2fojth4xV9W0LH/YKgVhftNNVndHQsh9IoCRYRnI j8cJ2ha0HAu8mRl95mTy5yfKF84rCoJm4VW1n2Bag7OWsRhRRqnSFDb9F/w/efnE/cY1 8yBR1aKy+E5K7TdTQrsdBiqxV4Jg7ivhYdJC+rvMVzmWb3Pg/AZIKJWWSAdDdJk0cw1+ khbYFp/Nbj/Un2oy9QvTpcdt1U4XwGB3CM+OQ7vr3ICqi7w3qxqJe8ryZbpPn6zIi0Hj bW2w== X-Forwarded-Encrypted: i=1; AJvYcCWAFMzUATyebR6iyj0gvsUf4cxmCUy6RG6gY/bUh6aDgD4JlWHCrqGiNHzjOBW0OSKe0q8OFeeCc4PB+efxrU8= X-Gm-Message-State: AOJu0YyNJbKYvV67Z60UksqKfWDSAozg03VMZ59LLBDSR3wssVhwJ7NJ bBeoJbKAtPh4CjfPRWc2JIN1buF00RznXYll5S2GxP348E0rBHYBJ/sCUIEc X-Google-Smtp-Source: AGHT+IGjuvEE1aKiT7DjNAwsz8XEVomcmdbrmbgJMdMshgPGDMI2AtV7QDXyQDH3FKpMBateyk/i1A== X-Received: by 2002:a17:903:191:b0:1f9:ccd0:2abb with SMTP id d9443c01a7336-1f9ccd02d58mr3733435ad.58.1718851411601; Wed, 19 Jun 2024 19:43:31 -0700 (PDT) Received: from localhost.localdomain ([194.169.55.179]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f855f5dda7sm124832265ad.309.2024.06.19.19.43.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 19 Jun 2024 19:43:31 -0700 (PDT) From: YunQiang Su To: gcc-patches@gcc.gnu.org Cc: macro@orcam.me.uk, YunQiang Su Subject: [PATCH] Build: Set gcc_cv_as_mips_explicit_relocs if gcc_cv_as_mips_explicit_relocs_pcrel Date: Thu, 20 Jun 2024 10:43:24 +0800 Message-Id: <20240620024324.18568-1-syq@gcc.gnu.org> X-Mailer: git-send-email 2.39.3 (Apple Git-146) MIME-Version: 1.0 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org We check gcc_cv_as_mips_explicit_relocs if gcc_cv_as_mips_explicit_relocs_pcrel only, while gcc_cv_as_mips_explicit_relocs is used by later code. Maybe, it is time for use to set gcc_cv_as_mips_explicit_relocs always now, as it has been in Binutils for more than 20 years. gcc * configure.ac: Set gcc_cv_as_mips_explicit_relocs if gcc_cv_as_mips_explicit_relocs_pcrel. * configure: Regenerate. --- gcc/configure | 2 ++ gcc/configure.ac | 2 ++ 2 files changed, 4 insertions(+) diff --git a/gcc/configure b/gcc/configure index 9dc0b65dfaa..ad998105da3 100755 --- a/gcc/configure +++ b/gcc/configure @@ -30278,6 +30278,8 @@ $as_echo "#define MIPS_EXPLICIT_RELOCS MIPS_EXPLICIT_RELOCS_BASE" >>confdefs.h fi + else + gcc_cv_as_mips_explicit_relocs=yes fi if test x$gcc_cv_as_mips_explicit_relocs = xno; then \ diff --git a/gcc/configure.ac b/gcc/configure.ac index b2243e9954a..c51d3ca5f1b 100644 --- a/gcc/configure.ac +++ b/gcc/configure.ac @@ -5255,6 +5255,8 @@ LCF0: [ lw $4,%gp_rel(foo)($4)],, [AC_DEFINE(MIPS_EXPLICIT_RELOCS, MIPS_EXPLICIT_RELOCS_BASE, [Define if assembler supports %reloc.])]) + else + gcc_cv_as_mips_explicit_relocs=yes fi if test x$gcc_cv_as_mips_explicit_relocs = xno; then \