From patchwork Mon Oct 4 12:26:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 45784 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D29ED3858409 for ; Mon, 4 Oct 2021 12:27:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D29ED3858409 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1633350443; bh=Zt+omJUWW4+7VediXJZB+0WZy2nrL5Jh+bEuyrMaBHw=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=xRshI5yYB1HzmKDTqoj1pnb5FF6XyReMBz0I24+979ER27MYD78ChMDHKCyXX2Rzd O6fbWsEeVmnv39J2MqFQJT6zWLn589bLD3+btNggRCTJ5PJ6EPWl/OpULP/Kl4hd1y jv6M7f0IXvEx84p0+ZlpIBeWEZkFq6HqlmAm4D6M= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 7F8A23858408 for ; Mon, 4 Oct 2021 12:26:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7F8A23858408 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 69C861FFE8 for ; Mon, 4 Oct 2021 12:26:51 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 560AF13342 for ; Mon, 4 Oct 2021 12:26:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9CfkEwvzWmHOIwAAMHmgww (envelope-from ) for ; Mon, 04 Oct 2021 12:26:51 +0000 Date: Mon, 4 Oct 2021 14:26:51 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] avoid hardreg autoinit Message-ID: MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" This avoids initializating "uninitialized" hardregs like SP. Bootstrap / regtest pending on x86_64-unknown-linux-gnu. 2021-10-04 Richard Biener * gimplify.c (is_var_need_auto_init): DECL_HARD_REGISTER variables are not to be initialized. * gcc.dg/auto-init-hardreg-1.c: New testcase. --- gcc/gimplify.c | 2 ++ gcc/testsuite/gcc.dg/auto-init-hardreg-1.c | 9 +++++++++ 2 files changed, 11 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/auto-init-hardreg-1.c diff --git a/gcc/gimplify.c b/gcc/gimplify.c index f4bc649632e..b27776af7c8 100644 --- a/gcc/gimplify.c +++ b/gcc/gimplify.c @@ -1825,6 +1825,8 @@ static bool is_var_need_auto_init (tree decl) { if (auto_var_p (decl) + && (TREE_CODE (decl) != VAR_DECL + || !DECL_HARD_REGISTER (decl)) && (flag_auto_var_init > AUTO_INIT_UNINITIALIZED) && (!lookup_attribute ("uninitialized", DECL_ATTRIBUTES (decl))) && !is_empty_type (TREE_TYPE (decl))) diff --git a/gcc/testsuite/gcc.dg/auto-init-hardreg-1.c b/gcc/testsuite/gcc.dg/auto-init-hardreg-1.c new file mode 100644 index 00000000000..7c9de99bf05 --- /dev/null +++ b/gcc/testsuite/gcc.dg/auto-init-hardreg-1.c @@ -0,0 +1,9 @@ +/* { dg-do run { target i?86-*-* x86_64-*-* } } */ +/* { dg-options "-ftrivial-auto-var-init=zero" } */ + +int +main () +{ + register long *sp __asm__("sp"); + return 0; +}