From patchwork Fri May 24 21:15:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Ferreira X-Patchwork-Id: 90850 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DE5E0385E827 for ; Fri, 24 May 2024 21:16:32 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 497653858CD9 for ; Fri, 24 May 2024 21:16:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 497653858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 497653858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::436 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716585372; cv=none; b=qZS4gKE93BSRiP4REdkMRzr7txvZMqXhWK3V0I9VFeHYiO6D4CQMWAH1JRBMTrd+mLf5Xes/8vEp5aNGhhTEavUc0hFQH+vggee8Hcu7wN+dcidpg7mnGAHhMHGi/YNVmSL97usYyyI/MPKE20slOziIOqPvIh4cpz42nIbveQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716585372; c=relaxed/simple; bh=jOQ8ZPeBKvkwisaWx45oaRNwKjSOBHqK04Jd4bXcnZE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=dGEUp4RVI4uzXZoplJZKCZn7TPh+sYzr1X7XIC7OlPPn3thdJ+2xLlheX8AcrICmclGva0jtazXM5UdqZ1S1jpDjMfHwwU0qYXnKcX6wxcgBplbPcOwrOYqEmWGPWNTN4n/fu2BxRHmxj2ST5i/ENhjcYYoN6+mjnmbB54l9dJY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6f8e819a540so1375459b3a.0 for ; Fri, 24 May 2024 14:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716585367; x=1717190167; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=P7aUNXFTWEli+27IgK/m3vQE5LfJ9+7xUf4cC5YYzBs=; b=cUNYQwQsuxzlSDdNXHpCC+/jDr6CL2VvA6qTiRwg+ITG0kc3MudH2xeJ6v9cy8+7Tz WzxfXbsod9HTh6h6IbvN8iG8b6D0iCqWxR1tWHb/ukS89F3BhyYxgQqiBkiKTavICDoB k1sb2ut2yoBHt1g5dYNGXuAPsYELlwkV/nD3Pv2DOapJq+r+ojO8hv9oXs5KylImlZ5I RFmpXeR43/dLjwKyxp1Fz+xSzuPrOtST4qTSrtM5l+qi1KSquEfjhCcvJuDwvmKeAUp9 VoJZJeRwBPuyv2s/eC+LGgIzr4LigH4IcVaHqYbeYZhB1KLn64KzCKgGfzhUm5aDyRbK v6uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716585367; x=1717190167; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P7aUNXFTWEli+27IgK/m3vQE5LfJ9+7xUf4cC5YYzBs=; b=lFX5/D/ZT+nJjHyGk177nDXegO+9RsqorY15UPk15E5VTcUthH4PqmGQM64IREe5VK AmCehZQq1ctuTVPCAz5XqPpWBM6+vg8vzeUzanwmFLAZqbpMThXWJTU/5Ji1xsCzj17o Hma16a1csKFD5lB0QSBcylxf1h8Kbm5bbnNkYhSOrc4Nhzd7sxn1NVlNvZi1pmUAD8IQ y5JB6bM0K0CdrHkt7LyJD41PjQC3R71Ku8BGIRflEQmJzqrZtqaW7IYDZKMV2Z2Y4l1Q V9ZPLOipL3w3qbCtHUxE7ul7pxtlcHKq+6x2hhLyDqIn/l9sJ6YUMwnVcGtNOrq3GZ/d +o3g== X-Gm-Message-State: AOJu0YwjZUHioTp0BNDrzj0jHEiLAn7TYHAnhPWPHV3QPLuCfQdfPVdS sdUuaMlVdY7XtPJqRNdYKROd+42HNSMkxKUBrr2Q8phitVNkSYuPP4okFQ== X-Google-Smtp-Source: AGHT+IE1xmmZvGSrEzY2y538TbIvKjfGcKHMKi5eNAsbV1jBroH7Nbo3Rb12+pOMC8yxkuYg78JV8Q== X-Received: by 2002:a05:6a20:9688:b0:1af:a72e:8b7e with SMTP id adf61e73a8af0-1b212e3550bmr3510965637.50.1716585366735; Fri, 24 May 2024 14:16:06 -0700 (PDT) Received: from zagreus.. ([187.106.33.156]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f8fd2d909asm1554841b3a.178.2024.05.24.14.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 May 2024 14:16:06 -0700 (PDT) From: William Ferreira To: gdb-patches@sourceware.org Cc: William Ferreira Subject: [PATCH] [gdbserver] Imply --once if connecting via stdio Date: Fri, 24 May 2024 18:15:41 -0300 Message-ID: <20240524211541.378520-1-wqferr@gmail.com> X-Mailer: git-send-email 2.45.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Currently, gdbserver hangs after stdin is closed while it tries to write: "Remote side has terminated connection. GDBserver will reopen the connection." This hang disappears if --once is also given. Since the stdin connection won't ever reopen if it's closed, it's safe to assume --once is desired. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29796 Tested-By: Guinevere Larsen --- gdbserver/server.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdbserver/server.cc b/gdbserver/server.cc index 789af36d9a4..3ab7a1eed14 100644 --- a/gdbserver/server.cc +++ b/gdbserver/server.cc @@ -4204,6 +4204,10 @@ captured_main (int argc, char *argv[]) /* "-" specifies a stdio connection and is a form of port specification. */ port = STDIO_CONNECTION_NAME; + + /* Implying --once here prevents a hang after stdin has been closed. */ + run_once = true; + next_arg++; break; }