From patchwork Wed May 22 08:14:08 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Willgerodt, Felix" X-Patchwork-Id: 90649 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2708738654A1 for ; Wed, 22 May 2024 08:14:59 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by sourceware.org (Postfix) with ESMTPS id 8A76E3858C60 for ; Wed, 22 May 2024 08:14:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8A76E3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8A76E3858C60 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=192.198.163.10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716365659; cv=none; b=WZt1tNEu1CMwcX8V7ukq9E+F0nXi9kstRTQEMjFzQtWaPYcQTKFqe4JVTq9+CKwOhpVeSZRUVjrnEZJs2sY2HwPgTosGpWL6EPFFPHTzQK+KapEqsrMnTxsS6BWZTIAml5WHJ31pQuYAnc35wLCvN36ShpCqMoFTFeaRK/Qze4w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716365659; c=relaxed/simple; bh=ROH2pAYSUyRzV+NK+fvIAmuUmPb5B8PwpzY6xyjf9/I=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=ln6EzKFnoHL1matljBejSFC0pwTSMsKOXoll6yvYcS+DB3YWTPskZk/ommjBs3dNv0nM8HFoXDsGWDfduXoIvUOJRZFu4oozCKNfVbfYi50gxeXyppoU7XTHnEkdSH/WkZPTysnlJRzSDHixqX7uya3QcYjvG/tXmQuHX7pr76w= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716365658; x=1747901658; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=ROH2pAYSUyRzV+NK+fvIAmuUmPb5B8PwpzY6xyjf9/I=; b=LONkNu3oYDYZoi5A2YkUnENVlRpuHOh68vhQOcfS6fVryrnm7p1dATah V9C8ju6HSeaTRSa72/CyHX93zVcgCZsJsqqScTOskt42gKztHeRbhSGGg mupwwFZAeANt0VMX22rcct6Z8OzlTc9zZniuMX0Tipu+H3fOQue/52wD5 d8zV4LsEUFvCfPM3ReXDLHDqfaQ6WIaXW6GNq0FV0C2+uBDWCDBERoCTN qwYE3w43DRGXEaQ9JHQx8JKPaz1fFPUFMjC5PTcLXAVlk1OA+F6b9P3Ut IUX61uO1e/DHYTozpb/6+T2SYWVq+3lwVfZ/TJwR73rSBR1AKde9tKa40 Q==; X-CSE-ConnectionGUID: xMzOdUTqRRiJNU42dB8/YA== X-CSE-MsgGUID: w8cSzk8BR9ORDQSMKa6CnA== X-IronPort-AV: E=McAfee;i="6600,9927,11079"; a="24013528" X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="24013528" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2024 01:14:16 -0700 X-CSE-ConnectionGUID: CPfe3gWSRw2A8zPShrKIww== X-CSE-MsgGUID: J/1UV09wRDKNUlvRWFVP8w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,179,1712646000"; d="scan'208";a="33328860" Received: from gkldtt-dev-004.igk.intel.com (HELO localhost) ([10.123.221.202]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2024 01:14:16 -0700 From: Felix Willgerodt To: gdb-patches@sourceware.org Subject: [PATCH 1/1] gdb, testsuite: Fix return value in gdb.base/foll-fork.exp Date: Wed, 22 May 2024 10:14:08 +0200 Message-Id: <20240522081408.997133-1-felix.willgerodt@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org In a remote testing setup, I saw this error: ~~~ (gdb) FAIL: gdb.base/foll-fork.exp: check_fork_catchpoints: runto: run to main ERROR: tcl error sourcing gdb/gdb/testsuite/gdb.base/foll-fork.exp. ERROR: expected boolean value but got "" while executing "if { ![check_fork_catchpoints] } { untested "follow-fork not supported" return }" (file "gdb/gdb/testsuite/gdb.base/foll-fork.exp" line 434) invoked from within "source gdb/gdb/testsuite/gdb.base/foll-fork.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source gdb/gdb/testsuite/gdb.base/foll-fork.exp" invoked from within "catch "uplevel #0 source $test_file_name"" Remote debugging from host 172.0.1.3, port 37766 Killing process(es): 1171 Quit ~~~ The actual reason for this were some connection problems. Though the function check_fork_catchpoints shouldn't return an empty string, especially as it promises to always return 0 or 1. Fix that. --- gdb/testsuite/gdb.base/foll-fork.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/foll-fork.exp b/gdb/testsuite/gdb.base/foll-fork.exp index ecf2111d4fd..0d801f004e4 100644 --- a/gdb/testsuite/gdb.base/foll-fork.exp +++ b/gdb/testsuite/gdb.base/foll-fork.exp @@ -42,7 +42,7 @@ proc_with_prefix check_fork_catchpoints {} { global gdb_prompt if { ![setup] } { - return + return 0 } # Verify that the system supports "catch fork".