From patchwork Mon May 20 17:00:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?K=C3=A9vin_Le_Gouguec?= X-Patchwork-Id: 90495 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6D4423858C56 for ; Mon, 20 May 2024 17:01:32 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 1FAE83858D1E for ; Mon, 20 May 2024 17:01:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1FAE83858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1FAE83858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716224472; cv=none; b=THFcroyAAZEn6rzpChryT2R/ci8FCkBVpj7EcnTGEdZlu6LodByITZkMvhqOBAJ8yRQX8+KBEqAnUVBkFRm4kEoJ2Uvija1gLJYKWP1ZTAW18hc5McwC0ogW4iCb586v0JtSaQ2AisZKyNgz8a5I/63falej7KtWi+yrFJBFBwo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716224472; c=relaxed/simple; bh=HNuCgnEe1vginPVGVWL9Tus2dDYVG5Wma5g1daG19Co=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=MQceQAXjCdZ5U15yq5n6vInRspcVMzcGoBEmoCCNPbRMVZloXiSAseTwSBKbv5cLlkHdxnb59NYB1LAzpWzve3KkZjxnJ9hYBAmZKL9bmpmigt723/wqP5eta9z9ep1uxr2ZrkY+R2us0CPYJ+YxC0+0G3U81t9BH+Xq5J1ZvY0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-420180b5838so16781755e9.2 for ; Mon, 20 May 2024 10:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1716224465; x=1716829265; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rlUqascrZdA/Cuqufno6mjmW/pXAJxJIQK4tOxe9z7Q=; b=dHUtXASrBt2Ub3RR5ofZe9SNoIkZgrEW4s07jL+RcgTgghmW11pc5qYBPBP7ReYri1 D6sNacl4EJ5TX8NleUh1b9jBzClfFbfhMC7TKsqHoxdqyB41MQdBUaul/mxbuP8j7Anr jKUQs05ZphJVDKGIUx0HUUCXrY5JRmgovoxRCmlpJX6mDFzfDfvROuzFzDhGJuXbx7zl Py0WVcT50O8ApYLFeUeMbkCU40Kp7haedNJTRn1+WGoQVEPFr19lYU2RuR5xpo1yVbYJ 9hgEvzV032yDHy26pXSCf2RNaVz5AJV7un/MJX2qPXb1v6K6C3Cuu97UA1wCB7h2W0RN isXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716224465; x=1716829265; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rlUqascrZdA/Cuqufno6mjmW/pXAJxJIQK4tOxe9z7Q=; b=BpGnDP2dA7e7E+Pmx+s2mQSjcqp9HH6Psw01WkiQb/xtrsvN73ovZHFYaNmjkw8x1V Q1a5lDKp7EZtltl871Bx6yW1SvaNpHUYK6Vc5iNTNe6vXIvN9zgTCIbkNpASzgVu7kRm 3kk4Rfk9pBY/JzGKvy5isOjuKtquW8KCHL8TybJ9r8pWMdVBDK59xKwrkqJOqcriraA+ HgAYVgNqemTI4mCaMKEWWOKFUVsveDgMiMnwknNr9dBbVSMUoqPimbjHMk4wE6k2KqTw xusmmswE5yD5I3ymySUXyHGsuXksXvX98PHm8/eHjp818MSUdkdggPBbLsVpBXF8Wk3/ fvuQ== X-Gm-Message-State: AOJu0Yx/62pNm0LtNQG1zQa4JuODwYgX510meKyNtiGR/J5kSFnCFgsu V+jk+PykmQ2vA3gZhfTpTLNZwvjvwCkj/3mYNbDwzb5op9ik/zb7Rjw8AfHi6GmnOwa4FAfT0PQ = X-Google-Smtp-Source: AGHT+IGpG7kLQ+RMPw6btBbT1vmsYbXXDISY20ubjDIsP3Kldv5rnIP/vtU2vH4i/K8mWdTUF/A6VA== X-Received: by 2002:a05:600c:1395:b0:41f:dec3:d5d3 with SMTP id 5b1f17b1804b1-42025fe9ab5mr156058705e9.19.1716224465559; Mon, 20 May 2024 10:01:05 -0700 (PDT) Received: from legouguec-Precision-7550.. ([2a01:e0a:253:fe0:7425:ac0a:32d2:c729]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-41fccbe8f9bsm430742065e9.6.2024.05.20.10.01.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 10:01:05 -0700 (PDT) From: =?utf-8?q?K=C3=A9vin_Le_Gouguec?= To: gdb-patches@sourceware.org Cc: =?utf-8?q?K=C3=A9vin_Le_Gouguec?= Subject: [OB PATCH] gdb: Fix Windows build after #include shuffle Date: Mon, 20 May 2024 19:00:36 +0200 Message-Id: <20240520170036.903477-1-legouguec@adacore.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Without this patch, the build chokes on: ../../src/gdb/windows-nat.c:384:21: error: field 'm_debug_event_pending' has incomplete type 'std::atomic' 384 | std::atomic m_debug_event_pending { false }; | ^~~~~~~~~~~~~~~~~~~~~ In file included from […gcc tree…]/include/c++/13.2.1/bits/shared_ptr_atomic.h:33, from […gcc tree…]/include/c++/13.2.1/memory:81, from ../../src/gdb/../gdbsupport/gdb_unique_ptr.h:23, from ../../src/gdb/../gdbsupport/common-utils.h:26, from ../../src/gdb/../gdbsupport/common-defs.h:199, from ./../../src/gdb/defs.h:26, from : […gcc tree…]/include/c++/13.2.1/bits/atomic_base.h:174:12: note: declaration of 'struct std::atomic' 174 | struct atomic; | ^~~~~~ make.exe[2]: *** [Makefile:1947: windows-nat.o] Error 1 Presumably windows-nat.c relied on objfiles.h including , which was undone in 2024-05-16 "gdb: remove unused includes in objfiles.{c,h}" (f617661c110). --- gdb/windows-nat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 70f955d9797..e4feea15d1f 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -41,6 +41,7 @@ #include #endif #include +#include #include #include