From patchwork Thu May 16 16:35:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Marchi X-Patchwork-Id: 90297 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4CCD93858404 for ; Thu, 16 May 2024 16:36:28 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id BEC683858D20 for ; Thu, 16 May 2024 16:36:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEC683858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BEC683858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715877368; cv=none; b=VlfvGOPGbJ4f7zSAGH0wrPG69z/kSV1+VMwfPvgnuQKAPEoQN9t7U/CCrY5BvbR3TyRIp/TfEbMNUFnODZrZDgpxN9S+eB0eAGQ0ovhEatCbDGbnRHR7qPYWNxvIupygyjfP3jhwEdnTPj/Q6Cw4HWWkwXDx8K2E3MuRj9zFYkg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715877368; c=relaxed/simple; bh=iI+aq1Y/k9izfZPYk0789+SW4CPaOlLm7l3K9dO3giY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MKynIWgqG6oDNNnipWxYPCuj3IqqR1cSuNw7Li1UA/qli0Gt/NOHtap5T5nw/BfY78otA9WnND+o7h3vd08PahaU9kFg9Fp4cya/DJScBf6bGaoe3eTRDmG6GHkQj5c0STyS9y2P6tTwdaHdOJDNHWhJRpgXBvm244m97oD4AAQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 44GGZwIl064084 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 16 May 2024 12:36:03 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 44GGZwIl064084 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1715877363; bh=Gd5fe5084eeJEXK2XzPS6v/vhh1z06jNm3KUdhcIYNI=; h=From:To:Cc:Subject:Date:From; b=hATuKH0w2TrosHtwr9R5KW2XFZajj7pSv788vygbyT9t2tuy+3tbTPrDLyNeNfnle wVo7ylmmv4YzebL1KIPNZFtLuG5CmRAtHZ83nA4WJg2J41aHpsegOXdfeTaywJmmrX hIuSMBUTwGmxB+14yAEJPAG7t4QhVzmBW2EiNUlo= Received: from simark.localdomain (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E55FA1E030; Thu, 16 May 2024 12:35:57 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH] gdb: initialize packet_result::m_textual_err_msg Date: Thu, 16 May 2024 12:35:53 -0400 Message-ID: <20240516163557.529065-1-simon.marchi@polymtl.ca> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 16 May 2024 16:35:58 +0000 X-Spam-Status: No, score=-3188.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org From: Simon Marchi When building GDB with -O2 and --enable-ubsan, I get some random errors in the packet_result self test: /home/smarchi/src/binutils-gdb/gdb/remote.c:161:7: runtime error: load of value 92, which is not a valid value for type 'bool' This happens because packet_result::m_textual_err_msg is uninitialized when using the second constructor. When such a packet_result object gets copied, an invalid value for m_textual_err_msg (a bool field) is loaded, which triggers ubsan. Avoid this by initializing m_textual_err_msg. Change-Id: I3ce44816bb0bfc6e442067292f993e5c17301b85 --- gdb/remote.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 74d2676602ee0b812478797953f95cf9a9de2ed4 diff --git a/gdb/remote.c b/gdb/remote.c index 6e568eb47b23..42b446c7e27e 100644 --- a/gdb/remote.c +++ b/gdb/remote.c @@ -222,7 +222,7 @@ class packet_result /* True if we have a textual error message, from an "E.MESSAGE" response. */ - bool m_textual_err_msg; + bool m_textual_err_msg = false; }; /* Enumeration of packets for a remote target. */