From patchwork Thu May 16 13:50:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 90287 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8E0383849ADE for ; Thu, 16 May 2024 13:50:50 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id E3BB03858D38 for ; Thu, 16 May 2024 13:50:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E3BB03858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E3BB03858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::631 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715867429; cv=none; b=bVcJ69y+6yQ+D6AUfqdMgV/zuEQG7oeCBZAtNz8ipIB10d3SceRmVMBgEOcQhO5DkS2FVpXcWKedXfxALAimTWPgo3LSsWPrqxyK0VlhLXgC95jRHK9RFY5UZMivSFQP2L9QEchnzsIm4dbuf454Efvy0rz1Ok0K6buz7B4Dqy8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715867429; c=relaxed/simple; bh=+l5lbCFIm//wJUc5+yeD8GI6F0hampDbfJkWB4zJVv4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=D/FsdkXynSUoIApiv1DbbSUZSSqzGs/uaaCYTE00R44PCp4ARNcZKdI41VNwUrQ7Asql7pFrnXkV97pg9ZXSKNFziQCyHtUKm8qBYbW69skCxi2AFtGhyebW5em5r2jdrbgWnA0fA9mAAH5ai8jbd39Ai+kZITkWOXCqXKZxaDI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1ec4dc64c6cso58502245ad.0 for ; Thu, 16 May 2024 06:50:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715867426; x=1716472226; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=kaIBwDGHn3yOZtg6nLqQsGqEhRpFKsH/bzxxbYqwsrE=; b=CfQD3rwWJvIUQvQvpBfbr1YDxLYJ+6JETEzPhjhYwFqykVknQ1RfW/BqTsr1xYi8Nr bznFTjRkaY2jvQgZVPlQlFynjcF1w0AQf6LXS8cnlv8737A6RvlrCoHM687jI8xNXKuR cV3ouPz6MliXQhMWIqID8jYfDR0dh38gXUfxqdVNbs9Gw6HSCOmi6If4qVv8Zs2M1bN3 H1v81rsbxPLDr7malERaQSFe1+IInrSHv7sdTkjGEh7OWiaLykoNBWzamg1eYdqqhYty gsKVkUg4i47lI0efTkVEx/LY+66Oc96LGCDiJ0eRmHUdwQBAtZp4mj4JJTuNZi5RhsZQ THuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715867426; x=1716472226; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kaIBwDGHn3yOZtg6nLqQsGqEhRpFKsH/bzxxbYqwsrE=; b=Mgp/d35rsKd96/vtUkv7vg+/+aC0ltLTXTXdWz8DVmIyUpX3Nzh68lu3QCIwCDPlDc So8t2a1fESEY15bmUrYQpfbye+kzRrAn6DF1DCXDOQ9/dTYPn0tWbkDBKcMxO1XE3afe asrOwqG6go+cjUGpfjHAnRYL62NjeP7GC1V8l4hFoT1yFVgu2QPpMBoYfiko4/SAqufl O+FeIVNYQbAQnJFl10q9R/X+bbZQl4UM25u0MQZl9KFrvMXr1jhcnRGRjhx4fdTP2f61 dvXDg5pvdaryU1bhMH+vjj1x+bhNWJyjH5QKwDgoVODtyshCTD9eCxaMztLtOzNGgKn+ KUtA== X-Gm-Message-State: AOJu0Ywpi3zfQRzuw0jd67JwkAvFJ+SNcDyaGSjTR7z3LuQEU49WDFsz 7XSZZxB02I+odcSmcXxE/WkHT0hlsFJOEs62RuqNuZUWd7TSFcf9q82aTQ== X-Google-Smtp-Source: AGHT+IEjUwSmLsD4Ke8foCCS6ifB0zWjLgCdzBkPBsCyT0pKwJd/fTnkD5z062cescczJXby7xbL7Q== X-Received: by 2002:a17:902:ce0d:b0:1e2:61c9:85de with SMTP id d9443c01a7336-1ef43d0ad21mr276233355ad.4.1715867426528; Thu, 16 May 2024 06:50:26 -0700 (PDT) Received: from gnu-tgl-3.localdomain ([172.56.168.158]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0bad886csm139119605ad.70.2024.05.16.06.50.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 06:50:26 -0700 (PDT) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id B930EC01CE for ; Thu, 16 May 2024 06:50:24 -0700 (PDT) From: "H.J. Lu" To: libc-alpha@sourceware.org Subject: [PATCH] benchtests: Add fclose benchmark Date: Thu, 16 May 2024 06:50:24 -0700 Message-ID: <20240516135024.557291-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.45.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3020.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Measure duration of 100 fclose calls after opening 1 million FILEs. Signed-off-by: H.J. Lu Reviewed-by: Carlos O'Donell --- benchtests/Makefile | 6 ++++ benchtests/README | 1 + benchtests/bench-fclose.c | 74 +++++++++++++++++++++++++++++++++++++++ 3 files changed, 81 insertions(+) create mode 100644 benchtests/bench-fclose.c diff --git a/benchtests/Makefile b/benchtests/Makefile index 7e73b8504e..b74b5fe1ad 100644 --- a/benchtests/Makefile +++ b/benchtests/Makefile @@ -261,6 +261,10 @@ stdlib-benchset := \ strtod \ # stdlib-benchset +stdio-benchset := \ + fclose \ + # stdio-benchset + stdio-common-benchset := sprintf math-benchset := math-inlines @@ -269,6 +273,7 @@ ifeq (${BENCHSET},) benchset := \ $(hash-benchset) \ $(math-benchset) \ + $(stdio-benchset) \ $(stdio-common-benchset) \ $(stdlib-benchset) \ $(string-benchset-all) \ @@ -419,6 +424,7 @@ VALIDBENCHSETNAMES := \ malloc-simple \ malloc-thread \ math-benchset \ + stdio-benchset \ stdio-common-benchset \ stdlib-benchset \ string-benchset \ diff --git a/benchtests/README b/benchtests/README index 998ba9b2b4..15d014a407 100644 --- a/benchtests/README +++ b/benchtests/README @@ -87,6 +87,7 @@ where BENCHSET may be a space-separated list of the following values: hash-benchset malloc-thread math-benchset + stdio-benchset stdio-common-benchset stdlib-benchset string-benchset diff --git a/benchtests/bench-fclose.c b/benchtests/bench-fclose.c new file mode 100644 index 0000000000..c1cdf03169 --- /dev/null +++ b/benchtests/bench-fclose.c @@ -0,0 +1,74 @@ +/* Benchmark fclose. + Copyright (C) 2024 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include "bench-timing.h" +#include "json-lib.h" + +#define NUM_FILES 1000000 +#define NUM_FCLOSE 100 + +int +main (int argc, char **argv) +{ + json_ctx_t json_ctx; + json_init (&json_ctx, 0, stdout); + json_document_begin (&json_ctx); + + json_attr_string (&json_ctx, "timing_type", TIMING_TYPE); + json_attr_object_begin (&json_ctx, "functions"); + json_attr_object_begin (&json_ctx, "fclose"); + + FILE *ff, *keep[NUM_FCLOSE]; + int i; + + for (i = 0; i < NUM_FILES; i++) + { + ff = fdopen (STDIN_FILENO, "r"); + if (!ff) + { + fprintf (stderr, "### failed to fdopen: %m\n"); + return EXIT_FAILURE; + } + if (i < NUM_FCLOSE) + keep[i] = ff; + } + + timing_t start, stop, elapsed; + + TIMING_NOW (start); + + for (i = 0; i < NUM_FCLOSE; i++) + fclose (keep[i]); + + TIMING_NOW (stop); + + TIMING_DIFF (elapsed, start, stop); + + json_attr_uint (&json_ctx, "number of FILEs", NUM_FILES); + json_attr_uint (&json_ctx, "number of fclose calls", NUM_FCLOSE); + json_attr_uint (&json_ctx, "duration", elapsed); + + json_attr_object_end (&json_ctx); + json_attr_object_end (&json_ctx); + json_document_end (&json_ctx); + + return 0; +}