From patchwork Thu May 16 10:14:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Earnshaw X-Patchwork-Id: 90274 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 22BE93849AD0 for ; Thu, 16 May 2024 10:16:07 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2048.outbound.protection.outlook.com [40.107.7.48]) by sourceware.org (Postfix) with ESMTPS id 9B6943858D38 for ; Thu, 16 May 2024 10:15:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B6943858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9B6943858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.48 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1715854535; cv=pass; b=WGgmvmt44KzqcyuBJWIxjmmQECZey5Pq1gC1bOYfRn1Qt2G3+9lqEyYxf3cBPMgJBvrtk8yz7nHaonuXtHM09Hv+l/qq/p2jS3Ao/q77sOIj9Z2GTiVoThq6XIA29LKz2tCBYKQmXHQpEYc5cmnW5TAxzKCmfVqIDLgyogK+mss= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1715854535; c=relaxed/simple; bh=DMx81l1A3Fm7ZZdp31LSPKjxjgxz1obuu+qLoCOAwxs=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=xQNjaZ1FfgzI7mdX+AW7iC1kTjL+8ZHhAPkDwLJG8o5IHPSEr6dneyd8IVmDIF6uRv4cdpA1yu5o7jWxzXSMRsJVB3W0zLOvchDDDbLraxo6PHgMzG0GzGGGEmmERhMLy/fOx33mWINXu+7R1QVspWh0WctAAfe7u6wCBWPMrss= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XBxxV7ckWJU0Z9KyLdNf1pN+GBEx6TaqNwm9Yz76ti44SlpzrXyva/UxVZxTYW6Q82zzxDBEWbxoKtjUNUXhRyDzcjh0wutXjWdOKcViryQ6RcuVoPeGSaDHfd6kk4wnP4D2Evd53umugHZSOELyuYTVgJPEjQEppp6QENQNFCJAgvAy7XLwiH+XTrbrLTHOlyjoejLUy5D1LF8W8Kz+8Cu7t/DToYK04+XiRyLa66bs5636fYtKJCjQwLESxY5JmLQFdkFhpJpdtBuStmnYV8f82d8mnmRJeNzwmapa/y8gtDLeqAAgy13SBYnxmR2nFHjmbceeXmMoZLVCATAWFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kKWbQ1rpvc8fbWkdJf7jvIwCuS+N/h0RePyZgO09pLY=; b=BLXj2bsgMxWozxrrM7oIHvGhNc2iLetKPba9PjIBh87xdHQnH69b2NhUQ+yOtmRNLgMg42UIOzu4k/Tj59Wc9EOKWESOkCkoTWdhNKv/hSJFhIizHuXbqbWq6LB3YSnsxuBNVR7d2JwAVhyHz/n8P6+GHMbsjw4r+mg3JTslq9wRmR817WC/a1uodwDmYAiA7Xm51q21YugLgyz85WWYWh5RYUmIKl5p+IBp9DRvscZBH6XNFuIrwri19S9iPp0anwp63FaciOLXY9We5zaoJhWpxW2I7MYwILETqQTbdCcLIpYy6lWO9JiT4cDiV+fdKrbqe26J87PZNX9UCsRKyA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kKWbQ1rpvc8fbWkdJf7jvIwCuS+N/h0RePyZgO09pLY=; b=ckoKHxSMkCcEwtUeUJlr89ACeLlWHfs1kaZ/Wz/wlnCnRtX6BuVoPmvPIb87H/9lYsqrBhgOXFEGln9tBiGJMrwVhvc6pyN2x9QSK8MjJHpqyk5xqJ2PzVGM8XTFS0Ii6dpEETG/dSeWO6vc1ngYlqKUReYu/BxJamWVxZy/g6I= Received: from DB9PR01CA0018.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::23) by DU0PR08MB9461.eurprd08.prod.outlook.com (2603:10a6:10:42f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.28; Thu, 16 May 2024 10:15:30 +0000 Received: from DU2PEPF00028D12.eurprd03.prod.outlook.com (2603:10a6:10:1d8:cafe::37) by DB9PR01CA0018.outlook.office365.com (2603:10a6:10:1d8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.27 via Frontend Transport; Thu, 16 May 2024 10:15:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF00028D12.mail.protection.outlook.com (10.167.242.26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7587.21 via Frontend Transport; Thu, 16 May 2024 10:15:30 +0000 Received: ("Tessian outbound daa456608199:v315"); Thu, 16 May 2024 10:15:30 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 55d06a29ecb2ccd8 X-CR-MTA-TID: 64aa7808 Received: from 45e5dfa32778.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A39B5E8A-FE00-4365-A650-21DD12910577.1; Thu, 16 May 2024 10:15:22 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 45e5dfa32778.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 16 May 2024 10:15:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LcL0XBjryy47xnkg9c13VDBXHQ5r5txe3CmfwI8oJT+hhRKAd14zfF38JekjF6aJxzIzsSY3G9sYHE2Sti/TdSyqiuHi0+HJVtZSiehGWYk5kEn3cQyKG95eQ/Ex+IXW1XOH8WrYSacsreW4KFotnCQqekGz3AL3J2aJZhFq+ntBcWRgPSoS0wE1a6fYP65CYevORf461DogXIGi6bHiVTXdzxK2BnKitWIU0+J6J4xWquEIfwd/DthizL7jIHJVDUIxIALPQw+lq3O8TzzlaKd5kNnncwlbOM3IVm3XO2hbNDgmOkPEzDTz1jcZ9NwFJUVXuAHzuPVM8KiqCv/+lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kKWbQ1rpvc8fbWkdJf7jvIwCuS+N/h0RePyZgO09pLY=; b=DzkBLoMFBGLaT0EHCiaYr7/xPEBnJKXtmoTVZ8K0FrSOiwywyquWM9GJIVzCg1iJwMCHGR+4CIVEuQxBoonKheZT8mADp5MuVHVhQg3Hd6OquxKmKc0bJTWLsEaQD86I8bYCkUD7cyFNtEpft5IkYwxNYH1gPKA1Ha1Ai7ej/gQ3qZqkwUoCzrsvGqSwpV1u7Hpj8osFYxF4jZZ1O3dYFxl4MfC90tdPmkC0vigt9oqdnXzLjdP9BpMpaQa4sbqaAjssZikv0UBiQCxWTgmU9o1cPdnbfJdPGiBwu40FqsDe3qoSWQlvusd0NrcrHnWRZvJn7MiMrO6o/ev+/9pkdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kKWbQ1rpvc8fbWkdJf7jvIwCuS+N/h0RePyZgO09pLY=; b=ckoKHxSMkCcEwtUeUJlr89ACeLlWHfs1kaZ/Wz/wlnCnRtX6BuVoPmvPIb87H/9lYsqrBhgOXFEGln9tBiGJMrwVhvc6pyN2x9QSK8MjJHpqyk5xqJ2PzVGM8XTFS0Ii6dpEETG/dSeWO6vc1ngYlqKUReYu/BxJamWVxZy/g6I= Received: from AM5PR0601CA0054.eurprd06.prod.outlook.com (2603:10a6:206::19) by DB9PR08MB9634.eurprd08.prod.outlook.com (2603:10a6:10:461::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.27; Thu, 16 May 2024 10:15:18 +0000 Received: from AMS0EPF000001B2.eurprd05.prod.outlook.com (2603:10a6:206:0:cafe::85) by AM5PR0601CA0054.outlook.office365.com (2603:10a6:206::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.28 via Frontend Transport; Thu, 16 May 2024 10:15:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by AMS0EPF000001B2.mail.protection.outlook.com (10.167.16.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7587.21 via Frontend Transport; Thu, 16 May 2024 10:15:18 +0000 Received: from AZ-NEU-EX03.Arm.com (10.251.24.31) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 16 May 2024 10:15:17 +0000 Received: from e120077-lin.cambridge.arm.com (10.2.78.57) by mail.arm.com (10.251.24.31) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Thu, 16 May 2024 10:15:17 +0000 From: Richard Earnshaw To: CC: Richard Earnshaw , Nick Clifton Subject: [committed] arm: remove incorrect handling of FP bignums in move_or_literal_pool Date: Thu, 16 May 2024 11:14:59 +0100 Message-ID: <20240516101459.994247-1-rearnsha@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AMS0EPF000001B2:EE_|DB9PR08MB9634:EE_|DU2PEPF00028D12:EE_|DU0PR08MB9461:EE_ X-MS-Office365-Filtering-Correlation-Id: 00e04cf7-8276-4999-3bfd-08dc75911d4d X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230031|1800799015|82310400017|376005|36860700004; X-Microsoft-Antispam-Message-Info-Original: Gkz6XRh8P+8qkzg4RE31IqD/OwF8CsB20efPMhOci/e40L7Zv50kLlp0GAermoiBntv1zKPtjKEM8euPSdVE2mqL1wwfAubr9zxS9v4P78XF+Pkqs3m0GAAFMVzjeZzHnbkT4c/WrnF3CzEA4/aKov4DneqzvI96TTCLFUeIsTBnj/RIOdPshvGJ3QPNTmtJ2xMMzGVtChp2pNJLK/UsZVj2n6QKPEd6/Um0t8vH0VGief7Srdk8GokaWJrAEt7yPJHWtBrglrNbdxqYUMlVKxo6DTbXGxHO4udXLurlgsH778fv2rFw/gZFXHn9Tj7chpelJWEbQGlNUlTkwuW7FqKZUWmiHF981jDdaNrbNRANLO+WgIH6ekxQy7eSQWDdItw3onWZPMjckd1ApqAx4IIP5/9cWc7dDMLDbt78alr290zg3jiG/WPUH3c3tcY/Uj9g7e1+B3KZKe+LjnRS9WKXq8FMVHZgPk/C3WeYluKt3M+sLxv+26wwWJ55jrg2IKtl5UYMAnNX4wCbm4MAE23OOtmi/fHtf7hfyyeBG7OcmmITvmGVDbGP/JlFwEY0p91gIgrwXt0HqCx06945FMCNdw8Dt7SgpbIy7ZZ/70+hrO7Nxl/moHriMAwvV8YGEsVaWj6Ux5cosIumK89Jig94d+WUyDFdXhOLtyhiyIvtSkb6li35Jl0nnF58KbPZktz82vO3VYhqL5HG+olMT3PKMvrQjEmLHxvquLPWuF5MMwPGJV/j9YI6AX/NxVZ8ECnjd4AfIxtuQAn5ZymTkyKJXvUEk+ImJsPrJEJRYFG1/2OZivvfY2J6e+dDXQbLX0GzupF0M+/s674et0vNwsCkD5vbyD8uwGTnNciQL617FdCrtaH7y08zNi8yRklivz8EnPxeSSKUURBUEfH7obSKrP6VprhNpHMSTOetH9DbRYpQ4K4CfG3yBIEhFgv2KfdSN8kgvd9WjvP3ddxYa1DX4AFCK8szqFu7Jmyx5LudZxtKO1RfjJCx8WwYyPuLO5s7qE/sF4vetiiIplQFlaBz4i4Cd4pLCRNBVr1ao6hdRrKZO5PDK9vwHDPJ7Z6eoyYaLzrn0bCiCSmQ3EFujSEHZCEskqE/1FYoT3vleJFIbSZBl0+BufzBMIh5V8vRo6E+V9rj7kKdc4VoCHqNpbIltiyZY+f2ka2I+cwNfslS0LEJFRX/aoyS+uR5o7iwaFjRkiY15+1P/nzPTPIBUZWJNoGU+BD7o0zIYrzkETPIYKiLT5p7gYxOsXrP2iIg2P5UaT2qNV12Sc382ni/Rt9Ybq/GRW9RS2Fsali0Zll0Fv+WDNk9KW1KMLrveofrSJ1MI87C3SWTgXsqqEp+lwDV8faWlkYkrS0vZPiLpvxy7tMh3//9VLAZ/lzse4Ea X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(1800799015)(82310400017)(376005)(36860700004); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9634 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D12.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0c5fa90f-df7a-4444-229d-08dc7591167f X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|1800799015|36860700004|82310400017|35042699013; X-Microsoft-Antispam-Message-Info: =?utf-8?q?4NGtGt4FFjraPFwNhOXqWZbKSSAJZxa?= =?utf-8?q?q1zzHkgmIn+4qVsNDfhrzpJYG05joWH7I3Y94zMCKLMac9UTb1rEbn6bgouzaZs1M?= =?utf-8?q?snSOr2FP70/lU3xEIBprIogkBamN3GgPZZ1Qa1gREReg4Nr4UnoSw4O5UcspKa3TI?= =?utf-8?q?uYx+R7XrDXfiEq0oFNjeSWWZIsYGyNtQCkGMJlwSYt0dHVuoL1RdLyGCuVgGyPJS5?= =?utf-8?q?VFU2a9pfTd6EzAIPnutTmxWR44w7Ya4k+IW/svqNS8DjaKZBjHMwCMSKjYoSu1XHT?= =?utf-8?q?B3q9rlImZ/bO0VAaPp5qkUP8Q2IxBgp1xn2SEm/3ZSuGNUxLRjty1pciH1a0qh+6o?= =?utf-8?q?VHUzHGcl2XrCEipn+Ea63bjUu8HJspLDfC7JmuJR12vnHzyz+d9O6SdwkmVej9LsV?= =?utf-8?q?QryLVRHZ1wkX77eULPjSZnPplhcWx7nQ9A/LE/prNj30IZcGhwEDoOPJcJrbYbcoz?= =?utf-8?q?La0OKJXS62UudjHB0R+JTC7jtABzPBL5tKWx3xbY1xWEwQB/IfskBCEUi3JoQAnKa?= =?utf-8?q?5kOZi+4V4I4CzMZuIHLZB6GSO8wFPF1sP8cV1yBo1oWXxq+R4q8n9PRELAhF/EAN+?= =?utf-8?q?0WgBgGutlNRUCChmzcFUpY1bsqT1HM9SRUXNn8Q0P6XWVgswUqTvqZJH3a1aLtC/6?= =?utf-8?q?B4KuuipeAbpkGGAes/BjSpbYADZ8uLnpPVjUiQwmKEGCFFI4UfQBREEANHliXVGTp?= =?utf-8?q?Ke2RzW7X2qLtOxwKgJbWc/FRCuXzCfEDxhK71/IY7EcRV7apUy9/q/TGgqKQS02Yb?= =?utf-8?q?VeDGM1Ft2FoMuErlXW4vbVbS+M2LDYeRhr1ZTFpEmGehbB0PqdqrX9sSWrkb7bbXO?= =?utf-8?q?d2gVSJJTPX1mzv1FKMT32nTzWldD0Fo82+F6VmfhIipcSkT5V9+Drs6BLHOBwjwq3?= =?utf-8?q?8CB44CE2IRfUa3lWHCjOv66azw6wnVvpI/UnwuN7A4tjkn+zAWttl9Ewn3ijImHlw?= =?utf-8?q?IRcdwkIAnhGmbZ1fS84FdVvzWCNg2GpN2m94Aw6HHe33KlCs4xs2ZdTP8r2nuN3Zx?= =?utf-8?q?X86ldFtkjG1iKu4eEQzYvIuzgVpK3tCWPePX+zBZF9wynxslYFOmtV5mbeknHw37H?= =?utf-8?q?3XujlrS/5wtzBO7LPKjvb8SlRBj/gI3bTJhDM5uPM11E8CZ5B7WtN8h1eNdkpfocm?= =?utf-8?q?MabCeyP/1W/+7/f1bNj/g6WJT9i08pCyZp3V+n/Gf+9jxX9ikBDZjiIJ73+lDg8Sa?= =?utf-8?q?S9E37lsE2sNXhYyp6xKnubJzyPi1ulAaUfsifSjm7FOMyz3GiJr6pvYDbx2bPqaLP?= =?utf-8?q?9lplVJD9fXrMYVeT7svq+jpYXsasl4yQG8TkuKrPWMW4554AfhVHNdmHpyoIHKSxz?= =?utf-8?q?fcc13ca5cEDc?= X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(376005)(1800799015)(36860700004)(82310400017)(35042699013); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2024 10:15:30.2076 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 00e04cf7-8276-4999-3bfd-08dc75911d4d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D12.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB9461 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org This hunk of code in move_or_literal_pool just looks wrong, but I can't find a testcase that will tickle it to prove it. It looks a bit like it was intended to catch cases where a bignum contained a floating-point value, but there were a number of problems with it. - It tested X_add_number == -1, but an FP bignum is indicated by any value <= 0. - It converted the floating-point value to extended precision, but that's not used on Arm beyond the legacy FPA code. No attempt was made to match the FP value to the intended memory/mov operation. Since I can't construct a viable testcase, I've just removed the existing code and made the function error out in this case: this seems more sensible than generating wrong code or trying to write something more complex that can't be tested anyway. --- gas/config/tc-arm.c | 30 ++++++++++++++++++++++++------ 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c index 343b2e77d7c..41bcfb8dee2 100644 --- a/gas/config/tc-arm.c +++ b/gas/config/tc-arm.c @@ -8922,14 +8922,32 @@ move_or_literal_pool (int i, enum lit_type t, bool mode_3) uint64_t v; if (inst.relocs[0].exp.X_op == O_big) { - LITTLENUM_TYPE w[X_PRECISION]; - LITTLENUM_TYPE * l; + LITTLENUM_TYPE *l; - if (inst.relocs[0].exp.X_add_number == -1) + if (inst.relocs[0].exp.X_add_number <= 0) /* FP value. */ { - gen_to_words (w, X_PRECISION, E_PRECISION); - l = w; - /* FIXME: Should we check words w[2..5] ? */ + /* FIXME: The code that was here previously could not + work. Firstly, it tried to convert a floating point + number into an extended precision format, but only + provided a buffer of 5 littlenums, which was too + small. Secondly, it then didn't deal with the value + converted correctly, just reading out the first 4 + littlenum fields and assuming that could be used + directly. + + I think the code was intended to handle expressions + such as: + + LDR r0, =1.0 + VLDR d0, =55.3 + + but the parsers currently don't permit floating-point + literal values to be written this way, so this code + is probably unreachable. To be safe, we simply + return an error here. */ + + inst.error = _("constant expression not supported"); + return true; } else l = generic_bignum;