From patchwork Mon Apr 22 10:00:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 88856 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E86243858402 for ; Mon, 22 Apr 2024 10:01:02 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 8D7C93858D38 for ; Mon, 22 Apr 2024 10:00:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D7C93858D38 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D7C93858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::435 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713780030; cv=none; b=PfNG3Nl6eehK7+xr8CT2wx2oH5ZiZwv2OfcYo+8x2ljY010ySLBpoeEGeevQC5j7VX6U5QcgKOfrub3hgNozxCGtQDGyaqYxsU0LQJwkDFih8k2stH40kVIgDEerM5EvX6vTFNJBS46fBA+n2A+Xg2bUQCGZdXx194P825tws5c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713780030; c=relaxed/simple; bh=4SUBzEPA+q0lPAxs44ggvJpsupwWb5CXmoBkrHyEf50=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=bNDGnzpFGh7fZB75jg9PDqgmYyzGAL8odGQuVz1EMhRlirHLxbxd8dhuZrkb+X90kYh/VtuXW2WTcph/p0/XuUTropxOSuXRjuCA/y7UzzXl7pUZeuRReAoYP9MkiYpgqUumR/7mf6JsbOODxv5p+CYM6tSyRaEsWfDFX6A7iTc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6edc61d0ff6so4169981b3a.2 for ; Mon, 22 Apr 2024 03:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713780027; x=1714384827; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=z1xTALL9wv6x4RI7U98jVG11t5vVArJ7voB7xD6DPwM=; b=Kcg7omFzouo4UfBBZxuLgFpjHUAtvxHzcTak04IShztW9EVp2RaVdFuW9GEu0TLKvl HbPbAP4cHTg2hFXgTvmM3LSnbJugTCpBLrq4CNBFSKsyTbCwnZTIvCZwBVvFP9y8ILKy FnYLHE/hlvPLas8lNbmT7vvtQr1sN6x2vFZeteqdOTohOeDI39gW9QI//cA0VYiUsclT e6NhEdjkV++eBmBbkGhbCoxqFAOEPixOT3XoibRvvj227vI0DazZ5SrrUhN9AYLhKsM5 nZvDpT6gSRP6jr2PUwZAkFG3iUANEC/OsVzeHvwtsVD1yaXjhe5kdMyDAnNjJBzoe9Xw XsUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713780027; x=1714384827; h=mime-version:user-agent:message-id:in-reply-to:date:references :organization:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z1xTALL9wv6x4RI7U98jVG11t5vVArJ7voB7xD6DPwM=; b=i2nl4OZxSc+km1PajiXBt+rwwICZAvOQ9tYNn6CmjoiNngDq2nTHbkMyTT8aY2MLpN cXY6JTnG7bq+KXO14FjrNEAupGergc9EZ3UuJdPmzsDqMxva1XuJ/ij/XGJa0rhWzw7t ca4VmRf69iOtbw9CmbR3eSQLBTUZtg7rM/Zptg16YefDuu8PE63Jk32t5xyIfn1Y7Cog CCSXR5gjwguDhlR5vgBBx2zx+RMjizfjiwQO9qjKRa7OkJf5ax06Z6kZO+P6TCx5HQCB lvJEoJ4KiCPB6ddojPEmMyund5vLdfhGoFYauJkLPjNBCdfwYXaWiXb+1eustXvM52op 7sJQ== X-Forwarded-Encrypted: i=1; AJvYcCXQJrYeO1z+6Azt9kWaRWPZSxxANIkT/4Aa975jW9mXwEa2ftfgcWQKCw6a/lcFtIy2/xIJj1NS7UyevkSbZADGgWQThrkFxw== X-Gm-Message-State: AOJu0YzTQoRv5Y4qQ1KUDpWYHxLxNhm44RfdGWYi6B4YgFdHq8kZpYdy 1Ezdj8kqODjycMT+4EY/DtX+s26kC4FF4unq2/lE0/4ZSBXAjR0scjAUOcyf3Q== X-Google-Smtp-Source: AGHT+IFe26QzctBo8tjuKP4hSgKERYLEEkcKNd2Rg82slHr57c+Qo43sNGQjPWdk/Pfs7dYuGbI49w== X-Received: by 2002:a05:6a00:3d04:b0:6ea:c4e5:a252 with SMTP id lo4-20020a056a003d0400b006eac4e5a252mr13247764pfb.5.1713780027319; Mon, 22 Apr 2024 03:00:27 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id m6-20020a62f206000000b006ea80883ce3sm7430167pfh.133.2024.04.22.03.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Apr 2024 03:00:26 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43MA0BKP020545 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Apr 2024 07:00:11 -0300 From: Alexandre Oliva To: Joseph Myers Cc: Rainer Orth , Mike Stump , David Edelsohn , Segher Boessenkool , Kewen Lin , Subject: [PATCH v2] xfail fetestexcept test - ppc always uses fcmpu Organization: Free thinker, does not speak for AdaCore References: Date: Mon, 22 Apr 2024 07:00:11 -0300 In-Reply-To: (Joseph Myers's message of "Wed, 10 Mar 2021 22:33:09 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org On Mar 10, 2021, Joseph Myers wrote: > On Wed, 10 Mar 2021, Alexandre Oliva wrote: >> operand exception for quiet NaN. I couldn't find any evidence that >> the rs6000 backend ever outputs fcmpo. Therefore, I'm adding the same >> execution xfail marker to this test. > In my view, such an XFAIL (for a GCC bug as opposed to an environmental > issue) should have a comment pointing to a corresponding open bug in GCC > Bugzilla. In this case, that's bug 58684. Thanks for the suggestion, yeah, that makes sense. Fixed in v2 below. https://gcc.gnu.org/pipermail/gcc-patches/2021-March/566523.html Ping?-ish gcc.dg/torture/pr91323.c tests that a compare with NaNf doesn't set an exception using builtin compare intrinsics, and that it does when using regular compare operators. That doesn't seem to be expected to work on powerpc targets. It fails on GNU/Linux, it's marked to be skipped on AIX, and a similar test, gcc.dg/torture/pr93133.c, has the execution test xfailed for all of powerpc*-*-*. In this test, the functions that use intrinsics for the compare end up with the same code as the one that uses compare operators, using fcmpu, a floating compare that, unlike fcmpo, does not set the invalid operand exception for quiet NaN. I couldn't find any evidence that the rs6000 backend ever outputs fcmpo. Therefore, I'm adding the same execution xfail marker to this test. Regstrapped on x86_64-linux-gnu and ppc64el-linux-gnu. Also tested with gcc-13 on ppc64-vx7r2 and ppc-vx7r2. Ok to install? for gcc/testsuite/ChangeLog PR target/58684 * gcc.dg/torture/pr91323.c: Expect execution fail on powerpc*-*-*. --- gcc/testsuite/gcc.dg/torture/pr91323.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/gcc.dg/torture/pr91323.c b/gcc/testsuite/gcc.dg/torture/pr91323.c index 1411fcaa3966c..f188faa3ccf47 100644 --- a/gcc/testsuite/gcc.dg/torture/pr91323.c +++ b/gcc/testsuite/gcc.dg/torture/pr91323.c @@ -1,4 +1,5 @@ -/* { dg-do run } */ +/* { dg-do run { xfail powerpc*-*-* } } */ +/* The ppc xfail is because of PR target/58684. */ /* { dg-add-options ieee } */ /* { dg-require-effective-target fenv_exceptions } */ /* { dg-skip-if "fenv" { powerpc-ibm-aix* } } */