From patchwork Tue Apr 16 03:18:52 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandre Oliva X-Patchwork-Id: 88517 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B3B853858C53 for ; Tue, 16 Apr 2024 03:19:34 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id 8E7293858D35 for ; Tue, 16 Apr 2024 03:19:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8E7293858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8E7293858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713237547; cv=none; b=n8qYLy8fL/Djuirc5qzWU5B4tOLkeWi+ZQ54dc8H6PAatyWiaAD7INrIjaW1xjxEmb+lZ3VlMaHKDZNUn7bXS746Yxnu2qVvpt+S11NsZ/z6ZB6j/MdfmdvgcXWx+sQKVvu9G5jcezkXNcccnd288ZP/OR0u2o1pPWlfMXcO37c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713237547; c=relaxed/simple; bh=brN53IZ1PD2jNSq3m7iT3yWNmQUFlbNb/Pvh+pQEl3U=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=KrGnkidZmKfJgxy4/7oilAqwhfD0NmBuCo2lsp4QdQfeJJEniZpMm/eIFl3k2XkwfII2L6XN3ivZjJesLueCHI2372cD7TfkKvEzg2Q1ZPkdiyCfbHiolub6IxWgf2HX7NcACJy1liApyCfhIFIZTwR1i1zowhQq81WlNUssFnw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-5c229dabbb6so2281933a12.0 for ; Mon, 15 Apr 2024 20:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713237543; x=1713842343; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:date:organization:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=zgaXPkXOOjz4Wg5UtloaEATAVukzRgcAQYrY23CYzLo=; b=DXFeI7Pcclo8fBiMUQYVWiIOGriA8qcPJ8DX5q3hhOwd44LDosjl5H8B7TO3hGSM2T RQaS6MmudkM+M7vreTLpVG/YTbTmrIjaim1fG3NMl3tL+j3geoz5wgMapwux/7VKvPma SlmKWwHP9f2efoQxvvy0pxu+UvuwcitPE3nFum91CHdL7+BgBd1DepU9hugZM2CUp5D5 urQzVO3COa93dp+slkGY3AaEWF6el4vDCeRBoJK6z1xmhNjjtDHUEu0chzRGcw2C9Z4N Wy1zI34F8eD220qhe1MHa8yOPj+SoYjAbxK1MlFCEe/boz4PKV6i+TcmUlF9OSmvIIe4 0mTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713237543; x=1713842343; h=mime-version:user-agent:message-id:date:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zgaXPkXOOjz4Wg5UtloaEATAVukzRgcAQYrY23CYzLo=; b=EcjJnMIUuG5+AC+00Em8h8b7DuXf94TlVZcPrus/Y1jU0x7/arvGlEsx4G4pndt9m3 u6GDteNe+/Sf/E/OLLCKWq/RkZh1WrERojTgclm6jMaCafg7p8fHtixrWluLKO+ZYyUg ATRLlPeRgg0hdpxYUifDDaC3hSypzsgV9McydRQBCYnJWxs/YGyONIasMx4Nk/fZGcOD 5spfjwCPcLyA8s9FAYIuCPf5PUNvCW6AETpjt5Sn1l8KRGF/PZKeHHi3+1MPRujJRraY atCawAm240hcBNDoRy3sfEqbwB8lAvLLDgDRg3wv/FkxymbpHpEvj1CahPuMNVjnDFmp RT0g== X-Gm-Message-State: AOJu0YynwmXAqX92Em8C2F/whSMGU6zQNFnLRQml5rF+5qx22xQz+tVJ EVedQuEHWfCIiuW7X7LAYYjJxZgGPzDfKdCN6cya4aRSFpZOwQ82FeHtxClIHx0/UiXP5QvCw2U fOA== X-Google-Smtp-Source: AGHT+IFwwhG4PFwgtKfreODUL3huniryCi7aGxDLqrgjFr1SHvDckVlDFcwWniFnvA+AcfESjj+LWg== X-Received: by 2002:a05:6a20:d49b:b0:1a9:c6fd:d2b9 with SMTP id im27-20020a056a20d49b00b001a9c6fdd2b9mr7636892pzb.8.1713237543326; Mon, 15 Apr 2024 20:19:03 -0700 (PDT) Received: from free.home ([2804:7f1:218b:5e2:c43b:e0c4:71a:241b]) by smtp.gmail.com with ESMTPSA id e2-20020a170902784200b001e797d4b8acsm1925556pln.174.2024.04.15.20.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 20:19:02 -0700 (PDT) Received: from livre (livre.home [172.31.160.2]) by free.home (8.15.2/8.15.2) with ESMTPS id 43G3IqdI2387117 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 16 Apr 2024 00:18:53 -0300 From: Alexandre Oliva To: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: [PATCH] [libstdc++] [testsuite] xfail double-prec from_chars for float128_t Organization: Free thinker, does not speak for AdaCore Date: Tue, 16 Apr 2024 00:18:52 -0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, WEIRD_QUOTING autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Tests 20_util/from_chars/4.cc and 20_util/to_chars/long_double.cc were adjusted about a year ago to skip long double on some targets, because the fastfloat library was limited to 64-bit doubles. The same problem comes up in similar float128_t tests on aarch64-vxworks. This patch adjusts them similarly. Unlike the earlier tests, that got similar treatment for x86_64-vxworks, these haven't failed there. Regstrapped on x86_64-linux-gnu. Also tested with gcc-13 on arm-, aarch64-, x86- and x86_64-vxworks7r2. Ok to install? for libstdc++-v3/ChangeLog * testsuite/20_util/from_chars/8.cc: Skip float128_t testing on aarch64-vxworks. * testsuite/20_util/to_chars/float128-c++23.cc: Xfail run on aarch64-vxworks. --- libstdc++-v3/testsuite/20_util/from_chars/8.cc | 3 ++- .../testsuite/20_util/to_chars/float128_c++23.cc | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/20_util/from_chars/8.cc b/libstdc++-v3/testsuite/20_util/from_chars/8.cc index ee60d88c332db..a6343422c5a91 100644 --- a/libstdc++-v3/testsuite/20_util/from_chars/8.cc +++ b/libstdc++-v3/testsuite/20_util/from_chars/8.cc @@ -17,6 +17,7 @@ // { dg-do run { target c++23 } } // { dg-add-options ieee } +// { dg-additional-options "-DSKIP_LONG_DOUBLE" { target aarch64-*-vxworks* } } #include #include @@ -343,7 +344,7 @@ test06() #if defined(__STDCPP_FLOAT64_T__) && defined(_GLIBCXX_DOUBLE_IS_IEEE_BINARY64) test_max_mantissa(); #endif -#if defined(__GLIBCXX_TYPE_INT_N_0) \ +#if defined(__GLIBCXX_TYPE_INT_N_0) && !defined SKIP_LONG_DOUBLE \ && defined(__STDCPP_FLOAT128_T__) && defined(_GLIBCXX_LDOUBLE_IS_IEEE_BINARY128) test_max_mantissa(); #endif diff --git a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc index 547632817b4bb..ca00761ee7c98 100644 --- a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc +++ b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc @@ -19,6 +19,7 @@ // { dg-require-effective-target ieee_floats } // { dg-require-effective-target size32plus } // { dg-add-options ieee } +// { dg-xfail-run-if "from_chars limited to double-precision" { aarch64-*-vxworks* } } #include #include