From patchwork Wed Sep 29 15:26:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 45558 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC1FD3857C56 for ; Wed, 29 Sep 2021 15:26:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EC1FD3857C56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1632929213; bh=RtncjpFNLyz78SkWFCCBhXWHAhWhhpYgCTQ8zZRg+O4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=P5VJQ4qmF14vHwMV5OBUBG/vBwTiVBtPPCxn0esiXMLtBMV+mkRO9B3fdV7hLNrba dIrfQfsl81Wmsx3cA4kegv1CAfBAOzzjbLe17/ZBxJ0iDl/WypaJ3IaL7thRtyHy6O oxYE46ENrAmn/PufjHcEBdmdiW6mQGpAJhHUj68Q= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 888BF3858C60 for ; Wed, 29 Sep 2021 15:26:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 888BF3858C60 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-_Ysw9Zu6NRC1UbThquPKsQ-1; Wed, 29 Sep 2021 11:26:23 -0400 X-MC-Unique: _Ysw9Zu6NRC1UbThquPKsQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0EAE3801E72; Wed, 29 Sep 2021 15:26:22 +0000 (UTC) Received: from abulafia.quesejoda.com (unknown [10.39.193.244]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B51D75C1C5; Wed, 29 Sep 2021 15:26:14 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.16.1/8.15.2) with ESMTPS id 18TFQB5w1270308 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 29 Sep 2021 17:26:12 +0200 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.16.1/8.16.1/Submit) id 18TFQBnE1270307; Wed, 29 Sep 2021 17:26:11 +0200 To: Jeff Law Subject: [PATCH] Use a separate TV_* timer for the VRP threader. Date: Wed, 29 Sep 2021 17:26:07 +0200 Message-Id: <20210929152607.1270206-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Cc: GCC patches Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" There seems to be a memory consumption issue on 32 bit hosts after the hybrid threader patchset. I'm having a hard time reproducing, and in the process I've noticed that the threader is using the TV_TREE_VRP timer. Having a distinct one could help diagnose this and other issues going forward. Jeff, if you think this could help, I'd like to push this to trunk, but if not, I'm perfectly happy attaching it to the 2 PRs for now. :) gcc/ChangeLog: * timevar.def (TV_TREE_VRP_THREADER): New. * tree-vrp.c: Use TV_TREE_VRP_THREADER for VRP threader pass. --- gcc/timevar.def | 1 + gcc/tree-vrp.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/gcc/timevar.def b/gcc/timevar.def index 16d1657436c..f903833ce9e 100644 --- a/gcc/timevar.def +++ b/gcc/timevar.def @@ -158,6 +158,7 @@ DEFTIMEVAR (TV_TREE_CFG , "tree CFG construction") DEFTIMEVAR (TV_TREE_CLEANUP_CFG , "tree CFG cleanup") DEFTIMEVAR (TV_TREE_TAIL_MERGE , "tree tail merge") DEFTIMEVAR (TV_TREE_VRP , "tree VRP") +DEFTIMEVAR (TV_TREE_VRP_THREADER , "tree VRP threader") DEFTIMEVAR (TV_TREE_EARLY_VRP , "tree Early VRP") DEFTIMEVAR (TV_TREE_COPY_PROP , "tree copy propagation") DEFTIMEVAR (TV_FIND_REFERENCED_VARS , "tree find ref. vars") diff --git a/gcc/tree-vrp.c b/gcc/tree-vrp.c index 5aded5edb11..db9f3cd0a2f 100644 --- a/gcc/tree-vrp.c +++ b/gcc/tree-vrp.c @@ -4449,7 +4449,7 @@ const pass_data pass_data_vrp_threader = GIMPLE_PASS, /* type */ "vrp-thread", /* name */ OPTGROUP_NONE, /* optinfo_flags */ - TV_TREE_VRP, /* tv_id */ + TV_TREE_VRP_THREADER, /* tv_id */ PROP_ssa, /* properties_required */ 0, /* properties_provided */ 0, /* properties_destroyed */