From patchwork Wed Apr 10 20:55:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 88314 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0913A386F466 for ; Wed, 10 Apr 2024 20:56:49 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9A0C3384AB63 for ; Wed, 10 Apr 2024 20:55:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A0C3384AB63 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A0C3384AB63 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712782570; cv=none; b=njLJMkQvHUZhkWSaHmeK5yc+LFhf4sC9uI0Id/l3dZdf3OLFqsBZhE1zYkcSxQMzMQzCr2M7eTb0nylXE6L4wVnEEM7dMZ8oB6/sbsv6UxEv5BoFrTvzusCmN4T3+IGalK60chjL6Rx7bh69kZNOzM/2HEhZdI8J6L+nwu25IwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712782570; c=relaxed/simple; bh=TXIX0Rj0UlsZvc+nYTZDbBJfryvTwW+Xt3VeO9BdPfk=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=PnVHuHrwBcMFNeTOjqjTznfL/Uchjf5tQcpthRzvccM6vsEvzmeF/iZhG81fIE1QtOXhba6dpY1AkmrEZFDOPUxcSVUz1ldvja6AHS65izLDIfrjIO/EmNXtZNyp6gMHFdWGeesdbWGMs+UGWNfQAP4BHgZoCDRz4DP9dR63ET0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712782559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=a/eVc0benJ1Xbyf8mGdFqNrfsrDThFslPVmSlEUwZCI=; b=SY/L6KUsKbE4QTzcyftsNXuaCAdH2+fsH25nF2bwhIUsZ00ri82lbGti4muAvBHh1f6RWO WCSzdxtfYLMGBtcKocgO+V1MftlMXxHKr850xr8xn/9HY8rFBBbV0hEdJV5+5RzcsWrVho 25RIbB2F1IHJDrGjO9N3R5aIypsEHmc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-3uuIGndvPuyAdeCDDkvH9Q-1; Wed, 10 Apr 2024 16:55:57 -0400 X-MC-Unique: 3uuIGndvPuyAdeCDDkvH9Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 43FA5180A1E7 for ; Wed, 10 Apr 2024 20:55:57 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.22.33.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F0932026D06; Wed, 10 Apr 2024 20:55:57 +0000 (UTC) From: David Malcolm To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [pushed] analyzer, testuite: comment fixes Date: Wed, 10 Apr 2024 16:55:55 -0400 Message-Id: <20240410205555.335678-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Successfully regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r14-9896-g082374f6570a31. gcc/testsuite/ChangeLog: * c-c++-common/analyzer/memset-1.c: Clarify some comments. Signed-off-by: David Malcolm --- gcc/testsuite/c-c++-common/analyzer/memset-1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/c-c++-common/analyzer/memset-1.c b/gcc/testsuite/c-c++-common/analyzer/memset-1.c index 75aef53d3487..d6695d494111 100644 --- a/gcc/testsuite/c-c++-common/analyzer/memset-1.c +++ b/gcc/testsuite/c-c++-common/analyzer/memset-1.c @@ -58,7 +58,7 @@ void test_5 (int n) __analyzer_eval (buf[42] == 'A'); /* { dg-warning "TRUE" } */ memset (buf, 0, n); - /* We can't know if buf[42] was written to or not. */ + /* We can't know if buf[42] was overwritten by the memset or not. */ __analyzer_eval (buf[42] == 'A'); /* { dg-warning "UNKNOWN" } */ __analyzer_eval (buf[42] == '\0'); /* { dg-warning "UNKNOWN" } */ } @@ -72,7 +72,7 @@ void test_5a (int n) __analyzer_eval (buf[42] == 'A'); /* { dg-warning "TRUE" } */ __builtin___memset_chk (buf, 0, n, __builtin_object_size (buf, 0)); - /* We can't know if buf[42] was written to or not. */ + /* We can't know if buf[42] was overwritten by the memset or not. */ __analyzer_eval (buf[42] == 'A'); /* { dg-warning "UNKNOWN" } */ __analyzer_eval (buf[42] == '\0'); /* { dg-warning "UNKNOWN" } */ }