From patchwork Thu Mar 28 20:49:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maks Mishin X-Patchwork-Id: 87786 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9CA033858C55 for ; Thu, 28 Mar 2024 20:50:12 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 1A0ED3858D20 for ; Thu, 28 Mar 2024 20:50:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A0ED3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A0ED3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::129 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711659004; cv=none; b=o8nJigs1WQl7RqACcNpZSXiZoRRKCe24rdRkOQ5rSPBiC8Rssmec4740785BQonVmfv4v4LwY/x7pJ5nrz6sU0orwbuN9yKgz0/pZIUP9mr2Zd6SMD+j7PgEEQrYks8CRExLY/DZiu2jzRBZnZevuwRC1EfEZYN1Pwn7whuEIJA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711659004; c=relaxed/simple; bh=PesXTeeH5R5jtwmi64xyUOuZwLWQBNSwt4tgCvmiwng=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=cTr13XLQLPqAuGxLnc6/BFMXG7wEbBqOrv7BL+5gpEmcrZ7AEHMEp5DQNpiP+Aopsxf4/j16yIrlbk8G8uiLFGROBb03Soo8vT1/4gCYjJw2k/u5QNNQuL6qoDvkGXMRwze9FhWvAeFnpyZ61GIaBHMuGgqkxodUZNKcPN0cFxc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-514ba4e5640so2389198e87.1 for ; Thu, 28 Mar 2024 13:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711659001; x=1712263801; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LtbApP4teMZFHnc9po69ElEACf8HCC5xQo02LmY5Poc=; b=g/DLfynHs5eLuPpH5kX3COVazPFDELbyfsp/2nl4YwV3me0pBk88XKTNKGxoztmQSM fYpKdZVbdzX5KB1MvYkcS0G76L4co/fxqz9FPjoC/wCxEx2XepCvG6D5Afu9oCwHRFY7 RhmLELZegX6bSawqxNm8EdckzB1wzvDmF5fc8jfCC6fmt4149mBlMqGB75Z1U8i3qDGi JKtcQIsW9cMcY/LZj4PT5VU6O7Xl1LgM0bd3cnpVdmGlODcd8NxaeIovoxXeeaAfr1BE WV9C07jRLpOE42tspeL/NRbgVXAQdvwM5pKIs/Zr+q+I6R0vkISw3GcTZsoPA1TJEtJy xGMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711659001; x=1712263801; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LtbApP4teMZFHnc9po69ElEACf8HCC5xQo02LmY5Poc=; b=BEFJrrtGBz7D0aLNerEIOsOQJ+jOmAoiy/qhr14kb0m/v7LqFMxUmTAXdnfFsjeroW UKSnanqqEdoot4qbIAZ7jfgKN2I45G5JRHxJ3ip4xoCTVyRe9jbZlmNZ4ZiIYmPRILWK o0BS43ZG7JPRjKYBXr3/j+aBl9CriNQbLhC/fTImjQvcDG0BQ8R+jrikHMZZbJqjxw8Q LCsRYHgvKyZPrzwWL3nfkg02/7k+Q9BEZlPV9ClPgSShdOrWkkO6Y5IjSlAUTJz7zycV fn4/a4T3UKu9xYgq9YywKnKAJJII+dQWF93zhndRxtKlEaPnAtsz0rZLNh+/yz2EBpol He2w== X-Gm-Message-State: AOJu0Yw6fMaM/BcB2AFLMsOvEex28vURf7kvq2b7CY9CSwVdQiv9mELf yyfPAeeLTUVTsZtCjlizMk4ncNh8aRKhKf0+wkz9XMt4as7zyGBxMloz5ybl X-Google-Smtp-Source: AGHT+IErmwrp19NnKQCKjbrjMd7Nlw0Y3VNavXUYRVCAfjrbmm/s8+ZRWaZ6URwXMxuczVwkUxZdeQ== X-Received: by 2002:ac2:5390:0:b0:513:d442:223b with SMTP id g16-20020ac25390000000b00513d442223bmr182055lfh.30.1711659000621; Thu, 28 Mar 2024 13:50:00 -0700 (PDT) Received: from mishin.sarov.local (95-37-71-41.dynamic.mts-nn.ru. [95.37.71.41]) by smtp.gmail.com with ESMTPSA id c15-20020a19760f000000b00515ac3af704sm343906lff.79.2024.03.28.13.49.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 13:50:00 -0700 (PDT) From: Maks Mishin X-Google-Original-From: Maks Mishin To: elfutils-devel@sourceware.org Cc: Maks Mishin Subject: [PATCH] nm: Fix descriptor leak Date: Thu, 28 Mar 2024 23:49:58 +0300 Message-Id: <20240328204958.9657-1-maks.mishinFZ@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org The descriptor 'dwfl_fd' is created at nm.c:1278 by calling function 'dup' and lost at nm.c:1593. Found by RASU JSC. Signed-off-by: Maks Mishin --- src/nm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/nm.c b/src/nm.c index 3675f59b..fee397dd 100644 --- a/src/nm.c +++ b/src/nm.c @@ -1521,6 +1521,8 @@ show_symbols (int fd, Ebl *ebl, GElf_Ehdr *ehdr, } if (dwfl != NULL) dwfl_end (dwfl); + if (dwfl_fd != NULL) + close(dwfl_fd); }