From patchwork Fri Mar 8 19:53:58 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Makarov X-Patchwork-Id: 86994 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4C81D385E44B for ; Fri, 8 Mar 2024 19:54:31 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BC64D385E013 for ; Fri, 8 Mar 2024 19:54:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BC64D385E013 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BC64D385E013 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709927647; cv=none; b=xJywAN1qAGEKgFMuwYMxDrOiFdFWCKNMLi8t85XZzpWk75l31/WX1V9WM9freVm+x0FF481HeCp11zAMtTfBU5PbIvMfVMW1GSMtMtzn76LvN1RtFD/ngtFk1jdF/0K9YBBlWAmFwX3lQhoC834rns7wecPig4mJTWRF39SB88M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709927647; c=relaxed/simple; bh=SqLHDWScMg7MAdeKrnrBWSdVzIRqLEBrA9xHhrj8fSk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=JLmNlP0/s1GNGTTH/OgydiHX1rq+ueXXUWTdh52lGc1rDx1AVy6Hvctgs7P3Njt/I8YUSGJ3w7tTb5tnC9GyrfISJqZkN+xIQ3opv9dnFRFlKEnc0rnVnzpUi9F/5QyunswYUiG142phlEWmtO/M2HlYtEGgwfUTlnkaH+/hQR4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709927644; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=liolLJzYPK1rThIcgU6Gz3/lC00uNg8z9GKdrSV/w2g=; b=H3+APdyAiIef+MaxlLlHS9rCgxbfcqBSWasMuAc//a0zjdHox90/HzSgijH17+phj787ie C1IubxqeVx00cDClhp69Ihhm0fe9YU6v76Z7bRQPB+dXtMXO2FGDDBMQIC8HabJ5jqY4U+ HPQgVWMcz0voZtoMnDvmRLKpIB3f7JE= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-zdToSmIEOUWXiarQVoewzw-1; Fri, 08 Mar 2024 14:54:02 -0500 X-MC-Unique: zdToSmIEOUWXiarQVoewzw-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-787c43db5e0so210589485a.2 for ; Fri, 08 Mar 2024 11:54:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709927640; x=1710532440; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=myWKTlyVSPS7XQL1cDiZ6dQzRkql0bxqyWUduV43KKw=; b=RFkxXXIHWabn8uzalXPHZ+ZPLN47ejOWy43ct+GNk7WI7EhMkinownbu8ej2/k8kkU XMRt3v92C1q8zZZ70uE/36PLj0A2JrxGVPmIPXVgSRfHoZqOB4bDq54InLNpTUj7K8R9 wNLfznPFLQnjlLEFcSJt24qI0DW6+v1Tte+N3yhGqF35ibxppJRYQhkmVPbC60U8IPoS 1XJuMmTYoWjteLyNn6FfgYm57mJRqiPpPtqpfANR52idd6A6fKDb6gLiCCrSZPMcTtiM KWU5nqigNgEzjnEgo7OYCnKtF1AoNp2L60IOwOJoj8cl/aWYHl5F/3Ro/fjXD3Hu6auu JhTw== X-Gm-Message-State: AOJu0YyE/mpvLNOPbpJClth866YZuH0pqQuaXpS60qNN9N78ihVOWDee KPomN7tso5AgXSvoMidQxeVjevPMSY1TihBGRMW13wQG4q+Ph6zKuNhCn83Yhj94Jd3yuYvH2Si ux4jlN8yiHK+991JlfyoYTc3YaTZiOmzlZbuTwUBUeq8nWPgKC2tbsh20gZ5Z6sj6SX2k4e1vyk 7vSRM3JEHdD5dU1mPTo4mik0tIn4QCnMk4dEB5K3g= X-Received: by 2002:a05:620a:2954:b0:788:137b:b847 with SMTP id n20-20020a05620a295400b00788137bb847mr120878qkp.7.1709927640457; Fri, 08 Mar 2024 11:54:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFRlmv3M+I3IiVZLCSbEbCkIhxizQgdyILshAuIZnMo/JXKiznP9NOyA4lxW3KS0PShMzM7Tw== X-Received: by 2002:a05:620a:2954:b0:788:137b:b847 with SMTP id n20-20020a05620a295400b00788137bb847mr120853qkp.7.1709927639896; Fri, 08 Mar 2024 11:53:59 -0800 (PST) Received: from [192.168.1.88] (23-233-12-249.cpe.pppoe.ca. [23.233.12.249]) by smtp.gmail.com with ESMTPSA id p2-20020a05620a22e200b00787c1df4044sm59290qki.118.2024.03.08.11.53.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Mar 2024 11:53:59 -0800 (PST) Message-ID: <2a387743-5801-4e06-810e-d05dd7783169@redhat.com> Date: Fri, 8 Mar 2024 14:53:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: "gcc-patches@gcc.gnu.org" From: Vladimir Makarov Subject: [pushed][PR113790][LRA]: Fixing LRA ICE on riscv64 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, HTML_MESSAGE, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113790 The patch was successfully bootstrapped and tested on x86-64,ppc64le, and aarch64. commit cebbaa2a84586a7345837f74a53b7a0263bf29ee Author: Vladimir N. Makarov Date: Fri Mar 8 14:48:33 2024 -0500 [PR113790][LRA]: Fixing LRA ICE on riscv64 LRA failed to consider all insn alternatives when non-reload pseudo did not get a hard register. This resulted in failure to generate code by LRA. The patch fixes this problem. gcc/ChangeLog: PR target/113790 * lra-assigns.cc (assign_by_spills): Set up all_spilled_pseudos for non-reload pseudo too. diff --git a/gcc/lra-assigns.cc b/gcc/lra-assigns.cc index d1b2b35ffc9..7dfa6f70941 100644 --- a/gcc/lra-assigns.cc +++ b/gcc/lra-assigns.cc @@ -1430,13 +1430,19 @@ assign_by_spills (void) hard_regno = spill_for (regno, &all_spilled_pseudos, iter == 1); if (hard_regno < 0) { - if (reload_p) { - /* Put unassigned reload pseudo first in the - array. */ - regno2 = sorted_pseudos[nfails]; - sorted_pseudos[nfails++] = regno; - sorted_pseudos[i] = regno2; - } + if (reload_p) + { + /* Put unassigned reload pseudo first in the array. */ + regno2 = sorted_pseudos[nfails]; + sorted_pseudos[nfails++] = regno; + sorted_pseudos[i] = regno2; + } + else + { + /* Consider all alternatives on the next constraint + subpass. */ + bitmap_set_bit (&all_spilled_pseudos, regno); + } } else {