From patchwork Fri Mar 8 17:08:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Earnshaw X-Patchwork-Id: 86985 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6C1EE385E00E for ; Fri, 8 Mar 2024 17:09:41 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-he1eur04on2072.outbound.protection.outlook.com [40.107.7.72]) by sourceware.org (Postfix) with ESMTPS id BEF2F3858D33 for ; Fri, 8 Mar 2024 17:09:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BEF2F3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BEF2F3858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.7.72 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1709917754; cv=pass; b=OtLd3x5HldKuKZ5TpLX4DbK3gYpLd5SEUEfpPHx1PSWPvMeN7bxAVOXISmew0RHA9n8sbLno049qDZ1Px9EJfES9SENFd8fT9OUkKjC7Vs18RzSQhoC2fxpnyG7DUqnok8GJehn6kg8LkfUDZPBUnl0Q1BY3G5VxSHuURrFsP24= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1709917754; c=relaxed/simple; bh=3slVyUyq8m8oSy44J7j2vkvNI0baHn0LgoaxqF9vcfg=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=VvuyyzGCEPIQ2jCX5An3W4fBTYrlcbx3X7fjC2wBmsZAew2+4aCp3demEHPcOylS648nV6b454SvZl4Ec4ztnTqOK1hrvOtBsdCjsIW7/ZURWmSzPPvgOYvzLVyAkRDeW7pcKBj9a+wK22W7MTOFzkj1R50qYsYYi/NcBEeCAOU= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GQfvPHKZFxkCBEgshidvFA5zpnT37v+ZKjdd+5Bx9wMbTPqN72MZ9jT9KfJ6mRD2fO43AepzKELxKrvbK1VRAV2XPytbLvAl/yzMQ2hAH8UQr3kHttqKBnzE6vl4p6xIOSdS9pGtWMdBXlFKwXepMy5fllIuibp31Vz609gQAweKrnIhDmMmg9dxWaXo/anLzjMRyUS/vKlGDlLO3F+c+RNFkVD/M7lnNpfNK4USC1WBeVpXJVAaGZp4b0M+oYr13+BXKFenBuU5Pwqty81867SKs5VoD2Px8s35jTm4qNy+1drz1Sfnyv98s0l411WILMXK0YVWF2Wi4AfiDHgvsw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1GqQz9ZIXx1IKRw77Nkq24P9pZZDIzJ5mImjsc0yCBA=; b=og7ibvCVVX3Js049VxAkTPCn0lQhUGqDSeb9HvzxCrMa3+dJhxpvUYipeyl+cBnElO/IQcnccK1mMT+s+O6WWbk4S+92sNpq3oHo+guQgD84jaeKHys2TiId8kDkZWsD4ew6+GlLOK5Loej0qcceb73DYRzoEmSpD5GYKTeAnytwwmv9rMQQaeRfEzdZ/vXO0pSuxbF2huEI7Js31om9TeNpUV3iYQ6p69bbsOCqPcbNfmic+CZ9+qg3dymnZV5e++fXX4vi2qR9EDYVTxXnjXnbuHz85ObH5dVQn0cvFpR1UsABsB7mPQDr+xqfFEnJRcQH9SxTYOGBnuKljgVN4g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1GqQz9ZIXx1IKRw77Nkq24P9pZZDIzJ5mImjsc0yCBA=; b=wy4QEpN37tbQtBgrVK7dFj2XCF6KnhBFwbNtxiKkuqurUs2L8byw9zNd7K379jJgFGBAIT0JTDg+4AOrHBEdRSr5DzSQNDdTD50Ptt2bs8lHBOXRfDKOxT3Yr+RRj03BaIXAVjrr/+X2QELe38bYik4i++6E8ESJ9WtbzwJnJTw= Received: from DB8PR09CA0030.eurprd09.prod.outlook.com (2603:10a6:10:a0::43) by VE1PR08MB5840.eurprd08.prod.outlook.com (2603:10a6:800:1b2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.27; Fri, 8 Mar 2024 17:09:01 +0000 Received: from DU2PEPF00028D0E.eurprd03.prod.outlook.com (2603:10a6:10:a0:cafe::99) by DB8PR09CA0030.outlook.office365.com (2603:10a6:10:a0::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.28 via Frontend Transport; Fri, 8 Mar 2024 17:09:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU2PEPF00028D0E.mail.protection.outlook.com (10.167.242.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Fri, 8 Mar 2024 17:09:01 +0000 Received: ("Tessian outbound 598157ceef91:v276"); Fri, 08 Mar 2024 17:09:01 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 77802f7e14461453 X-CR-MTA-TID: 64aa7808 Received: from ae20e2e65503.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EF889907-CB0F-4F6B-8591-256E805CFC08.1; Fri, 08 Mar 2024 17:08:54 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ae20e2e65503.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Mar 2024 17:08:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i1cURD3aBClpSk4N55FAafL6cWKwuPsFR+vGPRNGO8FQRZ3DDxwQYAby4gc/I+ceUJo4jtPm1iQUAzEtkubiLpDqNr4tbLBbOUchq+ZjDKPHMoqp5XTR1TyQdEyKsRV326vuWrUxyjL2xRF+9ZzWPcIQlm6P0CQ1W3CXPKAJCPGfgKy05ut1Zlt7zQ9heaXbS3undUMLhf3B0RqDzx/OxUqyZnQh5TGZeT0EPUXyTlpKymnh4jnSJqKzkI+UM0oJQlMsmQbWSS6skx/jSGxH+4/zrrI84BXe5XGLIkPyXBSzEV/TKp9who62DkNohbMAV5SXhaW48guImLW3cZikkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1GqQz9ZIXx1IKRw77Nkq24P9pZZDIzJ5mImjsc0yCBA=; b=noiM8m4Aj5qbgffL56i/UPoXiLB9Xk7PxK1FBZMuEyHlzS6xFdUCWDAJn6iiM0ATYIzYsTPG5NF5AmG0jf8ibXllct4/UcjzNZfpY8s2bK4enejnOFHMdfh6Krk6vy50Vsk1Ci0CVNAaiIARdJ9L+BiFlEq9zjk44zFsm2Sb54rBcdvn0iqqg2gbpt5MCd3phbbKV/sDFwPdxRbe0Wpn0PjgFzvpbnm7J5qvKlDxr+7LdTlbSxLYs9D1KNa1j/dfCRgH2r7CV/onmnSzga4AyjLPJ9BGZjPCJbPbXcYlgLw3ESlNFfDtgsheozKVw/uxXLewiEgE1f4B4p4OhVwrSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1GqQz9ZIXx1IKRw77Nkq24P9pZZDIzJ5mImjsc0yCBA=; b=wy4QEpN37tbQtBgrVK7dFj2XCF6KnhBFwbNtxiKkuqurUs2L8byw9zNd7K379jJgFGBAIT0JTDg+4AOrHBEdRSr5DzSQNDdTD50Ptt2bs8lHBOXRfDKOxT3Yr+RRj03BaIXAVjrr/+X2QELe38bYik4i++6E8ESJ9WtbzwJnJTw= Received: from DUZPR01CA0270.eurprd01.prod.exchangelabs.com (2603:10a6:10:4b9::22) by GVXPR08MB10665.eurprd08.prod.outlook.com (2603:10a6:150:14c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.26; Fri, 8 Mar 2024 17:08:50 +0000 Received: from DU2PEPF0001E9C5.eurprd03.prod.outlook.com (2603:10a6:10:4b9:cafe::1c) by DUZPR01CA0270.outlook.office365.com (2603:10a6:10:4b9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.27 via Frontend Transport; Fri, 8 Mar 2024 17:08:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by DU2PEPF0001E9C5.mail.protection.outlook.com (10.167.8.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7386.12 via Frontend Transport; Fri, 8 Mar 2024 17:08:49 +0000 Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 8 Mar 2024 17:08:49 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 8 Mar 2024 17:08:48 +0000 Received: from e120077-lin.cambridge.arm.com (10.2.78.54) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Fri, 8 Mar 2024 17:08:48 +0000 From: Richard Earnshaw To: CC: Richard Earnshaw , Subject: [COMMITTED] arm: testsuite: tweak bics_3.c [PR113542] Date: Fri, 8 Mar 2024 17:08:38 +0000 Message-ID: <20240308170838.2680359-1-rearnsha@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: DU2PEPF0001E9C5:EE_|GVXPR08MB10665:EE_|DU2PEPF00028D0E:EE_|VE1PR08MB5840:EE_ X-MS-Office365-Filtering-Correlation-Id: abaaec32-3ced-4ba4-e94c-08dc3f92736a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gPdPJhGd011YWDbMNQ2Av+hVkAS7pKLYvsLDHNRLymaJQ4gxrOumez2hJGCnGosGYHICh7RiL0fqs/X8GhXz1Mc/a4A6c7jcXHpSfqooHHWroxT0YmTOM/Xi4q2nG0uYDY4jUsoK0TLuoXtSfBGEWqTpBg81kGd/ZGRqp8C4d31uFOpzdPbT7KvhJKU8uYimqxYOT2UeIYTR/HvpEgm3WTZvPHZpg11606LK9r5UW08UJDb+f/W7vx6ShfVfmelirtA62YlOTOg4pQapRPksXmFqoPNcMxco/gG+WP654mNE43YjskggjOlTYRlCrML6eyL7sC8wRLZ9DDF0W/c/wiiCViJHatRRu0h4mZk+74pprSMZ2c+cMWVm6bmRBS6SYSpQRuAe+atzQeUWdK+RXnZpiQVQMsvNh2sepWetrEKD8NDv2lVKb/LZjiFxdIn5Msa+j/sg7Tz5cDLjEewhhO4ix+ifvhkgqbodjIb3j7dosyKW9UIEDTI3WRXntnqy/PcpcNyLTYfnBnq1mJ5Gul0dO1yaootHy8+zsbh24UluOsmvcdQ3ZfQypLDlMtFE328hUArbklph8Mav5VjkwONEA64cJLJd0lFKXD5IcZlzG3QN1NMz8TQXbpp64LPLCnc6KIeQeR2PTv5lhewhWzmcXGWmAo0ZYUnLcI37ijlhk/PX6caw5kIqFvBJ8frX X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:nebula.arm.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400014); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB10665 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D0E.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3f69f70f-19c2-4b48-3b0c-08dc3f926c72 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S01LVrOX1c3EFjkoQzQcxYe++AV2JXNWycRlBcBdCz3M2b6+kPSWX/oAX3bfL9vGsTarZrIwlo5QSv62HNjvdDj5kJMO98ElzypbvA3J/kXqKdVs11wLss9rtSRefqVeKLGHh8WxHG23nQUr/LO0BU2LvASTCX1THjBj7PF9g/bEL3dV4Y0dGbM8wgu9JiIm/8d/iHH84SjorE4vUlMDYLqYfEj/KOwLdWRI/MECld3o5tpNrKCNUeOQHmHuFMMX1Zfz1C2jOWpa8P2r+5xru8TsT/h2cKN9ALozNFS2mkgJHFEpqnPqMQ9Ql+M9x8HlTlp+xQjnMSI2vlxeo3zuM2C6OBqO7xCoAdpdS6BekACiZQ8fDu3E+AwtNqT1224ZNYcVYbqO8mETt00IUEBbUwzqRFBcZaegMPaGJz5U6lQuwGYF1Rhq93aJFGanJidmMn7icU4ozXvdNS7kLT8rvoKCSvVCeXB5NuFz8IV846aworLGSyjUibOP5tPw9ceeb3/LKyP/jHg1QJhDrs90TLp/k282RehoC2Tf7NezCb1TUiIgXz4V1AyroRrqnAoDKzIqjwuMXSssJ6d6vUw7fFOLqeyOcemAz+Z0KH0ZWbyMQOtwn3EC0uAgUXoUryHkAQPE+xlisEj0Es4Ijm0lPq+YFUEJjT3BpZO6MJNEhS00ZpF/VQGrAT1uWbx+qnZK X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(1800799015)(82310400014)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 17:09:01.3929 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abaaec32-3ced-4ba4-e94c-08dc3f92736a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D0E.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5840 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org This test was too simple, which meant that the compiler was sometimes able to find a better optimization of the code than using a BICS instruction. Fix this by changing the test slightly to produce a sequence where BICS should always be the preferred solution. gcc/testsuite: PR target/113542 * gcc.target/arm/bics_3.c: Adjust code to something which should always result in BICS. --- gcc/testsuite/gcc.target/arm/bics_3.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/gcc/testsuite/gcc.target/arm/bics_3.c b/gcc/testsuite/gcc.target/arm/bics_3.c index e056b264e15..4d6938948a1 100644 --- a/gcc/testsuite/gcc.target/arm/bics_3.c +++ b/gcc/testsuite/gcc.target/arm/bics_3.c @@ -2,13 +2,11 @@ /* { dg-options "-O2 --save-temps -fno-inline" } */ /* { dg-require-effective-target arm32 } */ -extern void abort (void); - int bics_si_test (int a, int b) { - if (a & ~b) - return 1; + if ((a & ~b) >= 0) + return 3; else return 0; } @@ -16,8 +14,8 @@ bics_si_test (int a, int b) int bics_si_test2 (int a, int b) { - if (a & ~ (b << 2)) - return 1; + if ((a & ~ (b << 2)) >= 0) + return 3; else return 0; } @@ -28,13 +26,12 @@ main (void) int a = 5; int b = 5; int c = 20; - if (bics_si_test (a, b)) - abort (); - if (bics_si_test2 (c, b)) - abort (); + if (bics_si_test (a, b) != 3) + __builtin_abort (); + if (bics_si_test2 (c, b) != 3) + __builtin_abort (); return 0; } /* { dg-final { scan-assembler-times "bics\tr\[0-9\]+, r\[0-9\]+, r\[0-9\]+" 2 } } */ /* { dg-final { scan-assembler-times "bics\tr\[0-9\]+, r\[0-9\]+, r\[0-9\]+, .sl #2" 1 } } */ -