From patchwork Fri Mar 8 11:33:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rene Rebe X-Patchwork-Id: 86968 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7AD3C385DC0C for ; Fri, 8 Mar 2024 11:33:57 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx.exactcode.de (mx.exactcode.de [144.76.154.42]) by sourceware.org (Postfix) with ESMTPS id 40DD03858D38; Fri, 8 Mar 2024 11:33:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40DD03858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=exactcode.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=exactcode.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 40DD03858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=144.76.154.42 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709897611; cv=none; b=Vk61PGB21rQYwb15g64MqCp6mZZHb3aCz09PVojLMGtX5iqarCtbzpy861OpoLGW3e7PaEtgyZu+QhLH80/ekPViwvbYkWl7h+yfkHi9Sn8e5VtvLBIjIEhBdj4xZefo0uLFFykcFBbpfacyt5zMGm0K51a8JE2o/z1A631rCLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709897611; c=relaxed/simple; bh=74KHyZZtZkW1gritZb9+lV3mKnM/WlmJVJ1kQRUznHg=; h=DKIM-Signature:Date:Message-Id:To:Subject:From:Mime-Version; b=K0ew9oK0+S3fHw/0/QJ5G2ga1Zv4IHB8v62Ul1YBIeO7It8mTlxULbUtzQoQaD9Bjvp5pqO7SA/O6/1AhTUztrSvWv+/+7TolsjyXA7S+apto7Qdkzd3DYhAc/pMnncrFeufAe/Lg/5HAxzXGNyocYNgEBLt+lwiXtKwp/ACO+M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=exactco.de; s=x; h=Content-Transfer-Encoding:Content-Type:Mime-Version:From:Subject:Cc:To:Message-Id:Date; bh=6Gp/721MkiiBrCgmuvPUks7fBzkU5c0nDKf09OAdHTI=; b=FOe/T87GLVN2ZV35pJgFWASbhggsne51j3e/+sYSnYdfEAT/Bp/BF9aDXGVu3vB7Z2DUIq/X3gRn9ETIL8V/z7E6Zz5EV9cO/cHEnq3Sqka3pPn5/0x6MIVxVQ0mkqEnabGCXZ/YyJsLUelLKIKVfm2Nl/5APatvei+kVW5VMNQ=; Received: from exactco.de ([90.187.5.221]) by mx.exactcode.de with esmtp (Exim 4.82) (envelope-from ) id 1riYUL-0003CT-4B; Fri, 08 Mar 2024 11:34:09 +0000 Received: from [192.168.2.103] (helo=localhost) by exactco.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1riYTi-0003cd-Iu; Fri, 08 Mar 2024 11:33:31 +0000 Date: Fri, 08 Mar 2024 12:33:42 +0100 (CET) Message-Id: <20240308.123342.1112119677226246836.rene@exactcode.de> To: gcc-patches@gcc.gnu.org Cc: sjames@gcc.gnu.org Subject: [PATCH] fix PowerPC < 7 w/ Altivec not to default to power7 From: Rene Rebe X-Mailer: Mew version 6.9 on Emacs 29.2 Mime-Version: 1.0 X-Spam-Score: -3.1 (---) X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, KAM_NUMSUBJECT, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org This might not be the best timing -short before a major release-, however, Sam just commented on the bug I filled years ago [1], so here we go: Glibc uses .machine to determine assembler optimizations to use. However, since reworking the rs6000 .machine output selection in commit e154242724b084380e3221df7c08fcdbd8460674 22 May 2019, G5 as well as Cell, and even power4 w/ -maltivec currently resulted in power7. Mask _ALTIVEC away as the .machine selection already did for GFX and GPOPT. powerpc64-t2-linux-gnu-gcc test.c -S -o - -mcpu=G5 .file "test.c" .machine power7 .abiversion 2 .section ".text" .ident "GCC: (GNU) 10.2.0" .section .note.GNU-stack,"",@progbits We ship this in T2/Linux [2] since 2020 and it is tested on G5, Cell and Power8. Signed-of-by: René Rebe [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97367 [2] https://t2sde.org --- gcc-11.1.0-RC-20210423/gcc/config/rs6000/rs6000.cc.vanilla 2021-04-25 22:57:16.964223106 +0200 +++ gcc-11.1.0-RC-20210423/gcc/config/rs6000/rs6000.cc 2021-04-25 22:57:27.193223841 +0200 @@ -5765,7 +5765,7 @@ HOST_WIDE_INT flags = rs6000_isa_flags; /* Disable the flags that should never influence the .machine selection. */ - flags &= ~(OPTION_MASK_PPC_GFXOPT | OPTION_MASK_PPC_GPOPT | OPTION_MASK_ISEL); + flags &= ~(OPTION_MASK_PPC_GFXOPT | OPTION_MASK_PPC_GPOPT | OPTION_MASK_ALTIVEC | OPTION_MASK_ISEL); if ((flags & (ISA_3_1_MASKS_SERVER & ~ISA_3_0_MASKS_SERVER)) != 0) return "power10";