From patchwork Mon Feb 26 20:32:38 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jeevitha X-Patchwork-Id: 86400 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED43F3858403 for ; Mon, 26 Feb 2024 20:35:39 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 3FD473858C98 for ; Mon, 26 Feb 2024 20:35:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FD473858C98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=linux.vnet.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3FD473858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708979713; cv=none; b=imB6BO+SI9HX21ouDCU9z1qaaoe+CIyu0m5lDrfcvoZljiTs/XKR2YzSVaTp4iu+EGMz2G67q5rysUZSFsjk8gQeVY3RYmvdhHrHvGjoj5LSZnQZJNNossOz29xXGmmlTXOQ5fQjiRWIaCoDFQJEqij1/X+TfmHAsW6VktjfZH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708979713; c=relaxed/simple; bh=AQnHIz8GMb3ItcvWKu/Dvt8Q3TO4/qJ3A2HyPj010zU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=U8XMvpJ5o1nx7GzH3M3Qur39Mwk2vbsV7lBFEMmuMu5w9IUKbhpc5yv+iEwD4HdMWleIVjU60ZyDPSSykg6XPfP499NvFqr0jwQP+cqx0/kJxPVUA5IOGykUWAouzU7WYzDacBGp6ejVQnX3ruNNk4wqxwKoJVbKvAfeRDKUZpo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41QKS1c3018749; Mon, 26 Feb 2024 20:35:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : references : from : to : cc : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=zEOZ9vGY02rvqMeJi4uZYWydrosfO5Jfphzb8D8Lt+E=; b=axt90QtWw7MjqGCQy5jopFAFhv3aYYAKKYFipVxZDU9oxMoPee4CiGLZ+PEtUTLo2t8x RcriwOIzxL/Hry20rhMlSXr5D462zEKL1cvV/QBsdVTHFlJ0mEYAZ95E57xRM6vALf4g AAK6ScWTFBWiIMDh4McfKo05NEBB4Its6mCB9DHMuMXhyt0QvO1FCjsCQjGYj20zhoyM xgXPRUoGJp7m7lDH13mMIgLjcokTdFNI481ENaNXgPZrrYn82cxZfUyOf6+yAUspjpsZ 1Ktwql9+eKF7HL87zZ5WM2al8OvTTbQ8Ei+5a1BIBcOkR5iGdGYXD5LNN6j0K9HYlZ5+ /g== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wh1q0r3p6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Feb 2024 20:35:09 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 41QIpDwu008792; Mon, 26 Feb 2024 20:32:48 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3wftstbud3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Feb 2024 20:32:48 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 41QKWi5X7930550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Feb 2024 20:32:46 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D338B58072; Mon, 26 Feb 2024 20:32:42 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 96DAA5806A; Mon, 26 Feb 2024 20:32:40 +0000 (GMT) Received: from [9.195.32.75] (unknown [9.195.32.75]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 26 Feb 2024 20:32:40 +0000 (GMT) Message-ID: <17e8b572-e9c1-44f6-aff8-b14cda8321f9@linux.vnet.ibm.com> Date: Tue, 27 Feb 2024 02:02:38 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH V2] rs6000: Don't allow immediate value in the vsx_splat pattern [PR113950] Content-Language: en-US References: <7faaa8f2-d706-4f6a-811f-103b74f2de8a@linux.vnet.ibm.com> From: jeevitha To: GCC Patches , "Kewen.Lin" , Segher Boessenkool , Michael Meissner Cc: Peter Bergner In-Reply-To: <7faaa8f2-d706-4f6a-811f-103b74f2de8a@linux.vnet.ibm.com> X-Forwarded-Message-Id: <7faaa8f2-d706-4f6a-811f-103b74f2de8a@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: jSruJA_5BK9cMTeTHjdWw41Cx_eZ7EsQ X-Proofpoint-GUID: jSruJA_5BK9cMTeTHjdWw41Cx_eZ7EsQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-26_11,2024-02-26_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 mlxlogscore=912 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0 spamscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402260158 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Hi All, The following patch has been bootstrapped and regtested on powerpc64le-linux. There is no immediate value splatting instruction in Power. Currently, those values need to be stored in a register or memory. To address this issue, I have updated the predicate for the second operand in vsx_splat to splat_input_operand and corrected the assignment of op1 to operands[1]. These changes ensure that operand1 is stored in a register. 2024-02-26 Jeevitha Palanisamy gcc/ PR target/113950 * config/rs6000/vsx.md (vsx_splat_): Updated the predicates for second operand and corrected the assignment. gcc/testsuite/ PR target/113950 * gcc.target/powerpc/pr113950.c: New testcase. diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md index 6111cc90eb7..3e2df247630 100644 --- a/gcc/config/rs6000/vsx.md +++ b/gcc/config/rs6000/vsx.md @@ -4660,14 +4660,14 @@ (define_expand "vsx_splat_" [(set (match_operand:VSX_D 0 "vsx_register_operand") (vec_duplicate:VSX_D - (match_operand: 1 "input_operand")))] + (match_operand: 1 "splat_input_operand")))] "VECTOR_MEM_VSX_P (mode)" { rtx op1 = operands[1]; if (MEM_P (op1)) operands[1] = rs6000_force_indexed_or_indirect_mem (op1); else if (!REG_P (op1)) - op1 = force_reg (mode, op1); + operands[1] = force_reg (mode, op1); }) (define_insn "vsx_splat__reg" diff --git a/gcc/testsuite/gcc.target/powerpc/pr113950.c b/gcc/testsuite/gcc.target/powerpc/pr113950.c new file mode 100644 index 00000000000..5c6865a8544 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr113950.c @@ -0,0 +1,25 @@ +/* PR target/113950 */ +/* { dg-do compile } */ +/* { dg-require-effective-target powerpc_vsx_ok } */ +/* { dg-options "-O1 -mdejagnu-cpu=power7" } */ + +/* Verify we do not ICE on the following. */ + +void abort (void); + +int main () +{ + int i; + vector signed long long vsll_result, vsll_expected_result; + signed long long sll_arg1; + + sll_arg1 = 300; + vsll_expected_result = (vector signed long long) {300, 300}; + vsll_result = __builtin_vsx_splat_2di (sll_arg1); + + for (i = 0; i < 2; i++) + if (vsll_result[i] != vsll_expected_result[i]) + abort(); + + return 0; +}