From patchwork Mon Feb 26 09:54:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rainer Orth X-Patchwork-Id: 86368 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E14D43858408 for ; Mon, 26 Feb 2024 09:54:37 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp.CeBiTec.Uni-Bielefeld.DE (smtp.CeBiTec.Uni-Bielefeld.DE [129.70.160.84]) by sourceware.org (Postfix) with ESMTPS id 441D73858C55 for ; Mon, 26 Feb 2024 09:54:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 441D73858C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=CeBiTec.Uni-Bielefeld.DE Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=cebitec.uni-bielefeld.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 441D73858C55 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=129.70.160.84 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708941246; cv=none; b=fGVl2tdpXfQolorkpud1TOBrTC9wFXLIdTNBulS+WSsfqosRIpvvvOuLEwboOwh4hzAK+DxmZB1vv6L/7ugzPUG2H3Q4SGauDuJZXtB1FttHwc0+FK19PYmhdTfhrVtmZqczeuHkwiTsDzPgfvqXLhdqjQQ4mD1AwxEo7BnXKG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708941246; c=relaxed/simple; bh=TGZkjynhTzptRV5HZmgBXPswN+6vbVPEYuQnBh4aRSE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Evml33+znbF2IrEJYVdMGNZU0BUDZBccsAYuxptJIQmtE+XQM2uqTxP3p6CwPKPF1e0ulClHvbCp7+f2IQ/wpa2443qukFUBqL9ZS5GXEdX0YzD7gfTpwJZ6Xbuetf4bqVZ/Is6IsxkP+PM/EYqElnV1Ok4xlm8PsdCXrjlFiRk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from localhost (localhost [127.0.0.1]) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 2F4E9BF09E for ; Mon, 26 Feb 2024 10:54:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= cebitec.uni-bielefeld.de; h=content-type:content-type :mime-version:user-agent:message-id:date:date:subject:subject :from:from:received:received; s=20200306; t=1708941242; bh=TGZkj ynhTzptRV5HZmgBXPswN+6vbVPEYuQnBh4aRSE=; b=O9fZxnH4neoGsyAyobjum JJl/6GKiL2tJ1jv2RdWr4AA0/AuzZiCQR56VQ/fkd4wCavaim/NlyYhYm50mpDIt isMpjT8RScKMIPfpmWSFbQVcp5jzqOzGDzLF5OlWxBF7BXZyKMGvJVa59UIn3fn1 0NsFLy+tDlzbPh0syjKALmlKtBl7Mdn/onIMxc5Wi16yfgoahRUXB+/3GfLG0lw+ 9mtgXVG2ECqcvauhE5QeAJlEYhtkUvBnRLn8lva5PbCHZWu7hvSf0y7GLFIgV5S7 TwEwMCfyoHGO/j2eWe62/ZpD7UuHRdQXmGuaW+H85YhD5N0qV1JMUXhbET6nvfZO A== X-Virus-Scanned: amavisd-new at cebitec.uni-bielefeld.de Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1]) by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ESNzLj2m6mnx for ; Mon, 26 Feb 2024 10:54:02 +0100 (CET) Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50855b30.dip0.t-ipconnect.de [80.133.91.48]) (Authenticated sender: ro) by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id C255DBEE2C for ; Mon, 26 Feb 2024 10:54:02 +0100 (CET) From: Rainer Orth To: gcc-patches@gcc.gnu.org Subject: [COMMITTED] testsuite: Fix gcc.dg/attr-weakref-1.c on Solaris/x86 with as [PR70582] Date: Mon, 26 Feb 2024 10:54:02 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v) MIME-Version: 1.0 X-Spam-Status: No, score=-3789.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org gcc.dg/attr-weakref-1.c FAILs on 32 and 64-bit Solaris/x86 with the native assembler: FAIL: gcc.dg/attr-weakref-1.c (test for excess errors) UNRESOLVED: gcc.dg/attr-weakref-1.c compilation failed to produce executable Excess errors: Assembler: attr-weakref-1.c "/var/tmp//ccUSaysF.s", line 171 : Multiply defined symbol: "Wv3a" This is a bug in the native as, which isn't seeing fixes recently. Since only a single subtest is affected, this patch omits that one. Tested on i386-pc-solaris2.11 (as and gas) and x86_64-pc-linux-gnu. Committed to trunk. Rainer # HG changeset patch # Parent c2e97b9d632bb04de7c4c87d39b7e813f640f9f9 testsuite: Fix gcc.dg/attr-weakref-1.c on Solaris/x86 with as [PR70582] diff --git a/gcc/testsuite/gcc.dg/attr-weakref-1.c b/gcc/testsuite/gcc.dg/attr-weakref-1.c --- a/gcc/testsuite/gcc.dg/attr-weakref-1.c +++ b/gcc/testsuite/gcc.dg/attr-weakref-1.c @@ -14,6 +14,8 @@ // { dg-options "-O2" } // { dg-additional-options "-Wl,-undefined,dynamic_lookup" { target *-*-darwin* } } // { dg-additional-options "-Wl,-flat_namespace" { target *-*-darwin[89]* } } +// One subtest doesn't assemble with the Solaris/x86 as (PR ipa/70582) +// { dg-additional-options "-DSOLARIS_X86_AS" { target { *86*-*-solaris2* && { ! gas } } } } // { dg-additional-sources "attr-weakref-1a.c" } // Copyright 2005 Free Software Foundation, Inc. @@ -46,9 +48,11 @@ vtype gv2; static vtype Wv2a __attribute__((weakref ("gv2"))); static vtype *pv2a USED = &Wv2a; +#if !defined SOLARIS_X86_AS static vtype lv3; static vtype Wv3a __attribute__((weakref ("lv3"))); static vtype *pv3a USED = &Wv3a; +#endif extern vtype uv4; static vtype Wv4a __attribute__((weakref ("uv4"))); @@ -192,7 +196,9 @@ extern ftype wf14 __attribute__((weak)); int main () { chk (!pv1a); chk (pv2a); +#if !defined(SOLARIS_X86_AS) chk (pv3a); +#endif chk (pv4a); chk (pv4); chk (pv5a);