From patchwork Fri Feb 23 11:28:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 86271 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B3D323858010 for ; Fri, 23 Feb 2024 11:28:51 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 441123858022 for ; Fri, 23 Feb 2024 11:28:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 441123858022 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 441123858022 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687696; cv=none; b=XufaAyec+W7zy++1ITfGXDywNCvsak1JgkSfIQkmJyl91P/XmsgMRhuJ04PYD3CRbEKdjLVzqoxMP1v3GNfJrLY+8/esL8pwskw6jKCjG1752Q6K5/zASIjT9CDUd/57M1K8EM2RAd0zHGqHUxkrzfz7Qn5tQ2DcFUWfbdTdRRw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687696; c=relaxed/simple; bh=E4PJzgdbSJk12jkDnVlvUciAPx6q5y/It4PwtfqjzIs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=wp4EAHlDVQoiYbL+jVuqUahCCyM7XcKxbh8OVPVYQkaUlJxvcsrZ6jhDBHnCnMHkTP569qCp2cRdC8sab1pvN4IXPNODEs+b8o1PLEeAJovGncANdtAztp0/3kKh6wYfB7RK4029SF4H+wI8w9veW14frX4dPh7L21VVT0ewxPM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a3d5e77cfbeso135434166b.0 for ; Fri, 23 Feb 2024 03:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1708687691; x=1709292491; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=9qWVrkwR42RrUquJ8uGW0LD3UispxApm9l51m19fZXc=; b=R39hbCTcd2VwYGLq9lDOrzEofIfubizZoxelxqCIv0JGFHRSV3KrMasa44sxexm0e+ imL2jV5pa3Vj03QxW3CrDH/u3NfWsWysiC8aRBVK65v3A5Da7937ysqVjmCRLKM9wKBn 1btGlOJ2EESpso3kystruM+z2dbQdFv3oBMReXVoLaq51wT3k0L5lUs1+li/AEkRXWVp C5sk4G2nr5tR/uVMsk02n/EwYXEdRIcyggskRc0kbS4M6N2bYj9rkXyR/a+aNlWr00Vc kJuSF1KV/5VDiKqvrVnyavtiYiJ9Buhqbm3uMwpNol3Qf9PXS7i3MdHf6K7DSlArxEpA VFgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708687691; x=1709292491; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9qWVrkwR42RrUquJ8uGW0LD3UispxApm9l51m19fZXc=; b=qoKaI+2hpVki4xDoURLMB/tZT0lU8VQywfGSAIC9/oVYngJxb74dM+BaGw2gjHgN// SvD1JgdKmkg5c2aCymjOLMx4U674dGvItthsXjPKekHyRInshh8GWy3/mh6sivqIkiI0 s0mR5NnLZB6/heE3pX7ZRHrupBaE+BYWgehgRY3fTIvUMjap018JJa8WJ0ORLW/1YduE 40Ih3F35UVLo68Iho0znLOwiO3nopzJQyDIGXBJIBntQ2kQDMeeN7UeG9cO3eb2fwBJa 61ldU3zugpJRcTRGtfsdtYPQJzvIUvoVvTyMEbvuKhZKVijFQiefd0M6RHo8uqvIxlB5 0eTw== X-Gm-Message-State: AOJu0YzmHqHzaBG8msEE6UrgcWetdMYPBRuPvdl9SGtcVaoX4phzefwH ArKhMCp6GLXiTxHgzsO0tYelN5aaTda2KsbSUkyVwAeX91bwo/kTIMDEpD+4BzMYIwsSYLxKV9s = X-Google-Smtp-Source: AGHT+IH5QOXY7JxGwJ5XH+aSmVVqVWh3chfDZprv8rGC80C0GzYPfOwiguzK5tiB33pmL3pBwy6Iiw== X-Received: by 2002:a17:907:76ac:b0:a3c:2f68:54a9 with SMTP id jw12-20020a17090776ac00b00a3c2f6854a9mr1365100ejc.3.1708687690990; Fri, 23 Feb 2024 03:28:10 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id lu16-20020a170906fad000b00a3d5efc65e0sm5486296ejb.91.2024.02.23.03.28.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 03:28:10 -0800 (PST) Message-ID: <2b3f3784-481d-4b8c-861f-7c9ac062683b@suse.com> Date: Fri, 23 Feb 2024 12:28:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 1/6] Arm64: correct B16B16 indexed bf{mla,mls,mul} From: Jan Beulich To: Binutils Cc: Richard Earnshaw , Marcus Shawcroft References: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> Content-Language: en-US Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Their index is in bits 19, 20, and 22. Bit 11 in particular is already set in the base opcode. Note also how disassembler output didn't match assembler input in the respective testcase. --- a/gas/testsuite/gas/aarch64/bfloat16-1.d +++ b/gas/testsuite/gas/aarch64/bfloat16-1.d @@ -56,24 +56,24 @@ .*: 65221084 bfmla z4.h, p4\/m, z4.h, z2.h .*: 65211908 bfmla z8.h, p6\/m, z8.h, z1.h .*: 65201e10 bfmla z16.h, p7\/m, z16.h, z0.h -.*: 643e0a00 bfmla z0.h, z16.h, z6.h\[7\] -.*: 643d0901 bfmla z1.h, z8.h, z5.h\[7\] -.*: 643409c2 bfmla z2.h, z14.h, z4.h\[5\] -.*: 642a0aa4 bfmla z4.h, z21.h, z2.h\[3\] -.*: 64210988 bfmla z8.h, z12.h, z1.h\[1\] -.*: 64200950 bfmla z16.h, z10.h, z0.h\[1\] +.*: 647e0a00 bfmla z0.h, z16.h, z6.h\[7\] +.*: 64750901 bfmla z1.h, z8.h, z5.h\[6\] +.*: 646409c2 bfmla z2.h, z14.h, z4.h\[4\] +.*: 64320aa4 bfmla z4.h, z21.h, z2.h\[2\] +.*: 64290988 bfmla z8.h, z12.h, z1.h\[1\] +.*: 64200950 bfmla z16.h, z10.h, z0.h\[0\] .*: 65302000 bfmls z0.h, p0\/m, z0.h, z16.h .*: 65282421 bfmls z1.h, p1\/m, z1.h, z8.h .*: 65242842 bfmls z2.h, p2\/m, z2.h, z4.h .*: 65223084 bfmls z4.h, p4\/m, z4.h, z2.h .*: 65213908 bfmls z8.h, p6\/m, z8.h, z1.h .*: 65203e10 bfmls z16.h, p7\/m, z16.h, z0.h -.*: 643e0e00 bfmls z0.h, z16.h, z6.h\[7\] -.*: 643d0d01 bfmls z1.h, z8.h, z5.h\[7\] -.*: 64340dc2 bfmls z2.h, z14.h, z4.h\[5\] -.*: 642a0ea4 bfmls z4.h, z21.h, z2.h\[3\] -.*: 64210d88 bfmls z8.h, z12.h, z1.h\[1\] -.*: 64200d50 bfmls z16.h, z10.h, z0.h\[1\] +.*: 647e0e00 bfmls z0.h, z16.h, z6.h\[7\] +.*: 64750d01 bfmls z1.h, z8.h, z5.h\[6\] +.*: 64640dc2 bfmls z2.h, z14.h, z4.h\[4\] +.*: 64320ea4 bfmls z4.h, z21.h, z2.h\[2\] +.*: 64290d88 bfmls z8.h, z12.h, z1.h\[1\] +.*: 64200d50 bfmls z16.h, z10.h, z0.h\[0\] .*: 65028200 bfmul z0.h, p0\/m, z0.h, z16.h .*: 65028501 bfmul z1.h, p1\/m, z1.h, z8.h .*: 65028882 bfmul z2.h, p2\/m, z2.h, z4.h @@ -86,12 +86,12 @@ .*: 65020a04 bfmul z4.h, z16.h, z2.h .*: 65010a88 bfmul z8.h, z20.h, z1.h .*: 65000b10 bfmul z16.h, z24.h, z0.h -.*: 643e2a00 bfmul z0.h, z16.h, z6.h\[7\] -.*: 643d2901 bfmul z1.h, z8.h, z5.h\[7\] -.*: 643429c2 bfmul z2.h, z14.h, z4.h\[5\] -.*: 642a2aa4 bfmul z4.h, z21.h, z2.h\[3\] -.*: 64212988 bfmul z8.h, z12.h, z1.h\[1\] -.*: 64202950 bfmul z16.h, z10.h, z0.h\[1\] +.*: 647e2a00 bfmul z0.h, z16.h, z6.h\[7\] +.*: 64752901 bfmul z1.h, z8.h, z5.h\[6\] +.*: 646429c2 bfmul z2.h, z14.h, z4.h\[4\] +.*: 64322aa4 bfmul z4.h, z21.h, z2.h\[2\] +.*: 64292988 bfmul z8.h, z12.h, z1.h\[1\] +.*: 64202950 bfmul z16.h, z10.h, z0.h\[0\] .*: 65018200 bfsub z0.h, p0\/m, z0.h, z16.h .*: 65018501 bfsub z1.h, p1\/m, z1.h, z8.h .*: 65018882 bfsub z2.h, p2\/m, z2.h, z4.h --- a/opcodes/aarch64-tbl.h +++ b/opcodes/aarch64-tbl.h @@ -6344,9 +6344,9 @@ const struct aarch64_opcode aarch64_opco B16B16_INSN("bfmul", 0x65000800, 0xffe0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm_16), OP_SVE_HHH, 0, 0), B16B16_INSNC("bfsub", 0x65018000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), B16B16_INSN("bfsub", 0x65000400, 0xffe0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm_16), OP_SVE_HHH, 0, 0), - B16B16_INSN("bfmla", 0x64200800, 0xffa0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_11_INDEX), OP_SVE_VVV_H, 0, 0), - B16B16_INSN("bfmls", 0x64200c00, 0xffa0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_11_INDEX), OP_SVE_VVV_H, 0, 0), - B16B16_INSN("bfmul", 0x64202800, 0xffa0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_11_INDEX), OP_SVE_VVV_H, 0, 0), + B16B16_INSN("bfmla", 0x64200800, 0xffa0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_22_INDEX), OP_SVE_VVV_H, 0, 0), + B16B16_INSN("bfmls", 0x64200c00, 0xffa0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_22_INDEX), OP_SVE_VVV_H, 0, 0), + B16B16_INSN("bfmul", 0x64202800, 0xffa0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_22_INDEX), OP_SVE_VVV_H, 0, 0), /* SME2.1 movaz instructions. */ SME2p1_INSN ("movaz", 0xc0060600, 0xffff1f83, sme2_movaz, 0, OP2 (SME_Zdnx4, SME_ZA_array_vrsb_2), OP_SVE_BB, 0, 0), From patchwork Fri Feb 23 11:28:31 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 86272 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 18B4C38582A1 for ; Fri, 23 Feb 2024 11:29:16 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id 231933858010 for ; Fri, 23 Feb 2024 11:28:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 231933858010 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 231933858010 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687719; cv=none; b=XlU+CS3q0NAtq/iXXjSx6LtTcZjwkHE/Q0IV5wkJqFX93NRk7emwyz8D7lk/qsYvssTDlO5zlBrj9WYfxktaGG1ur9zX2YEhb88N0lC2axU3yFWTHY198MB2TAn23haUUt9g0yrBfzjsQk75t4z7BZIXpA552EYtcSqYWC10QCs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687719; c=relaxed/simple; bh=+mh28xXIAZG6DlY42ZcCfA4keQW6RXPYg7V6GwSxc00=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=r/D1deD6rfuLD6/HbCuTIDWdnUBBxZkW5hAdqd2flEBdxb0DqGZ9PewwuU3ltS3wksj2BpzpKKuWzOXbrhkOOji0T+/9Q7YhXc6dg0R5UwOEQQqFtEbs5vGOWK0ihHX/jdCr/T7ZGshMCkc+uqWSRq+/3lS1f4U3HkHwP3zuf0g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-a3122b70439so41627366b.3 for ; Fri, 23 Feb 2024 03:28:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1708687713; x=1709292513; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=NTuUAUv8sMPjsSAUYPFHYrMQ858b85zqd1vMD5S1O/Y=; b=b+4hgGphRXxog4l5OzAnoWo6OzFICmU6R5ZhO3GXIpCDevvGNHeITa97i4ldlQuxJ3 DOP7w2BpVWNpbAeplVldEpYKsqZama/bi6Xq6pPtYvKQnLYmr1Dpqw9YQrcv0Tp2MTIR a+bkwGUSFbUKGWc7HIWHBKbvYrsXlYOXD8mSeK19xsR7HHT3kR8uXoiQp8jf1cGJEnlj qFtKCCxXfy7rI6+VOjXaBggHso/FdAIc1d2VNRNJCwwpKvuYnriHRDXnu/Lk9rjd5NjY VYrLoicokHrzvScuzlHN//pzxTernb+AgtR0OrBkVf2YiYKlOJcpXhYIg5uMBqI3WW1S uWtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708687713; x=1709292513; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NTuUAUv8sMPjsSAUYPFHYrMQ858b85zqd1vMD5S1O/Y=; b=sZ6pOro4DIZNXb/9w+sMNDTcyo5NIVYPIeu96p4vq+flVMj5KLTqPpesB/cJfycWK6 hJwRabNlFcxlaABt4qVaS7bsxcTQhAYpKOYR0j0oIplWONKk7/jjLxrEJoG7itHjz1rt r4tRRha2+vDd8cBJucN3CfW49BF46Is4HDiodnSWTKYaf8yxh/GiM2AAVgMwq1I4y07+ PXx/W/VTIPWDnyrL+tdcHY7iMh0UW4OGoF/zg5qIwEahPO3s5GzMz0MQHZ87Zi++w2Fy TPHkeq5mFo/fHkuZPQdPOLzJYTmoVmkAonzJedE9dykHJWcPnpPlIf4VZ3Ca0zXAOGCK 3BXA== X-Gm-Message-State: AOJu0Yyb4SiejqYcvRZ1n+fdf+9wLrsWzr9ibCqrfL72R8sxNVLrIhR7 fH8HEZSNXrMxTQ3fZAdxMjSPQ020MANgCCFOVmbOvC2HNDoGg6YhRxJiRVoBN9weqkSn2degfEg = X-Google-Smtp-Source: AGHT+IHZ5MudeiTe6Z2TOiWwDVuOXChpkpUifilwuZJY5n+bKceZqtEv3FklHjAT+HQTa5wplG9tjw== X-Received: by 2002:a17:906:3451:b0:a3f:721f:a7ac with SMTP id d17-20020a170906345100b00a3f721fa7acmr1063117ejb.45.1708687712657; Fri, 23 Feb 2024 03:28:32 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id lu16-20020a170906fad000b00a3d5efc65e0sm5486296ejb.91.2024.02.23.03.28.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 03:28:32 -0800 (PST) Message-ID: <99f3418f-c836-4ae4-a6d1-ce81168d1b9a@suse.com> Date: Fri, 23 Feb 2024 12:28:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 2/6] Arm64: check matching operands for predicated B16B16 insns Content-Language: en-US From: Jan Beulich To: Binutils Cc: Richard Earnshaw , Marcus Shawcroft References: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Except for bfml{a,s} their 1st and 3rd operands need to match - pass the TIED macro argument accordingly. While doing that also slightly re-arrange table entries, such that all predicated insns are close together. At the same time change the existing test source to actually use non- matching operands for the respective bfml{a,s} forms. --- a/gas/testsuite/gas/aarch64/bfloat16-1.d +++ b/gas/testsuite/gas/aarch64/bfloat16-1.d @@ -50,24 +50,24 @@ .*: 64222604 bfclamp z4.h, z16.h, z2.h .*: 64212688 bfclamp z8.h, z20.h, z1.h .*: 64202710 bfclamp z16.h, z24.h, z0.h -.*: 65300000 bfmla z0.h, p0\/m, z0.h, z16.h -.*: 65280421 bfmla z1.h, p1\/m, z1.h, z8.h -.*: 65240842 bfmla z2.h, p2\/m, z2.h, z4.h -.*: 65221084 bfmla z4.h, p4\/m, z4.h, z2.h -.*: 65211908 bfmla z8.h, p6\/m, z8.h, z1.h -.*: 65201e10 bfmla z16.h, p7\/m, z16.h, z0.h +.*: 65300080 bfmla z0.h, p0\/m, z4.h, z16.h +.*: 65280501 bfmla z1.h, p1\/m, z8.h, z8.h +.*: 65240982 bfmla z2.h, p2\/m, z12.h, z4.h +.*: 65221204 bfmla z4.h, p4\/m, z16.h, z2.h +.*: 65211a88 bfmla z8.h, p6\/m, z20.h, z1.h +.*: 65201f10 bfmla z16.h, p7\/m, z24.h, z0.h .*: 647e0a00 bfmla z0.h, z16.h, z6.h\[7\] .*: 64750901 bfmla z1.h, z8.h, z5.h\[6\] .*: 646409c2 bfmla z2.h, z14.h, z4.h\[4\] .*: 64320aa4 bfmla z4.h, z21.h, z2.h\[2\] .*: 64290988 bfmla z8.h, z12.h, z1.h\[1\] .*: 64200950 bfmla z16.h, z10.h, z0.h\[0\] -.*: 65302000 bfmls z0.h, p0\/m, z0.h, z16.h -.*: 65282421 bfmls z1.h, p1\/m, z1.h, z8.h -.*: 65242842 bfmls z2.h, p2\/m, z2.h, z4.h -.*: 65223084 bfmls z4.h, p4\/m, z4.h, z2.h -.*: 65213908 bfmls z8.h, p6\/m, z8.h, z1.h -.*: 65203e10 bfmls z16.h, p7\/m, z16.h, z0.h +.*: 65302080 bfmls z0.h, p0\/m, z4.h, z16.h +.*: 65282501 bfmls z1.h, p1\/m, z8.h, z8.h +.*: 65242982 bfmls z2.h, p2\/m, z12.h, z4.h +.*: 65223204 bfmls z4.h, p4\/m, z16.h, z2.h +.*: 65213a88 bfmls z8.h, p6\/m, z20.h, z1.h +.*: 65203f10 bfmls z16.h, p7\/m, z24.h, z0.h .*: 647e0e00 bfmls z0.h, z16.h, z6.h\[7\] .*: 64750d01 bfmls z1.h, z8.h, z5.h\[6\] .*: 64640dc2 bfmls z2.h, z14.h, z4.h\[4\] --- a/gas/testsuite/gas/aarch64/bfloat16-1.s +++ b/gas/testsuite/gas/aarch64/bfloat16-1.s @@ -46,12 +46,13 @@ bfclamp z2.h, z12.h, z4.h bfclamp z4.h, z16.h, z2.h bfclamp z8.h, z20.h, z1.h bfclamp z16.h, z24.h, z0.h -bfmla z0.h, p0/m, z0.h, z16.h -bfmla z1.h, p1/m, z1.h, z8.h -bfmla z2.h, p2/m, z2.h, z4.h -bfmla z4.h, p4/m, z4.h, z2.h -bfmla z8.h, p6/m, z8.h, z1.h -bfmla z16.h, p7/m, z16.h, z0.h + +bfmla z0.h, p0/m, z4.h, z16.h +bfmla z1.h, p1/m, z8.h, z8.h +bfmla z2.h, p2/m, z12.h, z4.h +bfmla z4.h, p4/m, z16.h, z2.h +bfmla z8.h, p6/m, z20.h, z1.h +bfmla z16.h, p7/m, z24.h, z0.h bfmla z0.h, z16.h, z6.h[7] bfmla z1.h, z8.h, z5.h[6] @@ -60,12 +61,12 @@ bfmla z4.h, z21.h, z2.h[2] bfmla z8.h, z12.h, z1.h[1] bfmla z16.h, z10.h, z0.h[0] -bfmls z0.h, p0/m, z0.h, z16.h -bfmls z1.h, p1/m, z1.h, z8.h -bfmls z2.h, p2/m, z2.h, z4.h -bfmls z4.h, p4/m, z4.h, z2.h -bfmls z8.h, p6/m, z8.h, z1.h -bfmls z16.h, p7/m, z16.h, z0.h +bfmls z0.h, p0/m, z4.h, z16.h +bfmls z1.h, p1/m, z8.h, z8.h +bfmls z2.h, p2/m, z12.h, z4.h +bfmls z4.h, p4/m, z16.h, z2.h +bfmls z8.h, p6/m, z20.h, z1.h +bfmls z16.h, p7/m, z24.h, z0.h bfmls z0.h, z16.h, z6.h[7] bfmls z1.h, z8.h, z5.h[6] --- a/gas/testsuite/gas/aarch64/bfloat16-bad.l +++ b/gas/testsuite/gas/aarch64/bfloat16-bad.l @@ -41,24 +41,24 @@ .*: Error: selected processor does not support `bfclamp z4.h,z16.h,z2.h' .*: Error: selected processor does not support `bfclamp z8.h,z20.h,z1.h' .*: Error: selected processor does not support `bfclamp z16.h,z24.h,z0.h' -.*: Error: selected processor does not support `bfmla z0.h,p0\/m,z0.h,z16.h' -.*: Error: selected processor does not support `bfmla z1.h,p1\/m,z1.h,z8.h' -.*: Error: selected processor does not support `bfmla z2.h,p2\/m,z2.h,z4.h' -.*: Error: selected processor does not support `bfmla z4.h,p4\/m,z4.h,z2.h' -.*: Error: selected processor does not support `bfmla z8.h,p6\/m,z8.h,z1.h' -.*: Error: selected processor does not support `bfmla z16.h,p7\/m,z16.h,z0.h' +.*: Error: selected processor does not support `bfmla .* +.*: Error: selected processor does not support `bfmla .* +.*: Error: selected processor does not support `bfmla .* +.*: Error: selected processor does not support `bfmla .* +.*: Error: selected processor does not support `bfmla .* +.*: Error: selected processor does not support `bfmla .* .*: Error: selected processor does not support `bfmla z0.h,z16.h,z6.h\[7\]' .*: Error: selected processor does not support `bfmla z1.h,z8.h,z5.h\[6\]' .*: Error: selected processor does not support `bfmla z2.h,z14.h,z4.h\[4\]' .*: Error: selected processor does not support `bfmla z4.h,z21.h,z2.h\[2\]' .*: Error: selected processor does not support `bfmla z8.h,z12.h,z1.h\[1\]' .*: Error: selected processor does not support `bfmla z16.h,z10.h,z0.h\[0\]' -.*: Error: selected processor does not support `bfmls z0.h,p0\/m,z0.h,z16.h' -.*: Error: selected processor does not support `bfmls z1.h,p1\/m,z1.h,z8.h' -.*: Error: selected processor does not support `bfmls z2.h,p2\/m,z2.h,z4.h' -.*: Error: selected processor does not support `bfmls z4.h,p4\/m,z4.h,z2.h' -.*: Error: selected processor does not support `bfmls z8.h,p6\/m,z8.h,z1.h' -.*: Error: selected processor does not support `bfmls z16.h,p7\/m,z16.h,z0.h' +.*: Error: selected processor does not support `bfmls .* +.*: Error: selected processor does not support `bfmls .* +.*: Error: selected processor does not support `bfmls .* +.*: Error: selected processor does not support `bfmls .* +.*: Error: selected processor does not support `bfmls .* +.*: Error: selected processor does not support `bfmls .* .*: Error: selected processor does not support `bfmls z0.h,z16.h,z6.h\[7\]' .*: Error: selected processor does not support `bfmls z1.h,z8.h,z5.h\[6\]' .*: Error: selected processor does not support `bfmls z2.h,z14.h,z4.h\[4\]' --- /dev/null +++ b/gas/testsuite/gas/aarch64/bfloat16-invalid.d @@ -0,0 +1,4 @@ +#name: Test Bfloat16 instructions with wrong operand combinations +#as: -march=armv9.4-a +#source: bfloat16-invalid.s +#error_output: bfloat16-invalid.l --- /dev/null +++ b/gas/testsuite/gas/aarch64/bfloat16-invalid.l @@ -0,0 +1,8 @@ +.*: Assembler messages: +[^ :]+:[0-9]+: Error: operand 3 must be the same register as operand 1 -- `bfadd .* +[^ :]+:[0-9]+: Error: operand 3 must be the same register as operand 1 -- `bfmax .* +[^ :]+:[0-9]+: Error: operand 3 must be the same register as operand 1 -- `bfmaxnm .* +[^ :]+:[0-9]+: Error: operand 3 must be the same register as operand 1 -- `bfmin .* +[^ :]+:[0-9]+: Error: operand 3 must be the same register as operand 1 -- `bfminnm .* +[^ :]+:[0-9]+: Error: operand 3 must be the same register as operand 1 -- `bfmul .* +[^ :]+:[0-9]+: Error: operand 3 must be the same register as operand 1 -- `bfsub .* --- /dev/null +++ b/gas/testsuite/gas/aarch64/bfloat16-invalid.s @@ -0,0 +1,13 @@ +bfadd z0.h, p0/m, z1.h, z0.h + +bfmax z0.h, p0/m, z1.h, z0.h + +bfmaxnm z0.h, p0/m, z1.h, z0.h + +bfmin z0.h, p0/m, z1.h, z0.h + +bfminnm z0.h, p0/m, z1.h, z0.h + +bfmul z0.h, p0/m, z1.h, z0.h + +bfsub z0.h, p0/m, z1.h, z0.h --- a/opcodes/aarch64-dis-2.c +++ b/opcodes/aarch64-dis-2.c @@ -32211,14 +32211,14 @@ aarch64_find_next_opcode (const aarch64_ case 1705: return NULL; /* ldff1h --> NULL. */ case 1659: value = 3313; break; /* ld2h --> ld2q. */ case 3313: return NULL; /* ld2q --> NULL. */ - case 2464: value = 3279; break; /* fclamp --> bfclamp. */ - case 3279: return NULL; /* bfclamp --> NULL. */ + case 2464: value = 3281; break; /* fclamp --> bfclamp. */ + case 3281: return NULL; /* bfclamp --> NULL. */ case 1778: value = 1779; break; /* ldr --> ldr. */ case 1779: return NULL; /* ldr --> NULL. */ - case 1434: value = 3278; break; /* fadd --> bfadd. */ - case 3278: return NULL; /* bfadd --> NULL. */ - case 1501: value = 3281; break; /* fmul --> bfmul. */ - case 3281: return NULL; /* bfmul --> NULL. */ + case 1434: value = 3280; break; /* fadd --> bfadd. */ + case 3280: return NULL; /* bfadd --> NULL. */ + case 1501: value = 3282; break; /* fmul --> bfmul. */ + case 3282: return NULL; /* bfmul --> NULL. */ case 1527: value = 3283; break; /* fsub --> bfsub. */ case 3283: return NULL; /* bfsub --> NULL. */ case 1492: value = 3276; break; /* fmla --> bfmla. */ @@ -32251,12 +32251,12 @@ aarch64_find_next_opcode (const aarch64_ case 3271: return NULL; /* bfadd --> NULL. */ case 1482: value = 3273; break; /* fmaxnm --> bfmaxnm. */ case 3273: return NULL; /* bfmaxnm --> NULL. */ - case 1502: value = 3280; break; /* fmul --> bfmul. */ - case 3280: return NULL; /* bfmul --> NULL. */ + case 1502: value = 3278; break; /* fmul --> bfmul. */ + case 3278: return NULL; /* bfmul --> NULL. */ case 1480: value = 3272; break; /* fmax --> bfmax. */ case 3272: return NULL; /* bfmax --> NULL. */ - case 1528: value = 3282; break; /* fsub --> bfsub. */ - case 3282: return NULL; /* bfsub --> NULL. */ + case 1528: value = 3279; break; /* fsub --> bfsub. */ + case 3279: return NULL; /* bfsub --> NULL. */ case 1488: value = 3275; break; /* fminnm --> bfminnm. */ case 3275: return NULL; /* bfminnm --> NULL. */ case 1486: value = 3274; break; /* fmin --> bfmin. */ --- a/opcodes/aarch64-tbl.h +++ b/opcodes/aarch64-tbl.h @@ -6331,18 +6331,18 @@ const struct aarch64_opcode aarch64_opco D128_THE_INSN("rcwsswppl", 0x5960a000, 0xffe0fc00, OP3 (Rt, Rs, ADDR_SIMPLE), QL_X2NIL, 0), /* BFloat16 SVE Instructions. */ - B16B16_INSNC("bfadd", 0x65008000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), - B16B16_INSNC("bfmax", 0x65068000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), - B16B16_INSNC("bfmaxnm", 0x65048000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), - B16B16_INSNC("bfmin", 0x65078000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), - B16B16_INSNC("bfminnm", 0x65058000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), + B16B16_INSNC("bfadd", 0x65008000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 2), + B16B16_INSNC("bfmax", 0x65068000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 2), + B16B16_INSNC("bfmaxnm", 0x65048000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 2), + B16B16_INSNC("bfmin", 0x65078000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 2), + B16B16_INSNC("bfminnm", 0x65058000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 2), B16B16_INSNC("bfmla", 0x65200000, 0xffe0e000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zn, SVE_Zm_16), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), B16B16_INSNC("bfmls", 0x65202000, 0xffe0e000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zn, SVE_Zm_16), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), + B16B16_INSNC("bfmul", 0x65028000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 2), + B16B16_INSNC("bfsub", 0x65018000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 2), B16B16_INSN("bfadd", 0x65000000, 0xffe0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm_16), OP_SVE_HHH, 0, 0), B16B16_INSN("bfclamp", 0x64202400, 0xffe0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm_16), OP_SVE_HHH, 0, 0), - B16B16_INSNC("bfmul", 0x65028000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), B16B16_INSN("bfmul", 0x65000800, 0xffe0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm_16), OP_SVE_HHH, 0, 0), - B16B16_INSNC("bfsub", 0x65018000, 0xffffe000, sve_misc, 0, OP4 (SVE_Zd, SVE_Pg3, SVE_Zd, SVE_Zm_5), OP_SVE_SMSS, 0, C_SCAN_MOVPRFX, 0), B16B16_INSN("bfsub", 0x65000400, 0xffe0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm_16), OP_SVE_HHH, 0, 0), B16B16_INSN("bfmla", 0x64200800, 0xffa0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_22_INDEX), OP_SVE_VVV_H, 0, 0), B16B16_INSN("bfmls", 0x64200c00, 0xffa0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zn, SVE_Zm3_22_INDEX), OP_SVE_VVV_H, 0, 0), From patchwork Fri Feb 23 11:29:00 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 86273 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D9D2C3858012 for ; Fri, 23 Feb 2024 11:29:42 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id BAA503858D1E for ; Fri, 23 Feb 2024 11:29:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BAA503858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BAA503858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::630 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687745; cv=none; b=aqfd5QadMvUTiEaVUVi+uDkdKJTCPB0wvFZf5Aqw0QTWLWFnK3X3b5j8LbSza/+KlCqfUQ4y9bUXgAbGrmSVjC/R/b/SPnZqVda7PhTroGbdZp0aIXMvDNdbyvbVoWotWATPMEVp8TZ1hyj4ITvnUOPjFN+NUx7fCa9DB8hnVp8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687745; c=relaxed/simple; bh=j/DGANxKYB2hIpMf3BsDaM4oPW2PHpR5xhfY80Av710=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=xoVtRE2BWXpS9ae2VGZSCw7LvWYy3gLxOWJG0rsrBCU9+U2LftSKM+vO0G/R7+nWRmdfWjd/7OFugPcX/CPvFBW35ZLBiQtfy6gEyu5RZaTIdJoIVA4BhkgF6JAuV8ei8rFUbWG6xesWptVekrflYQMrL+HiP00/sfE5x6hIlZs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a34c5ca2537so101416866b.0 for ; Fri, 23 Feb 2024 03:29:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1708687741; x=1709292541; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=J7524zXhLdfOPLJorzyTEYMsheEVv2Ld4mph1TnAsFw=; b=I2UobTsVtfcWHkDdwd3vom8OdobhAf9+1mWDem4Rluz+K7Dby5cQuJfEZdA5QxdH8T WlBn6MZzXuwC8xLdCIEXiilvWPjk56/FGA5SRgoaqQ8XKfcZDqpUf01a8oFCUcLgmXi8 S8qfUpVmKjl6SbdL+wRwn3IUaVkWN6UH+kCM0eNIyq4uD5Y1Z64oagWSCsTTLEn1NvQU 9NrbGddrcRfPlgRDnE+IM9nRA0WUmnkTfmsA8JFnvlXB1fh20NzVS2j6i2WLoWphazVF BecfCVV1UAVgHLoFcNABKhb1Zg5A9LgFRX5VTBqnmMcVeP5Ozb2dl4Mj7bffY1e9Gq9k jR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708687741; x=1709292541; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J7524zXhLdfOPLJorzyTEYMsheEVv2Ld4mph1TnAsFw=; b=Eu1mfQfwvAEoowFDLqyApSIwTU1KQh6zUkW8iyIzqEM5Tu0e1ZzOAkOo+jkl71FKi/ u0mEyVBNjkCyoUhE6601Xhx9fBZfbtKGXAXqUcXooj0Vjp6bIwUxM/LdpnGXgW0VSAdx n20VyLlaF/KQf6ZUzeYS4Hh9u1Qox6tms0mw5Kk3CedwLwUWA7edNCM7dzCSiz4cJjD8 AC0U9P9mwG0ICuyEFEmBzcwrSFfb4jkmL2eZxM8zKxML9Px/RqRJ6MIRhyZbj+NXyJSQ 3EDMvflz9rG7LpE7eqOezgNNLL7MH4ESOrjoHoUUziFpDKOUvaPpTN4lIqwR9KVi+43T 3tKw== X-Gm-Message-State: AOJu0YyGb0hYZptLfhEMt/s1jBAgcqpO5V3se56iFk94//w5ewoLheeT fchAANDHt1sheP7aQGgyAH/uFFMhqjH1Qv8+d8bfxl018ErLmebocf7IJUEvUMKQesYUb9hamWk = X-Google-Smtp-Source: AGHT+IFGcdsA1pGzmfkzVN/kl0E5XGyd6mZ6xkNpx5anWzr6vx81hUvIoKU358ROJFnebndMJjZ0bQ== X-Received: by 2002:a17:906:a92:b0:a3e:7a8f:27dc with SMTP id y18-20020a1709060a9200b00a3e7a8f27dcmr1019609ejf.49.1708687741488; Fri, 23 Feb 2024 03:29:01 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id lu16-20020a170906fad000b00a3d5efc65e0sm5486296ejb.91.2024.02.23.03.29.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 03:29:01 -0800 (PST) Message-ID: <9f36e4cc-46c9-4a88-9b4d-a40298ea3c12@suse.com> Date: Fri, 23 Feb 2024 12:29:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 3/6] Arm64: check tied operand specifier in aarch64-gen Content-Language: en-US From: Jan Beulich To: Binutils Cc: Richard Earnshaw , Marcus Shawcroft , Nick Clifton References: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Make sure that field actually matches the specified operands. Don't follow existing F_PSEUDO checking in using assertions, though. Print meaingful error messages, thus - while not having a line number available - at least providing some indication of where things are wrong. Fix SVE2.1's extq accordingly, but don't extend the testsuite there: There are further issues with its operands (SVE_Zm_imm4 doesn't look to be correct to use there, as that describes an indexed vector register, while here a separate vector register and immediate operand are to be specified). --- a/opcodes/aarch64-gen.c +++ b/opcodes/aarch64-gen.c @@ -129,6 +129,7 @@ read_table (const struct aarch64_opcode* const struct aarch64_opcode *ent = table; opcode_node **new_ent; unsigned int index = initialize_index (table); + unsigned int errors = 0; if (!ent->name) return; @@ -140,6 +141,8 @@ read_table (const struct aarch64_opcode* do { + bool match = false; + /* F_PSEUDO needs to be used together with F_ALIAS to indicate an alias opcode is a programmer friendly pseudo instruction available only in the assembly code (thus will not show up in the disassembly). */ @@ -150,12 +153,45 @@ read_table (const struct aarch64_opcode* index++; continue; } + + /* Check tied_operand against operands[]. */ + for (unsigned int i = 1; i < ARRAY_SIZE (ent->operands); ++i) + { + if (ent->operands[i] == AARCH64_OPND_NIL) + break; + + if (ent->operands[i] != ent->operands[0]) + continue; + match = true; + + if (i != ent->tied_operand) + { + fprintf (stderr, "%s: operands 1 and %u match, but tied=%u\n", + ent->name, i + 1, ent->tied_operand); + ++errors; + } + } + if (!match && ent->tied_operand + /* SME LDR/STR (array vector) tie together inner immediates only. */ + && ent->iclass != sme_ldr && ent->iclass != sme_str) + { + fprintf (stderr, "%s: no operands match, but tied=%u\n", + ent->name, ent->tied_operand); + ++errors; + } + *new_ent = new_opcode_node (); (*new_ent)->opcode = ent->opcode; (*new_ent)->mask = ent->mask; (*new_ent)->index = index++; new_ent = &((*new_ent)->next); } while ((++ent)->name); + + if (errors) + { + fprintf (stderr, "%u errors, exiting\n", errors); + xexit (3); + } } static inline void --- a/opcodes/aarch64-tbl.h +++ b/opcodes/aarch64-tbl.h @@ -6375,7 +6375,7 @@ const struct aarch64_opcode aarch64_opco SVE2p1_INSNC("fminqv",0x6417a000, 0xff3fe000, sve2_urqvs, 0, OP3 (Vd, SVE_Pg3, SVE_Zn), OP_SVE_vUS_HSD_HSD, F_OPD_SIZE, C_SCAN_MOVPRFX, 0), SVE2p1_INSN("dupq",0x05202400, 0xffe0fc00, sve_index1, 0, OP2 (SVE_Zd, SVE_Zn_5_INDEX), OP_SVE_VV_BHSD, 0, 0), - SVE2p1_INSN("extq",0x05602400, 0xfff0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zd, SVE_Zm_imm4), OP_SVE_BBB, 0, 0), + SVE2p1_INSN("extq",0x05602400, 0xfff0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zd, SVE_Zm_imm4), OP_SVE_BBB, 0, 1), SVE2p1_INSNC("ld1q",0xc400a000, 0xffe0e000, sve_misc, 0, OP3 (SVE_Zt, SVE_Pg3, SVE_ADDR_ZX), OP_SVE_SZS_QD, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld2q",0xa490e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt2, SVE_Pg3, SVE_ADDR_RI_S4x2xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld3q",0xa510e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt3, SVE_Pg3, SVE_ADDR_RI_S4x2xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), From patchwork Fri Feb 23 11:29:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 86274 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 74D4E385842D for ; Fri, 23 Feb 2024 11:30:13 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 822F13858D1E for ; Fri, 23 Feb 2024 11:29:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 822F13858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 822F13858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687777; cv=none; b=tN5oIouaBN/09GaOys+9iZOJ1pt2hTlLCceOnt/jchkZRCqC9S/kKVqnQNlMNJMTkqqexWLyXmtrEgpbjTS6FD+Yl+TnlhvGJLTb2zC044bebR8FB+RLawNHlTjgDojlE1vNcfNLwID+/gwvaOaMFRIjxqEVX5j3ZR+taGcp2ro= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687777; c=relaxed/simple; bh=Pdw38olcd63tTBCGqZl4KRTbx2B1eJsSyMUthGCazkE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=dvbEl39ZaM0beeXKfOjFmFgAtrbguIe4a9DVv598iqIqFbAulQSaKxQ05AZSnJI0tlz//735RcxZxhDXwgG1xTpKK59B2NzYjUO6bbBOCkWZ0lV/ZV9H/jHwvE9bylw31QMErJR58GJFlce480Yaa1LSc4YjdC1TdKfi0fHUjSk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-a3f893ad5f4so103299366b.2 for ; Fri, 23 Feb 2024 03:29:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1708687773; x=1709292573; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=6XIaw2/NpXMo3YlsL3ByXjD1FwQgaVOo/GVorDgixFo=; b=IKiGYS+GDeX27P7eNjSvqBZwPly69TN5I+DeiuIpsQsLEXlEzvTyQKlc9OFGK4trXK 1j2IbQqnmsN+GlQc3NDK3QDdIpaANC5w62cjKm3BTWJTk082HB3NUK3BTFC81Xw6GUEG ZZ2plt+eiIbRd4znnbFnpXVCAd9sLauTB4bEANU6Xhy1fWNst376l9EwQMxrRO+SOdCh GXJs7An1+6eN0gPPg1BhuGZYGVMe2OPcNg+WMFtn7dLVDbTSzwPshepXLoeEK9esa6sf PhWEOtg3xwzESccEGIL97obiD+uQh/pvbzog4JEdSwy1LSNFVa9IX32W9apZTlK6/Bp0 A95A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708687773; x=1709292573; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6XIaw2/NpXMo3YlsL3ByXjD1FwQgaVOo/GVorDgixFo=; b=UEWHU/PRZZDWPBgWEYFHMOcd/jIHW8xKyotVD6IDPKKM8OC/LEF1S4ODM/aYTlaBFX wBDky3Net2WX5or9jgIyIWxQS8hwAJsrfuizlafFs/z8PwrOOQK6GbLmxMaNcD9w04zl c/agZDDt+o2KmjvBFHGmgVXHzmT/QkRaZEnI3AgFx4L4il/V7UePYnGymg7PIjCP+zTK 1xqWBgj+kueVWfVLG0pD4S8MEaIAqUin4ZpGtmD3egPXqlOzI0PKqSDX/YRp0WkyAUR9 DF0yKf1WwQVQCDcluDUJ+LkPKAOhP+3tTH5yy/zYG4MyrAvhMhMoGW1UDt55XePRESVV /7aA== X-Gm-Message-State: AOJu0YzvPVQPTKO13kbVHE+2EsDhcq7O6T7Tvd/eVmQ2K874fUYKzeAM 0v5gqcxwqFBENyHNhtp0+H83AYxbElsXu4igiqtMDYfzvkwWCZnXPEtF23dGfaROw+u8+DJLQFk = X-Google-Smtp-Source: AGHT+IEx2uDAN1/+MbAUV8GBQi84CXMDHgVJLyiKZUPZIYbUy/l+y3aV6UMYtAbLs0XHnXjKvC2+Vw== X-Received: by 2002:a17:906:dd2:b0:a3f:9d69:3643 with SMTP id p18-20020a1709060dd200b00a3f9d693643mr985324eji.32.1708687773112; Fri, 23 Feb 2024 03:29:33 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id lu16-20020a170906fad000b00a3d5efc65e0sm5486296ejb.91.2024.02.23.03.29.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 03:29:32 -0800 (PST) Message-ID: <93c4fe9f-159b-42d2-9003-8593e0782c74@suse.com> Date: Fri, 23 Feb 2024 12:29:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 4/6] Arm64: correct SVE2.1 ld{3,4}q / st{3,4}q (scalar plus immediate) Content-Language: en-US From: Jan Beulich To: Binutils Cc: Richard Earnshaw , Marcus Shawcroft , Nick Clifton References: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org Like their byte, half, word, and doubleword counterparts their immediates are multiples of 3 / 4 respectively. --- a/gas/testsuite/gas/aarch64/sve2p1-1.d +++ b/gas/testsuite/gas/aarch64/sve2p1-1.d @@ -1,4 +1,4 @@ -#name: Test of SVE2.1 min max instructions. +#name: Test of SVE2.1 instructions #as: -march=armv9.4-a+sve2p1 #objdump: -dr @@ -91,15 +91,15 @@ .*: 6497bc10 fminqv v16.4s, p7, z0.s .*: c400b200 ld1q z0.q, p4/z, \[z16.d, x0\] .*: a49ef000 ld2q {z0.q, z1.q}, p4/z, \[x0, #-4, mul vl\] -.*: a51ef000 ld3q {z0.q, z1.q, z2.q}, p4/z, \[x0, #-4, mul vl\] -.*: a59ef000 ld4q {z0.q, z1.q, z2.q, z3.q}, p4/z, \[x0, #-4, mul vl\] +.*: a51ef000 ld3q {z0.q, z1.q, z2.q}, p4/z, \[x0, #-6, mul vl\] +.*: a59ef000 ld4q {z0.q, z1.q, z2.q, z3.q}, p4/z, \[x0, #-8, mul vl\] .*: a4a2f000 ld2h {z0.h-z1.h}, p4/z, \[x0, #4, mul vl\] .*: a5249000 ld3q {z0.q, z1.q, z2.q}, p4/z, \[x0, x4, lsl #4\] .*: a5a69000 ld4q {z0.q, z1.q, z2.q, z3.q}, p4/z, \[x0, x6, lsl #4\] .*: e4203200 st1q z0.q, p4, \[z16.d, x0\] .*: e44e1000 st2q {z0.q, z1.q}, p4, \[x0, #-4, mul vl\] -.*: e48e1000 st3q {z0.q, z1.q, z2.q}, p4, \[x0, #-4, mul vl\] -.*: e4ce1000 st4q {z0.q, z1.q, z2.q, z3.q}, p4, \[x0, #-4, mul vl\] +.*: e48e1000 st3q {z0.q, z1.q, z2.q}, p4, \[x0, #-6, mul vl\] +.*: e4ce1000 st4q {z0.q, z1.q, z2.q, z3.q}, p4, \[x0, #-8, mul vl\] .*: e4621000 st2q {z0.q, z1.q}, p4, \[x0, x2, lsl #4\] .*: e4a41000 st3q {z0.q, z1.q, z2.q}, p4, \[x0, x4, lsl #4\] .*: e4e61000 st4q {z0.q, z1.q, z2.q, z3.q}, p4, \[x0, x6, lsl #4\] --- a/gas/testsuite/gas/aarch64/sve2p1-1.s +++ b/gas/testsuite/gas/aarch64/sve2p1-1.s @@ -92,16 +92,16 @@ fminqv v8.2d, p4, z1.d fminqv v16.4s, p7, z0.s ld1q Z0.Q, p4/Z, [Z16.D, x0] ld2q {Z0.Q, Z1.Q}, p4/Z, [x0, #-4, MUL VL] -ld3q {Z0.Q, Z1.Q, Z2.Q}, p4/Z, [x0, #-4, MUL VL] -ld4q {Z0.Q, Z1.Q, Z2.Q, Z3.Q}, p4/Z, [x0, #-4, MUL VL] +ld3q {Z0.Q, Z1.Q, Z2.Q}, p4/Z, [x0, #-6, MUL VL] +ld4q {Z0.Q, Z1.Q, Z2.Q, Z3.Q}, p4/Z, [x0, #-8, MUL VL] ld2q {Z0.Q, Z1.Q}, p4/Z, [x0, x2, lsl #4] ld3q {Z0.Q, Z1.Q, Z2.Q}, p4/Z, [x0, x4, lsl #4] ld4q {Z0.Q, Z1.Q, Z2.Q, Z3.Q}, p4/Z, [x0, x6, lsl #4] st1q Z0.Q, p4, [Z16.D, x0] st2q {Z0.Q, Z1.Q}, p4, [x0, #-4, MUL VL] -st3q {Z0.Q, Z1.Q, Z2.Q}, p4, [x0, #-4, MUL VL] -st4q {Z0.Q, Z1.Q, Z2.Q, Z3.Q}, p4, [x0, #-4, MUL VL] +st3q {Z0.Q, Z1.Q, Z2.Q}, p4, [x0, #-6, MUL VL] +st4q {Z0.Q, Z1.Q, Z2.Q, Z3.Q}, p4, [x0, #-8, MUL VL] st2q {Z0.Q, Z1.Q}, p4, [x0, x2, lsl #4] st3q {Z0.Q, Z1.Q, Z2.Q}, p4, [x0, x4, lsl #4] st4q {Z0.Q, Z1.Q, Z2.Q, Z3.Q}, p4, [x0, x6, lsl #4] --- a/gas/testsuite/gas/aarch64/sve2p1-1-bad.l +++ b/gas/testsuite/gas/aarch64/sve2p1-1-bad.l @@ -82,15 +82,15 @@ .*: Error: selected processor does not support `fminqv v16.4s,p7,z0.s' .*: Error: selected processor does not support `ld1q Z0.Q,p4/Z,\[Z16.D,x0\]' .*: Error: selected processor does not support `ld2q {Z0.Q,Z1.Q},p4/Z,\[x0,#-4,MUL VL\]' -.*: Error: selected processor does not support `ld3q {Z0.Q,Z1.Q,Z2.Q},p4/Z,\[x0,#-4,MUL VL\]' -.*: Error: selected processor does not support `ld4q {Z0.Q,Z1.Q,Z2.Q,Z3.Q},p4/Z,\[x0,#-4,MUL VL\]' +.*: Error: selected processor does not support `ld3q .* +.*: Error: selected processor does not support `ld4q .* .*: Error: selected processor does not support `ld2q {Z0.Q,Z1.Q},p4/Z,\[x0,x2,lsl#4\]' .*: Error: selected processor does not support `ld3q {Z0.Q,Z1.Q,Z2.Q},p4/Z,\[x0,x4,lsl#4\]' .*: Error: selected processor does not support `ld4q {Z0.Q,Z1.Q,Z2.Q,Z3.Q},p4/Z,\[x0,x6,lsl#4\]' .*: Error: selected processor does not support `st1q Z0.Q,p4,\[Z16.D,x0\]' .*: Error: selected processor does not support `st2q {Z0.Q,Z1.Q},p4,\[x0,#-4,MUL VL\]' -.*: Error: selected processor does not support `st3q {Z0.Q,Z1.Q,Z2.Q},p4,\[x0,#-4,MUL VL\]' -.*: Error: selected processor does not support `st4q {Z0.Q,Z1.Q,Z2.Q,Z3.Q},p4,\[x0,#-4,MUL VL\]' +.*: Error: selected processor does not support `st3q .* +.*: Error: selected processor does not support `st4q .* .*: Error: selected processor does not support `st2q {Z0.Q,Z1.Q},p4,\[x0,x2,lsl#4\]' .*: Error: selected processor does not support `st3q {Z0.Q,Z1.Q,Z2.Q},p4,\[x0,x4,lsl#4\]' .*: Error: selected processor does not support `st4q {Z0.Q,Z1.Q,Z2.Q,Z3.Q},p4,\[x0,x6,lsl#4\]' --- a/opcodes/aarch64-tbl.h +++ b/opcodes/aarch64-tbl.h @@ -6378,16 +6378,16 @@ const struct aarch64_opcode aarch64_opco SVE2p1_INSN("extq",0x05602400, 0xfff0fc00, sve_misc, 0, OP3 (SVE_Zd, SVE_Zd, SVE_Zm_imm4), OP_SVE_BBB, 0, 1), SVE2p1_INSNC("ld1q",0xc400a000, 0xffe0e000, sve_misc, 0, OP3 (SVE_Zt, SVE_Pg3, SVE_ADDR_ZX), OP_SVE_SZS_QD, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld2q",0xa490e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt2, SVE_Pg3, SVE_ADDR_RI_S4x2xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), - SVE2p1_INSNC("ld3q",0xa510e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt3, SVE_Pg3, SVE_ADDR_RI_S4x2xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), - SVE2p1_INSNC("ld4q",0xa590e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt4, SVE_Pg3, SVE_ADDR_RI_S4x2xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), + SVE2p1_INSNC("ld3q",0xa510e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt3, SVE_Pg3, SVE_ADDR_RI_S4x3xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), + SVE2p1_INSNC("ld4q",0xa590e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt4, SVE_Pg3, SVE_ADDR_RI_S4x4xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld2q",0xa4a0e000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt2, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld3q",0xa5208000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt3, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld4q",0xa5a08000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt4, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("st1q",0xe4202000, 0xffe0e000, sve_misc, 0, OP3 (SVE_Zt, SVE_Pg3, SVE_ADDR_ZX), OP_SVE_SUS_QD, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("st2q",0xe4400000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt2, SVE_Pg3, SVE_ADDR_RI_S4x2xVL), OP_SVE_QUU, 0, C_SCAN_MOVPRFX, 0), - SVE2p1_INSNC("st3q",0xe4800000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt3, SVE_Pg3, SVE_ADDR_RI_S4x2xVL), OP_SVE_QUU, 0, C_SCAN_MOVPRFX, 0), - SVE2p1_INSNC("st4q",0xe4c00000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt4, SVE_Pg3, SVE_ADDR_RI_S4x2xVL), OP_SVE_QUU, 0, C_SCAN_MOVPRFX, 0), + SVE2p1_INSNC("st3q",0xe4800000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt3, SVE_Pg3, SVE_ADDR_RI_S4x3xVL), OP_SVE_QUU, 0, C_SCAN_MOVPRFX, 0), + SVE2p1_INSNC("st4q",0xe4c00000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt4, SVE_Pg3, SVE_ADDR_RI_S4x4xVL), OP_SVE_QUU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("st2q",0xe4600000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt2, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QUU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("st3q",0xe4a00000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt3, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QUU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("st4q",0xe4e00000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt4, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QUU, 0, C_SCAN_MOVPRFX, 0), From patchwork Fri Feb 23 11:30:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 86275 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8CB7B3858436 for ; Fri, 23 Feb 2024 11:31:07 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 18B24385828A for ; Fri, 23 Feb 2024 11:30:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18B24385828A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 18B24385828A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::62a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687833; cv=none; b=qEN+QhfH8QK/5mJm0Cfbmv4kIhBE/SuIsn1e8DKwk4rqupChJM7fuG8YYAtvrdE63Z++fW25xwq/NwfOCmQLuNF/m4WkTeSfKqpuGff4NAK7f962mAVYY+Ll+FeOV/Jh7xFZyVAvh/ncKQKd5jtrSvqs5Ik15DnhUWszfYqJa2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687833; c=relaxed/simple; bh=D+EpTTzdGlq2CYp/ymoHgmep+CS7aP2Y4o/cHUAwBw0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=PYCr3/jfu9BPtpsyXdDSPkBBj5UilY75ks+CoRX1bkymRkYx3Mc28U4g3Z07jhhPqrOda0N/UpaZh2m0bEmT1oEsLWPdBf7fIK3z+yIoANelsppZKgTFJ5n+giIyVPi95Al5FOpXCv9ZTaILM7mnmWnV0wGS5eiLtm3PNikng/c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a3566c0309fso37029766b.1 for ; Fri, 23 Feb 2024 03:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1708687830; x=1709292630; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=FHSPfY3XA+ossL02HvAVO48TZvkCWGbptUr4T3LDtX0=; b=EA4oRlcOHSU8ovkyExEWZ3fJ59UKYzuQq6evg9ilouYcAjqaZpt6iLLFdY5+BTILLr 1QbR2r2CadtIC8YjjTZwFoGikIsIaieO2b1g9Thtz3N/ZXwhRoe1l4OAXqENLv2jyCCl q3a+yCiVJ7Rnsr3MJPCFZ+xU9FSjO9ELb31sa1ugRH2i9vU49vY8iddQChfAeGVdXqN7 FyeWl1EUIyjRPXZxYcAR69cVLw4HmRvnlKot0oP4aklVIcP0L7xsuPGvMFrStaVu4sTI G0anMZE2ChdZKskc6BPXrYiO+d2TuwTRNGAh0QttZ56MwICtEaPqFCm5tXgU4AZAlnC/ B5LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708687830; x=1709292630; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FHSPfY3XA+ossL02HvAVO48TZvkCWGbptUr4T3LDtX0=; b=bu3uKTgvqXRrH7UeVJGjCSll7YCwSGJawOZW23f0cOy5EwDxtvXkJhQ8/ZgjE82yOE q+4d+2Vwfgbfdf0Edw0YaVESjYScbWcljayf7YkeO+GvPXQnLeC5S210g1LM+LIk6XnE 1R2setexxbVW/327wFSL+Qq6SldRvpcx10Z9fb3WsTlPxOZNoTPY1ZXVwPLOh0uY9mZE voLEYxBvpIcn6B0R3kBB3BgnYUbL2uQ84NnOvu97OFgYNohpZQT68IWFM+AXAaL7uy1R V8GDPiEp7Sf4SoUoglM6yoMXMP0gpjefOmHN7QMa67AKNCS6kNSNjIYzeWF7trK9BFzT 85ow== X-Gm-Message-State: AOJu0Yx7RSlVVY8ZX1FNUVHcBHVkj9D+8LnzdzIl78aE5+Rtm+PrsZt/ 7tsbhE1xashxzkJ0UdA6X45eeD55/8s+dbvcdVMyuai4m4QdtzjILtaJTP+0OVGQ7hLdYl6KsMo = X-Google-Smtp-Source: AGHT+IFPVc6N4TexnjGSIifjd1M0KQrMSdSIx14qiMF+2+Usnc+kfkXY5B3fGAfi2IZspbzUm6e1Vg== X-Received: by 2002:a17:906:4ac9:b0:a3e:b188:fcf3 with SMTP id u9-20020a1709064ac900b00a3eb188fcf3mr985282ejt.48.1708687829833; Fri, 23 Feb 2024 03:30:29 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id lu16-20020a170906fad000b00a3d5efc65e0sm5486296ejb.91.2024.02.23.03.30.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 03:30:29 -0800 (PST) Message-ID: <7d119881-d42a-48cf-b50f-7c97819c5047@suse.com> Date: Fri, 23 Feb 2024 12:30:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 5/6] Arm64: correct SVE2.1 ld2q (scalar plus scalar) Content-Language: en-US From: Jan Beulich To: Binutils Cc: Richard Earnshaw , Marcus Shawcroft , Nick Clifton References: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org It's opcode was wrong, as was e.g. easily visible from the inappropriate testcase expectation. --- a/gas/testsuite/gas/aarch64/sve2p1-1.d +++ b/gas/testsuite/gas/aarch64/sve2p1-1.d @@ -93,7 +93,7 @@ .*: a49ef000 ld2q {z0.q, z1.q}, p4/z, \[x0, #-4, mul vl\] .*: a51ef000 ld3q {z0.q, z1.q, z2.q}, p4/z, \[x0, #-6, mul vl\] .*: a59ef000 ld4q {z0.q, z1.q, z2.q, z3.q}, p4/z, \[x0, #-8, mul vl\] -.*: a4a2f000 ld2h {z0.h-z1.h}, p4/z, \[x0, #4, mul vl\] +.*: a4a29000 ld2q {z0.q, z1.q}, p4/z, \[x0, x2, lsl #4\] .*: a5249000 ld3q {z0.q, z1.q, z2.q}, p4/z, \[x0, x4, lsl #4\] .*: a5a69000 ld4q {z0.q, z1.q, z2.q, z3.q}, p4/z, \[x0, x6, lsl #4\] .*: e4203200 st1q z0.q, p4, \[z16.d, x0\] --- a/opcodes/aarch64-tbl.h +++ b/opcodes/aarch64-tbl.h @@ -6380,7 +6380,7 @@ const struct aarch64_opcode aarch64_opco SVE2p1_INSNC("ld2q",0xa490e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt2, SVE_Pg3, SVE_ADDR_RI_S4x2xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld3q",0xa510e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt3, SVE_Pg3, SVE_ADDR_RI_S4x3xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld4q",0xa590e000, 0xfff0e000, sve_misc, 0, OP3 (SME_Zt4, SVE_Pg3, SVE_ADDR_RI_S4x4xVL), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), - SVE2p1_INSNC("ld2q",0xa4a0e000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt2, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), + SVE2p1_INSNC("ld2q",0xa4a08000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt2, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld3q",0xa5208000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt3, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), SVE2p1_INSNC("ld4q",0xa5a08000, 0xffe0e000, sve_misc, 0, OP3 (SME_Zt4, SVE_Pg3, SVE_ADDR_RR_LSL4), OP_SVE_QZU, 0, C_SCAN_MOVPRFX, 0), From patchwork Fri Feb 23 11:30:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 86276 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DD0463858289 for ; Fri, 23 Feb 2024 11:31:31 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by sourceware.org (Postfix) with ESMTPS id DDC28385840C for ; Fri, 23 Feb 2024 11:30:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DDC28385840C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DDC28385840C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::52c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687856; cv=none; b=izrxU2+jlpaxb+sZ/lH9A5J7Gok8kXtpfP6uWr9BU+EmVx0ZP8E5mHUPCVHhDv97D1MxDKnUdzDsQCABdybhLhN+k7ExQKnKvvm/tPQdZnToSAGWTM0LB7Aab6xba08li7CKcrjy2Fx4FYGxxMBZbC5BoJ2FlupyGHVem8IrKcU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708687856; c=relaxed/simple; bh=MdaQU21eUEhQMFXGVYaJGL0aUVObNJZ289yhD33vw7k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=XdzefGO6EBiBkoZiDFYOu6DiKoeHwqrBC1pDUVdKxc+sEsMnmXJwsgo9ikQRXpbirLFq6Tmj6AhlSrP3lOxVz8raWQlGH6qX9qO2JGqu59jzugIqQbARNJE1bVrakp4oT9iQK+Eby9dgGqj8kIwYZHq4Qq22x7y4lSVR1+atdaY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-563b7b3e3ecso871169a12.0 for ; Fri, 23 Feb 2024 03:30:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1708687852; x=1709292652; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Z8dfXQ2Z4W7w34/O/WJn9wy7d2/yI9c9bdvjZ7hBfrY=; b=dU8AaBN/K93+dL8wHyE9oNTcVpdRtyh6G0SiQJIqn98z6KN31KaS1OjElb+tNyIgdR 2HIRe+ybJ7otzUlfZRZZX+3WP0K9UNawx1SYc28vrZCuivGiUBGo+qnho7loxCe9OCBW 8aDPUdjLiIWqQU9kNB9PZaBoy1LUM09vgixvqEus5fmJjBt84LNi1DFvbl0HbwnFBzun xs5DWg/RQT5r7IftUnOcsIcVD2TNkrSbAy/4Uayjdta6rLp5CZLTbfjEl8w/S0xQv9Af NBounVlrYbjSekeVFzq7cWlqUhjXZiP1oQw7L9YddskKYQryZfMpgOhex2S3Ss13ZomI FoRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708687852; x=1709292652; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z8dfXQ2Z4W7w34/O/WJn9wy7d2/yI9c9bdvjZ7hBfrY=; b=X3KVWaaXQ1mjSs/vslAfe9eIVcMCuuF0BOm5x9fTTviWn1IHZrtsuc+KizmoI/wzdD MZjqlAb2hEhEtrE4dkRObLup7IBxU8cKE9yOsQIggi6Juj89DYDv/EhVAuOVsKtU1ee3 pGMwYAqj0d2y5XrwpeDquYIRMs8e18CVoqrq/ldLfQi48loXsvVXe/OtogaFS733j3/A 0aoMg51tHlEBUhXUQs7yUlKEI5DQebFEl6oCK8pgtanD9YvXzocd3rjBMA2UfsppRKZ1 Aw2x7rR1bSpMWEGGu9rnFZKN6p+g6mEjz5y7olBQx22L0iTyQ85RFoUgo6elx/T120TJ uZaQ== X-Gm-Message-State: AOJu0YwQ7oVHf7OnUOg1ktxmcwR7WRQ53oYIdqqBv+1wuTGYpEdib95+ I4zkw4Ww68ReGvUcKacasAFFpg3IvLP5WF2LPEmmdIdkKFE/ed77eIe3jeSmUiyhuEjz7QSUg8U = X-Google-Smtp-Source: AGHT+IEwv4PQOedj6d+mS/Ivbdgdk+fe9pj2gDOvRMb3P7nOi3hy23U6Qm9Qdc706K8wY86hNB9kXQ== X-Received: by 2002:a17:906:688f:b0:a3e:9df6:7f0a with SMTP id n15-20020a170906688f00b00a3e9df67f0amr1039462ejr.68.1708687852741; Fri, 23 Feb 2024 03:30:52 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id lu16-20020a170906fad000b00a3d5efc65e0sm5486296ejb.91.2024.02.23.03.30.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Feb 2024 03:30:52 -0800 (PST) Message-ID: Date: Fri, 23 Feb 2024 12:30:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [PATCH 6/6] gas/NEWS: drop mention of Arm64's SVE2.1 and SME2.1 Content-Language: en-US From: Jan Beulich To: Binutils Cc: Richard Earnshaw , Marcus Shawcroft , Nick Clifton References: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <2dbdd49f-2302-4dbc-98ba-0bdaf3c4cad2@suse.com> X-Spam-Status: No, score=-3025.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org ... plus the SME part of B16B16. As per https://sourceware.org/pipermail/binutils/2024-February/132408.html SVE2.1 support is both incomplete and buggy. SME2.1 "support" goes as far as a single instruction (a subset of movaz forms) only. The SME part of B16B16 is entirely missing. --- a/gas/NEWS +++ b/gas/NEWS @@ -4,11 +4,7 @@ Changes in 2.42: * Add support for AMD znver5 processor. -* Add support for the AArch64 Scalable Vector Extension version 2.1 (SVE2.1). - -* Add support for the AArch64 Scalable Matrix Extension version 2.1 (SME2.1). - -* Add support for the AArch64 BFloat16 to BFloat16 arithmetic for SVE2 and SME2 +* Add support for the AArch64 BFloat16 to BFloat16 arithmetic for SVE2 (B16B16). * Add support for the AArch64 Reliability, Availability and Serviceability