From patchwork Mon Feb 5 16:50:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Remus X-Patchwork-Id: 85314 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 516273858024 for ; Mon, 5 Feb 2024 16:50:34 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 13C233858D1E; Mon, 5 Feb 2024 16:50:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13C233858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 13C233858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707151815; cv=none; b=jtZQmgfAqgIiUoygWKZR2+XOTxzbH6sS29+ghiUE2mPfpsUkXFlJlHkflOZRhIFQZaHfNyw6lXeiv1iluMcxPz0nia2zpmdRbtOrW1ME8LAgCTo30lsVkv7delA4TQRHkZ1f/+tEflhb35umXcBeE8KwxeN+o14iMLEJlK47VPg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707151815; c=relaxed/simple; bh=9DlgGdx/UGFcQbmztWetiD3Yh3gP8FyM+tqjX91v498=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=n+ff2OcaNrZcEg86C572W8L8HUKi3rii/WFxSnujPdjJQIpo4zZVIOorDl8LqR1lQLye2TU9P3x7laf29iz5p1gVp9OS3wsS8fjTsIqMb/uFAi/G/HQqrZv3ZQ6QACJAM1grhCk+3lK4KorDoI6i0wElL9BbE0UM+gHnXEbQNTE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 415GbSMq015267; Mon, 5 Feb 2024 16:50:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : mime-version; s=pp1; bh=ssurATOEUPABrcgqSMB8oIqkjrYrkSDzpEkx/KmmF58=; b=OXuGt1hk6Cwy6szbDwXqGJ8YqN2Ftgm1l6NV4wLeJ+yna7irkkk9SEwfCHmLGKI6Udne HSsFvJqmnoUtkJmA1T/0ZfPLLp2axON2xgySFMf7snIxQD1Q4gU9iZQ88IGfvK0LNBzT fU4vvd74C93YtV2YJLz8yhzG46nUjcX3NLUy1VoObzhxgAJ/UCdOLXiakiyCUedB3TkX XFWSU7HHxaco9lVItfPHje9zemLXtqy1K5OXQvCcOAdh2aZPTeKltn0mipUHWLnXaOMi LwllB02y+2+bCL3yPYGqDxP8Ex6FVoAbTbs701YeX00mWvPZ1y0XmMJ/e1fBFHXNOUjM KQ== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3w33brrb6f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Feb 2024 16:50:11 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 415FU9be016184; Mon, 5 Feb 2024 16:50:11 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3w22h1s6nm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 05 Feb 2024 16:50:10 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 415Go7FG3146332 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 5 Feb 2024 16:50:07 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2FD332004B; Mon, 5 Feb 2024 16:50:07 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0C47320043; Mon, 5 Feb 2024 16:50:07 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 5 Feb 2024 16:50:06 +0000 (GMT) From: Jens Remus To: gdb-patches@sourceware.org, tromey@sourceware.org Cc: Jens Remus , Andreas Arnez Subject: [PATCH] [PR gdb/31328] gdb: Fix building with clang Date: Mon, 5 Feb 2024 17:50:05 +0100 Message-Id: <20240205165005.3861316-1-jremus@linux.ibm.com> X-Mailer: git-send-email 2.40.1 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: OuhQaZ-_mkHxsYcr84SbgZKsMlM4epN9 X-Proofpoint-ORIG-GUID: OuhQaZ-_mkHxsYcr84SbgZKsMlM4epN9 X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-05_11,2024-01-31_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=597 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1011 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402050128 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org This resolves the following clang++ error message: ../../gdb/symtab.c:4892:33: error: logical not is only applied to the left hand side of this comparison [-Werror,-Wlogical-not-parentheses] if (preg.has_value () && !preg->exec (sym->natural_name (), 0, ^ ../../gdb/symtab.c:4892:33: note: add parentheses after the '!' to evaluate the comparison first if (preg.has_value () && !preg->exec (sym->natural_name (), 0, ^ ( ../../gdb/symtab.c:4892:33: note: add parentheses around left hand side expression to silence this warning if (preg.has_value () && !preg->exec (sym->natural_name (), 0, ^ ( Bug: https://sourceware.org/PR31328 Signed-off-by: Jens Remus --- gdb/symtab.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/symtab.c b/gdb/symtab.c index 32b19e6c9023..02f5d4f1b3d1 100644 --- a/gdb/symtab.c +++ b/gdb/symtab.c @@ -4889,8 +4889,8 @@ global_symbol_searcher::add_matching_symbols if (!sym->matches (kind)) continue; - if (preg.has_value () && !preg->exec (sym->natural_name (), 0, - nullptr, 0) == 0) + if (preg.has_value () && preg->exec (sym->natural_name (), 0, + nullptr, 0) != 0) continue; if (((sym->domain () == VAR_DOMAIN