From patchwork Mon Feb 5 10:14:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YunQiang Su X-Patchwork-Id: 85299 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 686F83858422 for ; Mon, 5 Feb 2024 10:15:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 686F83858422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1707128135; bh=QQIZkZFWSUlA0Uubh6hgKTKlYWh2Zk0ajlXV7HlETV8=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=Dloq5JHe3y/VNdG7pnFD4K9bix8OF2QYeeMG+syNsZ7aY5UG+kzFKl1A353lugXmi TXXTQhEfcu0KWyWB84mhnj4f/6OhjKMDvR1pEJ7de2wXrWkZdnW0t411QT3UkjA/Ls iyoPCYH6ru7TXOdJFKqL53v4ZEJ1PhX7nmBNkqOk= X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by sourceware.org (Postfix) with ESMTPS id 8F1BE3858CDB for ; Mon, 5 Feb 2024 10:14:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F1BE3858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F1BE3858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707128090; cv=none; b=UCWIj5Px8xn3xhAIFR7MljBAgEcKYAhbhjXyk1ky18igc2sPNg0L0ATNgm0Ly9krz8YGIius+pxAyoOx1VWPftXekDQ+dB463tVbUIkxbPfjBDDZvLFtf0IqmvigoxgK3VgHqee5btQVRVcMMfssocN6seGS157z7224OBoJU1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707128090; c=relaxed/simple; bh=WhDJ/GRJ6vfnLABteDJGpU80w5EWTmBREFS7nTCcDhU=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=rmYUKtn0THQt8kSj0bBcB68t/AY3uWdouKYxINLn/RT5L1JRsi83zKcEO0YLJt+flg5eAEJ6gJO7W3E2zj0/7PBS3zrBTyWZ9DH3BuXyeX32bRZdJQa1C6Y3tSoCZeRDATlzoTVvVHqADk7jAim1fkf0AfVkSAJ+U8xo7gJb04g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d958e0d73dso22799355ad.1 for ; Mon, 05 Feb 2024 02:14:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707128087; x=1707732887; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QQIZkZFWSUlA0Uubh6hgKTKlYWh2Zk0ajlXV7HlETV8=; b=eQwJbUfYT84t8qGjzNqDwkiJNPr1HEQe6tMoYJRqSReZW0neYAbSyRNO4fhBurqHVX YjohWOQ+9Bj4rMvMhDVcj1OrTxM8D+fGPrFW+WMJLaR7Yz6Vzz8g6ibsMezmHHG3aG1T x8t6/bMU2fTv6zvhxagM125RRk0ZgWFUOS3rmCEiu2xxpe9O1c7TDfvuB2onuPiZA5W3 p70pDxaZO8oxXredb4KqEByVccBTMpHXnrNP1alT9q35b6iwJSQ47ZhIMz8KIy7km3V4 0pnmKvN/Mo5TqypFc8hNy7ZeoionAEn3RxX5eR7jnNaSftj5E8OsrlN9XS7j2Xk/nOYg 4cPQ== X-Gm-Message-State: AOJu0YwfalBDWP0V84pEsFzbPSj2xFirQPm0uCPG1hSQkex9tauWAzli +bN6XYyiEBp5jpiIPnlt7ftgehHpQcOHrRW1pMNSqRpbVc1WNkCM X-Google-Smtp-Source: AGHT+IFic2kNb/gpI1EyAe2fZJd8XruKLl3+Tqjo3j4YZafIdN3s2q4hcaqtFTlVs/iJz99CBSEJug== X-Received: by 2002:a17:903:18b:b0:1d5:8cbc:863c with SMTP id z11-20020a170903018b00b001d58cbc863cmr7095969plg.27.1707128087431; Mon, 05 Feb 2024 02:14:47 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVR42ltA+FoaJMESnIv721NXUwatH5tyhakB3QY00OhYbpbbb6uVT2Byn96UXajYYmSMNwaPxtDM9SvlY6SOOpOnGRFqockBF/h6/akad41DXJ8t7ax Received: from localhost.localdomain ([149.248.38.156]) by smtp.gmail.com with ESMTPSA id u11-20020a170903308b00b001d71a0b1109sm5957716plc.116.2024.02.05.02.14.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 02:14:47 -0800 (PST) From: YunQiang Su To: nickc@redhat.com Cc: binutils@sourceware.org, macro@orcam.me.uk, xry111@xry111.site Subject: [PATCH] MIPS/Gas: Support .L/$ as the mark of local symbol Date: Mon, 5 Feb 2024 18:14:27 +0800 Message-Id: <20240205101427.2862503-1-syq@gcc.gnu.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org In as.texi, there are lines: A local symbol is any symbol beginning with certain local label prefixes. By default, the local label prefix is @samp{.L} for ELF systems or @samp{L} for traditional a.out systems, but each target may have its own set of local label prefixes. Let's support it for MIPS: 1) For OldABI, GCC uses "$" to mark local symbols, and for NewABI, ".L" is used. So let's support both for OldABI, and ".L" only for NewABI. 2) Emit an fatal error, if a local symbol is used, while not defined, just like LLVM does. --- gas/config/tc-mips.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gas/config/tc-mips.c b/gas/config/tc-mips.c index 43c12de2c8a..a84b13e1815 100644 --- a/gas/config/tc-mips.c +++ b/gas/config/tc-mips.c @@ -17725,6 +17725,16 @@ pic_need_relax (symbolS *sym) if (symbol_section_p (sym)) return true; + if (strstr (S_GET_NAME (sym), ".L") == S_GET_NAME (sym) + || ((mips_abi == O64_ABI || mips_abi == O32_ABI) + && strstr (S_GET_NAME (sym), "$") == S_GET_NAME (sym))) + { + if (!S_IS_DEFINED (sym)) + as_fatal (_("undefined temporary symbol: %s"), + S_GET_NAME (sym)); + return true; + } + symsec = S_GET_SEGMENT (sym); /* This must duplicate the test in adjust_reloc_syms. */