From patchwork Sun Feb 4 19:15:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Tromey X-Patchwork-Id: 85287 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DE8DE385829B for ; Sun, 4 Feb 2024 19:16:30 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 7B7663858CDB for ; Sun, 4 Feb 2024 19:16:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B7663858CDB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B7663858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707074173; cv=none; b=qd+5hvSdPjKIvnYOU60l5d7MxoCiST582YwkKib4wr3It0ss+/rdkAnJcBFwPBidgB0zo4qb9kL0M10BI24lwYR5GghWZcPVbkQYbtnh0mQdZJEny8UiECaYwnM6mUrdFhS4GHEEjslKV3USpI35URD9bHPx4EmmoqdJrucjXVQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707074173; c=relaxed/simple; bh=Mqgl5/pD4HOmkxG2G5FAALN/sutbjxpc3+xV1QLjXXg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iYr0qD8/wJ4iRjgD4Q9HvBtPJzx4ZgtnO5b7JnKnsIikv8HkL1ks3J2rPm6G8pY9gVIJ5gQ+FD3D5i9o3UbrCt5xOonOFbxJEmysBWtQIzibMeY360aAV/k2woVhGPudhrnEEzw42PbBNoZyLuA9T8tFsE5Oh0Uv+Ylhag077+E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id WfnGrCyMVrh9zWhyLrCuDa; Sun, 04 Feb 2024 19:16:09 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id WhyKreNOfivBxWhyLrNrdx; Sun, 04 Feb 2024 19:16:09 +0000 X-Authority-Analysis: v=2.4 cv=YPU8ygGx c=1 sm=1 tr=0 ts=65bfe279 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=bBt94tZRei9QZQKGBqUA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=p5T+NohoYemMEPQ/OuyrbutLsa1sB8B3DuajwqNDp+g=; b=tULH3uNpU9jSiceyavgt1AX6DS aBprWfyqi6vOSPHnzW4yldOoLaUs09FO43xKXMlC0kHVnBbkUjULh23QPyoxgeDoiH9hiSUwmleQZ HepH5wRdTE6Kr4pN1urV6fjIy; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:44340 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rWhyK-000I5V-1g; Sun, 04 Feb 2024 12:16:08 -0700 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Avoid an allocation in attr_to_dynamic_prop Date: Sun, 4 Feb 2024 12:15:59 -0700 Message-ID: <20240204191559.4007457-1-tom@tromey.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rWhyK-000I5V-1g X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (localhost.localdomain) [97.122.68.157]:44340 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJdxxaviRWUb6GukB1jzBVRtHqjhHxHvWL2PzcgjaKCTkW1hI/hkkzqNW2bXId/SjfhtaVGH9i5npNpZPagURIJc5YfeDHgM4UE4bod3SeBndrQtr1AP SYuCUi8AEdVxE5KajTFBBh7UsrkOqk7sZptIyJ2qXWl4xgdgUtVkBYSZZEd6QHH/j0r+xjYz42TOsD0izMB8eJ4YfiivO0WGRY0= X-Spam-Status: No, score=-3022.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org I noticed that attr_to_dynamic_prop allocates a dwarf_block, when no allocation is required. This patch stack-allocates the object instead. Reviewed-By: Tom de Vries --- gdb/dwarf2/read.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index e873d9cc440..34bbb6e804d 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -15385,24 +15385,23 @@ attr_to_dynamic_prop (const struct attribute *attr, struct die_info *die, baton->locexpr.per_cu = cu->per_cu; baton->locexpr.per_objfile = per_objfile; - struct dwarf_block *block; + struct dwarf_block block; if (attr->form == DW_FORM_data16) { size_t data_size = 16; - block = XOBNEW (obstack, struct dwarf_block); - block->size = (data_size - + 2 /* Extra bytes for DW_OP and arg. */); - gdb_byte *data = XOBNEWVEC (obstack, gdb_byte, block->size); + block.size = (data_size + + 2 /* Extra bytes for DW_OP and arg. */); + gdb_byte *data = XOBNEWVEC (obstack, gdb_byte, block.size); data[0] = DW_OP_implicit_value; data[1] = data_size; memcpy (&data[2], attr->as_block ()->data, data_size); - block->data = data; + block.data = data; } else - block = attr->as_block (); + block = *attr->as_block (); - baton->locexpr.size = block->size; - baton->locexpr.data = block->data; + baton->locexpr.size = block.size; + baton->locexpr.data = block.data; switch (attr->name) { case DW_AT_string_length: