From patchwork Thu Jan 18 08:13:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Jelinek X-Patchwork-Id: 84326 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B8EBB3858430 for ; Thu, 18 Jan 2024 08:17:08 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B10273858C42 for ; Thu, 18 Jan 2024 08:16:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B10273858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B10273858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705565774; cv=none; b=hEsHyENXlmwao+Qz/ApiEOQoSOSgWWPOPIeR/3smp0/SUBpWvfPJW61o9C2vhOOlaQw3x9XNwKKtgXv8qOBNGEUcXE822hIJxLGBfle2gBketI3nGMvbjInFd3aC1rtSse5tgYj8SD3uZXOhRmWipOB6ZNqPQGZQX8/b6ZqUyps= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705565774; c=relaxed/simple; bh=xpouhY0B3fhdE/0tJMKXw2JW1TyelA9LskSjhZR7dEA=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=JT3M/Sbn69LqTur+H79DlxCmEFC3OEJeItA4t9irdUXvMt6+zJ266z77m2C0qM1HmBXE7sdMfypcsn6Qa642qLaweAIJxH9HcSp6F5U6gLKd+T5W6Ut/AcXhDVi2+y614XpP5ohFeqFVYIxhgCG2QaoOfRljbk37BAL5adxzb7g= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705565767; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type; bh=nNvfzrlpgfAmuf/H0y++pJVY4g38PNm1GUMLoSqC02c=; b=iGKxeLuKin+83nMmddy0jwD5B3LZ7r9ZDLr4g4f3rle1A5j4Kv8yaK/cUamu6evtILaRMP tqlV+iPLv/5tuvwLk3IoAQ91TmPYo8IwS/dcLQsjNCipOHnrb4lPgXnT25DwktBIwtEAy9 Zvb2ECL3LDlo1oTg9qn7O0kaJJXzo3A= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-73Nx1fGTNCStcvlxpownSA-1; Thu, 18 Jan 2024 03:13:56 -0500 X-MC-Unique: 73Nx1fGTNCStcvlxpownSA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 59E55383CCE2; Thu, 18 Jan 2024 08:13:56 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.70]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F3AAF2028CD4; Thu, 18 Jan 2024 08:13:55 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 40I8DqXu238125 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 18 Jan 2024 09:13:53 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 40I8DpMp238124; Thu, 18 Jan 2024 09:13:51 +0100 Date: Thu, 18 Jan 2024 09:13:51 +0100 From: Jakub Jelinek To: Kito Cheng , Palmer Dabbelt , Andrew Waterman , Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: [PATCH] riscv: Remove Bool keywords from riscv.opt Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Jakub Jelinek Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Hi! As I wrote recently, Bool is an undocumented unsupported keyword, as can be seen by grep Bool doc/options.texi *.awk The option parsing just parses and ignores all keywords it doesn't handle. But, because it isn't a supported keyword, I think we shouldn't have it in *.opt files, because that just means people copy it over to other places even when it doesn't have any effect. Tested with a cross to riscv64-linux, none of the generated options.{h,cc} options-{save,urls}.cc files change with the patch, only optionlist does (but that is just used as a source for those files). Ok for trunk? 2024-01-18 Jakub Jelinek * config/riscv/riscv.opt (mshorten-memrefs, mrelax, mcsr-check, minline-strcmp, minline-strncmp, minline-strlen, -param=riscv-vector-abi): Remove Bool keywords. Jakub --- gcc/config/riscv/riscv.opt.jj 2024-01-18 08:44:33.441919890 +0100 +++ gcc/config/riscv/riscv.opt 2024-01-18 08:58:22.788359898 +0100 @@ -103,7 +103,7 @@ Target Mask(SAVE_RESTORE) Use smaller but slower prologue and epilogue code. mshorten-memrefs -Target Bool Var(riscv_mshorten_memrefs) Init(1) +Target Var(riscv_mshorten_memrefs) Init(1) Convert BASE + LARGE_OFFSET addresses to NEW_BASE + SMALL_OFFSET to allow more memory accesses to be generated as compressed instructions. Currently targets 32-bit integer load/stores. @@ -134,12 +134,12 @@ Target Mask(EXPLICIT_RELOCS) Use %reloc() operators, rather than assembly macros, to load addresses. mrelax -Target Bool Var(riscv_mrelax) Init(1) +Target Var(riscv_mrelax) Init(1) Take advantage of linker relaxations to reduce the number of instructions required to materialize symbol addresses. mcsr-check -Target Bool Var(riscv_mcsr_check) Init(0) +Target Var(riscv_mcsr_check) Init(0) Enable the CSR checking for the ISA-dependent CRS and the read-only CSR. The ISA-dependent CSR are only valid when the specific ISA is set. The read-only CSR can not be written by the CSR instructions. @@ -483,15 +483,15 @@ Target Var(TARGET_INLINE_SUBWORD_ATOMIC) Always inline subword atomic operations. minline-strcmp -Target Bool Var(riscv_inline_strcmp) Init(0) +Target Var(riscv_inline_strcmp) Init(0) Inline strcmp calls if possible. minline-strncmp -Target Bool Var(riscv_inline_strncmp) Init(0) +Target Var(riscv_inline_strncmp) Init(0) Inline strncmp calls if possible. minline-strlen -Target Bool Var(riscv_inline_strlen) Init(0) +Target Var(riscv_inline_strlen) Init(0) Inline strlen calls if possible. -param=riscv-strcmp-inline-limit= @@ -542,7 +542,7 @@ madjust-lmul-cost Target Var(TARGET_ADJUST_LMUL_COST) Init(0) -param=riscv-vector-abi -Target Undocumented Bool Var(riscv_vector_abi) Init(0) +Target Undocumented Var(riscv_vector_abi) Init(0) Enable the use of vector registers for function arguments and return value. This is an experimental switch and may be subject to change in the future.