From patchwork Mon Jan 15 09:50:03 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 84087 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2919E3857C4A for ; Mon, 15 Jan 2024 09:50:53 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.160]) by sourceware.org (Postfix) with ESMTPS id 558C43858C42; Mon, 15 Jan 2024 09:50:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 558C43858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gjlay.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=gjlay.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 558C43858C42 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=81.169.146.160 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705312212; cv=pass; b=F/weJZj6P/XMPMJ029hWgmPTR6MVRIb+JDllMSqkQDwKrg+2rMggaMBJ0xw2gxiVLmrWgb9znNMT/aQpM1uZKDtNM3sTEr6Tm8WXzPGddcIZirNdTGbchYMACR3NDaA3zjhGlVCYnvCuOxPkTfaklsNY/3CMdBD4wrZ8foNNTnA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1705312212; c=relaxed/simple; bh=Hn44efRxu8hcA0Wzzw2GIDeoiSGNC4wQiGTmvgK0LNk=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=jXv4EEnnqm7RSd13CPS+E1z+ZnkVM0SO+JTDvv1HvE5Nrt7vlWEqN9J7aZNCCnYANKFlQcgb8o/VX53at8IY7Y0KczL9WIpNsPzpI+Jti+QmIjHTfwJQey+PeWGk/cTjl2p73DxPHWKG178jjK8vUwEzjXzcFG4nskadQtqEo4U= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; t=1705312204; cv=none; d=strato.com; s=strato-dkim-0002; b=VFxPeeOXnIJttdkHZRqSpXJsnE5xJj8SbuyfLCAltgYgBJ9O7+iNPLus9F4Eh0sOad QBsVkbIGOGU99RpzqD9+yKOt+DaPEvL67EyxM2lBRtIT9myr7DymQwQ5yOY/anRx6viU r5FZzf5lkiMKfk9NtUJFrTylGvulI9CbHG0IUuA8F39/pMWmnmOJPEqtNQXc7lU3wrjw uuvjM9dTeqPEltgTT8RGoi9raJYjcsT8u3Tww437ZaSaVEmyG4P6F31G1PJJWcAD7WPg vNG6TZ58CEEVYOmfJb6DS2TWsWAByEZbMEHhDvdlGnl2u2HeZga1MGFJXHfbvNYX1lB8 KGiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1705312204; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:Cc:From:References:To:Subject:Date:Message-ID:Cc:Date: From:Subject:Sender; bh=6XM5jkpDYV0UvR9V8RuHV5LJ2v7cf3qoqBjB+lvT6lA=; b=XOAtYdpFne9Q2S4RUSLapcbM1aPvtJxtsTNKWVz2KUqyUrIzal/yKGOgsvimYz4sKK fywk5WL/gplFpaXx3n9YDh0fFCqZYWpgOc6iVPIqt7LQVasvS3DFsH7sHLth8RHtdj4/ fiZt1j6JKEAhx/J6MpO02c5R/j71jJik/bf5UUsiX2DBihtmvQ7mjdKmdxhyl6DoGrlb jSZDSvOxwctE4AA8Ce7zRhd36Tv3/PYbLatl7DfJV1TgwcWrQ5fzDBT8vCGmjNZpaZUW VtpHXnQ3WwQp/pj7sOJ5DTMsjdPyEyvOkLyXwjGmPfBsbqTXbgU/SRj2/6ouC2W3udWc Lnfw== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1705312204; s=strato-dkim-0002; d=gjlay.de; h=In-Reply-To:Cc:From:References:To:Subject:Date:Message-ID:Cc:Date: From:Subject:Sender; bh=6XM5jkpDYV0UvR9V8RuHV5LJ2v7cf3qoqBjB+lvT6lA=; b=cPRkkJ7j9WKsFXr/aYOI4W+zjuctcOYEPjHzzKu24px+lz4pMvYwfx/aLZ6Draij37 Eb3MNEkmDZU4u2219SzF61k9lMavkmu6nCNr0wOec/m/fSpnymOSznONqcUL+PttPsKK +EjbhOCkEE3/3xqdVVL5NWFPtAJErao9p0WSsex0tzDtXk5kPKODRlswHqU3caRBQC7J Cgrv96ugWioDo2EHcLANx8PDXbGZjq3HIqKsL9sFq7jyUswHSngKq+RMY+jSxQih6xO5 8I/+ldHeVIbE2YyrCWmEPvL/S1Kvgh8tdO5zS53atL/Tj3aGVR8Fjifw6K1IpwRpkI+f bGyw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1705312204; s=strato-dkim-0003; d=gjlay.de; h=In-Reply-To:Cc:From:References:To:Subject:Date:Message-ID:Cc:Date: From:Subject:Sender; bh=6XM5jkpDYV0UvR9V8RuHV5LJ2v7cf3qoqBjB+lvT6lA=; b=IXCbVP6xoXxmS5vdsi9zw3dt9jTNu9NSXbq52Tod3B6abW4HRee1SWN3djnFW6m8oD q6T/BHafw9dqgFiha5BA== X-RZG-AUTH: ":LXoWVUeid/7A29J/hMvvT3koxZnKT7Qq0xotTetVnKkSjsSjq3WhKPVxx3mY" Received: from [192.168.2.102] by smtp.strato.de (RZmta 49.10.2 DYNA|AUTH) with ESMTPSA id g5de8600F9o4YRn (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Mon, 15 Jan 2024 10:50:04 +0100 (CET) Message-ID: Date: Mon, 15 Jan 2024 10:50:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [patch,avr,applied] Fix PR target/113156 - ICE when building libgcc Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <967ecf57-2f9a-4a1b-88e2-1f0e57483a39@gmail.com> From: Georg-Johann Lay Cc: Andrew Pinski , Levente , gcc-help@gcc.gnu.org In-Reply-To: <967ecf57-2f9a-4a1b-88e2-1f0e57483a39@gmail.com> X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org I went ahead and installed Andrew's patch https://gcc.gnu.org/r14-7240 Johann Am 15.01.24 um 00:19 schrieb Levente via Gcc-help: > I'm trying to set up a toolchain for avr-dd MCUs, and I get this error > message when I try to compile gcc: > Lev --- Author: Andrew Pinski Date: Mon Jan 15 10:31:36 2024 +0100 AVR: target/113156 - Fix ICE due to missing "Save" on -m[long-]double= options. Multilib options -mdouble= and -mlong-double= are not orthogonal: TARGET_HANDLE_OPTION = avr-common.cc::avr_handle_option() sets them such that sizeof(double) <= sizeof(long double) is always true. gcc/ PR target/113156 * config/avr/avr.opt (-mdouble, -mlong-double): Add "Save" flag. (-mbranch-cost): Set "Optimization" flag. mn-flash= @@ -61,7 +61,7 @@ Target RejectNegative Mask(NO_INTERRUPTS) Change the stack pointer without disabling interrupts. mbranch-cost= -Target Joined RejectNegative UInteger Var(avr_branch_cost) Init(0) +Target Joined RejectNegative UInteger Var(avr_branch_cost) Init(0) Optimization Set the branch costs for conditional branch instructions. Reasonable values are small, non-negative integers. The default branch cost is 0. mmain-is-OS_task @@ -124,11 +124,11 @@ Target Mask(ABSDATA) Assume that all data in static storage can be accessed by LDS / STS. This option is only useful for reduced Tiny devices. mdouble= -Target Joined RejectNegative Var(avr_double) Init(0) Enum(avr_bits_e) +Target Joined RejectNegative Var(avr_double) Init(0) Enum(avr_bits_e) Save -mdouble= Use bits wide double type. mlong-double= -Target Joined RejectNegative Var(avr_long_double) Init(0) Enum(avr_bits_e) +Target Joined RejectNegative Var(avr_long_double) Init(0) Enum(avr_bits_e) Save -mlong-double= Use bits wide long double type. nodevicelib diff --git a/gcc/config/avr/avr.opt b/gcc/config/avr/avr.opt index ee0b40603f0..c9f2b4d2fe5 100644 --- a/gcc/config/avr/avr.opt +++ b/gcc/config/avr/avr.opt @@ -27,7 +27,7 @@ Target RejectNegative Joined Var(avr_mmcu) MissingArgError(missing device or arc -mmcu=MCU Select the target MCU. mgas-isr-prologues -Target Var(avr_gasisr_prologues) UInteger Init(0) Optimization +Target Var(avr_gasisr_prologues) UInteger Init(0) Optimization Allow usage of __gcc_isr pseudo instructions in ISR prologues and epilogues.