From patchwork Wed Jan 10 14:25:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 83750 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 40D10385DC2F for ; Wed, 10 Jan 2024 14:32:27 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id CA0B33857BA3 for ; Wed, 10 Jan 2024 14:30:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA0B33857BA3 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CA0B33857BA3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704897062; cv=none; b=u9xcr6UiDSItrJTGZqGBZkjzfoSKRK9NuMI1ThLoOgcKH/A+IfWTzq7IRIskR59rwNJuArzUDklbEi8Mz+4l3Zjl01WN0aypbY3CkmX1DoQPmI7Q8nczF/vf6eYWTUNNzPdcrF5cX9dTyNkFH1OBz/4CdcIgRYtmDiHE4zzp8Qc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704897062; c=relaxed/simple; bh=HO0MASytG9Aid6ipFquZkp5L4XhD/v3AJWZJz2y30kU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=Mf1BeKa3uYXTWoPFLCPIhORkIJYdYHPfyb/ntM9GaQJCakfgP9jx+GavjnTS95hDQsviZ3pwg1gGOoW8KcCQRDOxXrTZ6bq/sh4g7/9bEMAMzYhv/yapfHvSZABW3bMATLThl51lS4MM482dZP8AuBdWKOuQkrSjviuTzGjxKeM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C83B61F8C1 for ; Wed, 10 Jan 2024 14:30:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704897057; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=HFWQLHwAakm7j5Hd8SrYGV1CwlY3EG/LQdPrQ8SN3nQ=; b=dYaiDGc2hSpb3T6lBwHPmeHbXQOmCyojtjkXJnxvHG5PBFffaUb4IuUfP+CsfgYUxPkcbU jdkI694p1CgbzqMLGtMPo9E8Hme7B/I/ociem/cU8n3go/HZYnKHQswWIZOElCo2oV+jWu M/kYz8CtiFEFCYxq28TGpK0IVFsszU0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704897057; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=HFWQLHwAakm7j5Hd8SrYGV1CwlY3EG/LQdPrQ8SN3nQ=; b=1cMqdi/bA8Aqr1kSCIVCxw6ScZcE6RInxmbIC2AKgy7apvsq/MEMXEdkTI1klglPxTpTzq uFMK3zPZekxrFtAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1704897057; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=HFWQLHwAakm7j5Hd8SrYGV1CwlY3EG/LQdPrQ8SN3nQ=; b=dYaiDGc2hSpb3T6lBwHPmeHbXQOmCyojtjkXJnxvHG5PBFffaUb4IuUfP+CsfgYUxPkcbU jdkI694p1CgbzqMLGtMPo9E8Hme7B/I/ociem/cU8n3go/HZYnKHQswWIZOElCo2oV+jWu M/kYz8CtiFEFCYxq28TGpK0IVFsszU0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1704897057; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=HFWQLHwAakm7j5Hd8SrYGV1CwlY3EG/LQdPrQ8SN3nQ=; b=1cMqdi/bA8Aqr1kSCIVCxw6ScZcE6RInxmbIC2AKgy7apvsq/MEMXEdkTI1klglPxTpTzq uFMK3zPZekxrFtAQ== Date: Wed, 10 Jan 2024 15:25:57 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/112740 - vector boolean CTOR expansion issue MIME-Version: 1.0 X-Spamd-Result: default: False [4.34 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_SPAM_SHORT(1.95)[0.649]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-0.01)[49.89%] X-Spam-Score: 4.34 Authentication-Results: smtp-out2.suse.de; none X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Message-Id: <20240110143227.40D10385DC2F@sourceware.org> The optimization to expand uniform boolean vectors by sign-extension works only for dense masks but it failed to check that. Bootstrap and regtest running on x86_64-unknown-linux-gnu, I've checked aarch64 RTL expansion for the testcase. Will push tomorrow. Richard. PR middle-end/112740 * expr.cc (store_constructor): Check the integer vector mask has a single bit per element before using sign-extension to expand an uniform vector. * gcc.dg/pr112740.c: New testcase. --- gcc/expr.cc | 8 +++++--- gcc/testsuite/gcc.dg/pr112740.c | 19 +++++++++++++++++++ 2 files changed, 24 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/pr112740.c diff --git a/gcc/expr.cc b/gcc/expr.cc index dc816bc20fa..0bf80832fe5 100644 --- a/gcc/expr.cc +++ b/gcc/expr.cc @@ -7841,10 +7841,12 @@ store_constructor (tree exp, rtx target, int cleared, poly_int64 size, break; } /* Use sign-extension for uniform boolean vectors with - integer modes. Effectively "vec_duplicate" for bitmasks. */ - if (!TREE_SIDE_EFFECTS (exp) + integer modes and single-bit mask entries. + Effectively "vec_duplicate" for bitmasks. */ + if (elt_size == 1 + && !TREE_SIDE_EFFECTS (exp) && VECTOR_BOOLEAN_TYPE_P (type) - && SCALAR_INT_MODE_P (mode) + && SCALAR_INT_MODE_P (TYPE_MODE (type)) && (elt = uniform_vector_p (exp)) && !VECTOR_TYPE_P (TREE_TYPE (elt))) { diff --git a/gcc/testsuite/gcc.dg/pr112740.c b/gcc/testsuite/gcc.dg/pr112740.c new file mode 100644 index 00000000000..8250cafd2ff --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr112740.c @@ -0,0 +1,19 @@ +/* { dg-do run { target { int128 } } } */ +/* { dg-options "" } */ + +typedef unsigned __int128 __attribute__((__vector_size__ (16))) V; + +V +foo (unsigned c, V v) +{ + return (V) (c <= v) == 0; +} + +int +main (void) +{ + V x = foo (0, (V) { }); + if (x[0]) + __builtin_abort (); + return 0; +}