From patchwork Fri Jan 5 09:05:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 83384 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB0F63857BBD for ; Fri, 5 Jan 2024 09:06:43 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id E98A13858284 for ; Fri, 5 Jan 2024 09:05:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E98A13858284 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E98A13858284 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704445517; cv=none; b=xNxlEKmVMt5WP+RZ+904LbhAGnZZMuaqrdPqrSs9DWopUxyHfIW/za7qigWYbd0eqOxt6snbyuCt44UUjwQGgm8Nn5YZR1rK2XK4n0P70VB22u50pHJhLjtEaIyAFSfefWyC32NXu8Nt1oYe/RjNAzpWG3JZ3sZYEhFZKY9MW70= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704445517; c=relaxed/simple; bh=PD813OZLavCjWKvAt4QBLg2Je64smzH64tPGmUdHuhU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=T6BNyj3/5rHCpVbuw3cSiqlQo883BDII9vbJww3nrludaf9lcj3Ac/RRqadObAi87T4o1SVf2UDmYLjujMRIHFCFKItKdbCwjGAGphQbwoOK3OSXThcOTYckXiZW7i2NdptTaTi9G4faHZdVRZ4aGFZJhzUWaWXBj81k7Kb88U8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2cd0d05838fso15734431fa.1 for ; Fri, 05 Jan 2024 01:05:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704445507; x=1705050307; darn=sourceware.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=3chOylx5tKquEKhTVYxWqLXH7HUlS9x/N79yW9rUgpE=; b=Bi6N5aIqJjrEPv0VSiPEtsN1n+2cODipcVjRdht+izem8bJ9aAfIttLUgJbcD7OsoE gXTXB7vmaWMB8RY4Nbu9bzCVbkf69zgwK2SUA4N2aUPS8JIxCIWD5tO299Qt7El0nQrt /riG5tdcCYhuXwKcHmS6VRLnbn/oTeDclPY2ZPA4Z8pBD/S3VuECspAgX+Yh7M+MZMkz EaRktUNnn3OZjRsKmUpQPgWa+KWYQK7WTx0HUX2E4euj1Bi90vt1S1jMa0KqospYRUTP uLXWIETiFmODXr1tJvzUHQH1/pcYf4maQg684FXVzAtVPaBxdcZQhZIOpM3Zgu7roU3/ 6tgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704445507; x=1705050307; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3chOylx5tKquEKhTVYxWqLXH7HUlS9x/N79yW9rUgpE=; b=QqFFWcZxNmWUoZjgJQn6a7ZCeDV8UiDJdSbMpfwkDma9JsHkAff9V07F8KXjq/kSs/ usr69a0F2DUpIUBkLai2zQux0s5DIfRPSxoqfDkqwhMO+yoQamh0vfZSLX/a6UyGARYA Da6xtkXNS3boBPEKqCsKjitPn59j8QT+QCyvvtjs6cjHJbt2/7mLJ6bvALn6nEJjj5hW QLrcnXM81oREnu/zmBwu+ywB5ywwmv5I9LdndMWeSyN+c5r6SezeFKGMN/VepmHsDtGt hShnNr4ivE9pMFKkt8DSOszXdv622VHNtAMUkccefZuuwFg8f2r+6t6MI3Rs75k5kkSx /kCA== X-Gm-Message-State: AOJu0Yy37M48JBLIlI6a11fcuoFBOPitWLpDClI1q3GwHGI3F5wtMIZi T/k0/T9rGmQx7jvhGmxodnCxvFPV8f/f7EDrhFNuaqRNXQ== X-Google-Smtp-Source: AGHT+IFo11IP99RpchZJgRibiRXnYjyvFyw2uLPNNRcb8Ya9qQVFqV7EHPVyWZ2FW9l2+plHevwY3Q== X-Received: by 2002:a2e:3518:0:b0:2cd:dfe:74ae with SMTP id z24-20020a2e3518000000b002cd0dfe74aemr878700ljz.52.1704445507210; Fri, 05 Jan 2024 01:05:07 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id cn5-20020a0566383a0500b0046926891d83sm318883jab.103.2024.01.05.01.05.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 01:05:06 -0800 (PST) Message-ID: Date: Fri, 5 Jan 2024 10:05:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Binutils Cc: "H.J. Lu" From: Jan Beulich Subject: [PATCH] x86: FMA insns aren't eligible to VEX2 encoding Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org PR gas/31178 In da0784f961d8 ("x86: fold FMA VEX and EVEX templates") I overlooked that C aliases StaticRounding, and hence build_vex_prefix() now needs to be aware of that aliasing. Disambiguation is easy, as StaticRounding is only ever used together with SAE (hence why the overlaying works in the first place). --- a/gas/config/tc-i386.c +++ b/gas/config/tc-i386.c @@ -3802,6 +3802,8 @@ build_vex_prefix (const insn_template *t && i.reg_operands == i.operands - i.imm_operands && i.tm.opcode_modifier.vex && i.tm.opcode_modifier.commutative + /* .commutative aliases .staticrounding; disambiguate. */ + && !i.tm.opcode_modifier.sae && (i.tm.opcode_modifier.sse2avx || (optimize > 1 && !i.no_optimize)) && i.rex == REX_B --- a/gas/testsuite/gas/i386/x86-64-optimize-2.d +++ b/gas/testsuite/gas/i386/x86-64-optimize-2.d @@ -222,4 +222,5 @@ Disassembly of section .text: +[a-f0-9]+: 66 .* pxor %xmm12,%xmm12 +[a-f0-9]+: c5 .* vpxor %xmm2,%xmm2,%xmm8 +[a-f0-9]+: c5 .* vpxor %ymm0,%ymm0,%ymm1 + +[a-f0-9]+: c4 .* vfnmadd231sd %xmm9,%xmm2,%xmm0 #pass --- a/gas/testsuite/gas/i386/x86-64-optimize-2.s +++ b/gas/testsuite/gas/i386/x86-64-optimize-2.s @@ -248,3 +248,6 @@ _start: pcmpgtq %xmm12, %xmm12 vpcmpgtq %xmm2, %xmm2, %xmm8 vpcmpgtq %ymm12, %ymm12, %ymm1 + + # PR gas/31178 + vfnmadd231sd %xmm9, %xmm2, %xmm0 --- a/gas/testsuite/gas/i386/x86-64-optimize-2a.d +++ b/gas/testsuite/gas/i386/x86-64-optimize-2a.d @@ -223,4 +223,5 @@ Disassembly of section .text: +[a-f0-9]+: 66 .* pxor %xmm12,%xmm12 +[a-f0-9]+: c5 .* vpxor %xmm2,%xmm2,%xmm8 +[a-f0-9]+: c5 .* vpxor %ymm0,%ymm0,%ymm1 + +[a-f0-9]+: c4 .* vfnmadd231sd %xmm9,%xmm2,%xmm0 #pass --- a/gas/testsuite/gas/i386/x86-64-optimize-2b.d +++ b/gas/testsuite/gas/i386/x86-64-optimize-2b.d @@ -222,4 +222,5 @@ Disassembly of section .text: +[a-f0-9]+: 66 .* pxor %xmm12,%xmm12 +[a-f0-9]+: c5 .* vpxor %xmm2,%xmm2,%xmm8 +[a-f0-9]+: c5 .* vpxor %ymm0,%ymm0,%ymm1 + +[a-f0-9]+: c4 .* vfnmadd231sd %xmm9,%xmm2,%xmm0 #pass --- a/gas/testsuite/gas/i386/x86-64-optimize-2c.d +++ b/gas/testsuite/gas/i386/x86-64-optimize-2c.d @@ -223,4 +223,5 @@ Disassembly of section .text: +[a-f0-9]+: c5 .* vpxor %xmm0,%xmm0,%xmm12 +[a-f0-9]+: c5 .* vpxor %xmm2,%xmm2,%xmm8 +[a-f0-9]+: c5 .* vpxor %ymm0,%ymm0,%ymm1 + +[a-f0-9]+: c4 .* vfnmadd231sd %xmm9,%xmm2,%xmm0 #pass --- a/gas/testsuite/gas/i386/x86-64-optimize-5.d +++ b/gas/testsuite/gas/i386/x86-64-optimize-5.d @@ -222,6 +222,7 @@ Disassembly of section .text: +[a-f0-9]+: 66 .* pxor %xmm12,%xmm12 +[a-f0-9]+: c5 .* vpxor %xmm2,%xmm2,%xmm8 +[a-f0-9]+: c5 .* vpxor %ymm0,%ymm0,%ymm1 + +[a-f0-9]+: c4 .* vfnmadd231sd %xmm9,%xmm2,%xmm0 +[a-f0-9]+: 62 f1 f5 08 55 e9 \{evex\} vandnpd %xmm1,%xmm1,%xmm5 +[a-f0-9]+: 62 f1 f5 08 55 e9 \{evex\} vandnpd %xmm1,%xmm1,%xmm5 +[a-f0-9]+: 62 f1 7d 28 6f d1 vmovdqa32 %ymm1,%ymm2 --- a/gas/testsuite/gas/i386/x86-64-optimize-6.d +++ b/gas/testsuite/gas/i386/x86-64-optimize-6.d @@ -222,6 +222,7 @@ Disassembly of section .text: +[a-f0-9]+: 66 .* pxor %xmm12,%xmm12 +[a-f0-9]+: c5 .* vpxor %xmm2,%xmm2,%xmm8 +[a-f0-9]+: c5 .* vpxor %ymm0,%ymm0,%ymm1 + +[a-f0-9]+: c4 .* vfnmadd231sd %xmm9,%xmm2,%xmm0 +[a-f0-9]+: 62 f1 f5 08 55 e9 \{evex\} vandnpd %xmm1,%xmm1,%xmm5 +[a-f0-9]+: 62 f1 f5 08 55 e9 \{evex\} vandnpd %xmm1,%xmm1,%xmm5 +[a-f0-9]+: 62 f1 7d 28 6f d1 vmovdqa32 %ymm1,%ymm2