From patchwork Fri Jan 5 08:31:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 83379 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3D28A385829D for ; Fri, 5 Jan 2024 08:33:04 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id 08DE73858015 for ; Fri, 5 Jan 2024 08:31:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08DE73858015 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 08DE73858015 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::22f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704443490; cv=none; b=CoyOtxJWCbqrWP4Ibj7ogLXr8JxXCoOO1lSqmzj7FaA5ILiiNrUk+xh/7/+b1dnpjpKYxXXv374GxZrp+kSNlwGz4o9SIaHbAwlTqfr22gXMKD2Ai/Bvs8SOaQ0loSfboaAQSoxrQFxxJ3oZxbsEyBb9nSzKLJNQHZMkrzr1E8M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704443490; c=relaxed/simple; bh=yOi+2pjBV0gWb0bEnAWC7Pc5HktkxaA5HLXfKoYudXY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=pupEXGjUGo2f8pylkPp1nmC3O8k5IR29ALI06FpXPRsnOH31nJD/BcR2SanCUCn+SOsZmj7GsfT58Nj4Cazf+67e4BHBsapa8abD5zNmzPjYzi/aGRA/YKer4ig28CZCXzlSO/V04CyF/9tcm3LG7iW37gCnEpBu9kObr5S+01c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2ccae380df2so15443641fa.1 for ; Fri, 05 Jan 2024 00:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704443484; x=1705048284; darn=sourceware.org; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=hmR2aGoSBZgH8+uEvVXhAVq4xLfarm2/zsTOx9FQZXc=; b=aIeqYpPeE41w+N8hHiulOZQ5u96r6xn4Dbo/BM/l+E7uwZTwNKDAOwY2qG5RZ1tVsh 866cqogcYlIMWI7DagTtz4Xau0h9EnVd4gt5961i11VmSCnckg0v76BNpn5H5ueMQTAR YcZeuhY0AMzYB7+i1jwViTSjGUlDUcdBUI3VZlvMrzZkYEg9mRChy76qeZyu6MsFVL0j Pm7FUSioolqK6l2fi0+X3JzrN1ijCOdfvLwkSeRY8KcLpIaP6LNCXME5qaLnPn10HFLj rZZ8+UCQ97pO3CNkAazZ9cAIOCem5kcfZywBiT/MZHP/VQSVaJtaxcFy8lu2oncVAn69 BCiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704443484; x=1705048284; h=content-transfer-encoding:autocrypt:subject:from:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hmR2aGoSBZgH8+uEvVXhAVq4xLfarm2/zsTOx9FQZXc=; b=DJT/fegS8lCSDR5CBUE/Wifb6FQlurQuKJawycw3Eo/r1jpWndgc5+R5H8lBV2zdRn PCbo+x1FqnHjFhaSsLqgaOGGOj9JOannbpTv+bz69CwgY6LCMJkdTqYZlf1ODr6foz6I 9i9TkZkExhCxAsQy6muLOHN9e28LFWng2ALQBsc2dKVspUeK0uBfHLvR9j8JdR4BDJ/9 KX5PvuuDa+hiPv/xoRC4T7NoTiWER7dbjrhyM2gh90MQHkGUNlX0YqNqNM1xR67FAiCj SdVDZ2q9ac32bAn7ObPjpnrZDjdt5h72RwgVSLbkDPMfHzJLrizJLVKBue7qYMNnOQVd 59Tw== X-Gm-Message-State: AOJu0Yyhp2USp2csVbarmEqogfYWPf3AhQlllfXxO2wySzpV1yb0K7km BoTBb3095EzU4zTFkCi/S6tuaZurvjIzZQLtSUr6Ccu44Q== X-Google-Smtp-Source: AGHT+IGFxiCmXx9MCFEMgsWzeGyVImtsD/QpObo77tjx+qmhxpUpSfwBhzkeGFueMvZUENWnjGT+2g== X-Received: by 2002:a2e:9916:0:b0:2cc:6dde:b9be with SMTP id v22-20020a2e9916000000b002cc6ddeb9bemr863341lji.18.1704443484525; Fri, 05 Jan 2024 00:31:24 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id h20-20020a05660224d400b0077a1b6f73b9sm303481ioe.41.2024.01.05.00.31.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 00:31:24 -0800 (PST) Message-ID: Date: Fri, 5 Jan 2024 09:31:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Binutils Cc: Alan Modra , Peter Bergner , Geoff Keating From: Jan Beulich Subject: [PATCH] PPC64/ELF: adjust comment wrt ABI versions Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org While having been moved a couple of times since its introduction in f6c7c3e8b742 ("Referencing a function's address on PowerPC64 ELFv2"), the wording has always remained the same. In particular ELFv1 and ELFv2 have always been the wrong way round. --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -4498,7 +4498,7 @@ ppc64_elf_before_check_relocs (bfd *ibfd { /* For input files without an explicit abiversion in e_flags we should have flagged any with symbol st_other bits set - as ELFv1 and above flagged those with .opd as ELFv2. + as ELFv2 and above flagged those with .opd as ELFv1. Set the output abiversion if not yet set, and for any input still ambiguous, take its abiversion from the output. Differences in ABI are reported later. */