From patchwork Tue Dec 19 17:59:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Mezentsev X-Patchwork-Id: 82527 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3E966385771D for ; Tue, 19 Dec 2023 18:00:29 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id C0172385840D for ; Tue, 19 Dec 2023 18:00:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C0172385840D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C0172385840D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703008814; cv=pass; b=CB5PwGhTGfcOoDI/yoN2ISctHEX2nAFvwZVtrszc6UkX3mDIRjPiDNBoOtSDzufbDomp3zh/qiJagPcZypgdEMjzS2UpKGOgC/+LrvNY/s/jQIwaNdZ5tEbDiXcTx3Ly/Udwyqs925jeSYjon3UUIVqRQFJTf418nkwPbICiSNE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1703008814; c=relaxed/simple; bh=MLkXI0XkgAou7vLN5nuQpK4BhiXmsJQbhD4t/3u/tA0=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-Id: MIME-Version; b=kWtb4xiX22UDH8AKcc5bkLduWqSx68CtDdf1+fF/7c7CFJmfTUOXaq7MCpJ3np/NKSs9rsyMBaH02LVssKXOX/U/b08P3cwvfMogF/Ovo35p3MxQw76VQ1uWH5hEgO5S160YmYuNPz78lHath4ew7SBYzgFMbBZRXY7MWfvjlkk= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3BJHJWbZ031679 for ; Tue, 19 Dec 2023 18:00:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2023-11-20; bh=F8cJC496BLEPlzsoOR1ckiqr6XwAGYJ9k1H/NOAtlug=; b=hLJ61oAmQ8kD1MCDkKb88oevszQ4jc3de+nW6E/K8aiZ6pBqjS3ZH0wx5QAi/rdEe5K2 9b8aQLBZHfFBC/ZrbZGwP1wYh97NhLBjWVVSV4T/rEf3kfAGlBGoMSOMw0+ql/G6Ij0I TcHAf5oDwKn6fACvt2bPrz63vh9jTMHPz+MASGFtqQbkQPme5vMGYVNu78ae1AytNyFy 67r/A61dA7U9D04E2ioVyljnOPn1wn9p5yffB775kIYWXf4qTHjVw51pydB/5yGG2vtj xPD/2yK8OjBtJMJCwM7fn/yLgVl9XLk4sNgsmWPX9uKXlMeZ272ueUPf/ESY69I7hPbg wA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3v13guejm3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 19 Dec 2023 18:00:12 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 3BJHScLt020992 for ; Tue, 19 Dec 2023 18:00:11 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3v12b7ef7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 19 Dec 2023 18:00:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WrsQkyQcG44unRhPV0Vc3iXipd1ij/vVrGKvAmYB22G6tKoQITPCTA0EeIYp4N0WMQc1d2DQnnK/dz+uB2HMynn8pCwfuvuxNUQQ5KnOLjvQt3Uk2JLhuH2TY+cyNcUHrjg1WwYlSqW0DAjsbJsa+enzGZSTJXHgd3fWcKNy8ENPgFVbPm+LwIqGoMEVETooQaqE4puOscPTHQXDBysPUBNe9Z/mXwjKhZXAOudToDe5WH75fnplYGfrDlKaOhnKszodG32ULErJa3fiRz1wAdClScp2PS5k1fbB8Elrk1M27CGvehx3C0WruYHCeCn5PhZ4dT3AvUBS55v8PiE8WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F8cJC496BLEPlzsoOR1ckiqr6XwAGYJ9k1H/NOAtlug=; b=l1XGdHVtmpi0w05l8yfSArOuMfUd5MdjU+J9aC6H6ncNSPed75fO66M4QQ/7CnK3DF8TIm2F3XVn63xz+YRfvuBj+uNey16nVj3XBD/EnDBhJgNYVftoi+O9596n/5dJlCiFsQnFi2yQi8hvQW5AMSmE9dle9tf98zxibm696w0grwxwWxeEUpqctVy225/iTbCC3EOgznyk756syrNFN0xFGfmo3V/AcYmJ9l98nFy3gpjRpWh7+qCyK5FyRYy7WWb98JKhRcqCtuqxzKhGxsz2lJR8S0ENwVhT4/MzwUxAysMCyokHZifQYu8G4US2tigvUdPfKte85r3DU7FeoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F8cJC496BLEPlzsoOR1ckiqr6XwAGYJ9k1H/NOAtlug=; b=ySo1Ek9J99Wf7TYmzJE7xu9ZlFsC7r1p3GMhT5CfxHYVNWpGRBT3DAELc98dioT8Ar3ZF0J72RWdazSfgFH6SRZnBhyKY2RohAFkIziXrE5LRoPCotdXrm+WAE4IjCN6hBf3oeUs9H5zFtwMBk6cEpFfYEkxYu6UPhmC7oDY1t8= Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by PH7PR10MB5854.namprd10.prod.outlook.com (2603:10b6:510:127::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Tue, 19 Dec 2023 18:00:06 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::412c:783e:a135:f0d7]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::412c:783e:a135:f0d7%4]) with mapi id 15.20.7091.034; Tue, 19 Dec 2023 18:00:06 +0000 From: vladimir.mezentsev@oracle.com To: binutils@sourceware.org Cc: Vladimir Mezentsev Subject: [PATCH] gprofng: 31169 Source code locations can not be found in a C++ application Date: Tue, 19 Dec 2023 09:59:59 -0800 Message-Id: <20231219175959.3837374-1-vladimir.mezentsev@oracle.com> X-Mailer: git-send-email 2.31.1 X-ClientProxiedBy: SN1PR12CA0078.namprd12.prod.outlook.com (2603:10b6:802:20::49) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|PH7PR10MB5854:EE_ X-MS-Office365-Filtering-Correlation-Id: ef5cea4a-896c-433a-967e-08dc00bc54fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aWtRrCPpNltNUBVbtYQKBGOjXY9PYzfOxCz4SGJXIfJj7RXyxUEpZqJvM5D8mxn3FAPWktOjpKJ7feXnFpBdwAqkV8xfoSbOanzlkZ3KJwgAiITPpLUhi4WycvS0rAHCdPQSXfe+yOhOkKvN8vy5eE7UXKC0cNp54S1rgqzOJA5mqKEOcptueJ69mVVRTfawtvvnm5FAvFxz+UhwlIo8+JEO6VFkEynnhuCrMDUKVuWFjIeNFe2MSY8psXAixkPEN7A7bpXIedp5pe+J1SrVY5RxPu/U8PhDdoN49/L+T+V2aUL+Y03NyBI37mZJwBfnr6NKiSh6ulUGYy5AA7RB9gMs6VEC9qcvJrHe1SnoMpbsYJaQid56OK2K6Hs95TFBE8V7CyKvL//46Y8836N+ShqGsUm0SualtmcFEXK0gphFbtWoP5/czjC9XFDsZiAZwq4JNUnbHo92myY3dGhn43NbtiokUu91iImp/xUv2oIKOT8weAOKgAhfuKBlCdDspXShMIiDqlGHpLL/uyHqFZU0C9MT8bDYeZCQMhKKZlizrGN0UuNi+MlUHeaRnBWD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA2PR10MB4636.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(376002)(136003)(396003)(39860400002)(230922051799003)(186009)(1800799012)(64100799003)(451199024)(478600001)(86362001)(36756003)(38100700002)(83380400001)(107886003)(41300700001)(2616005)(1076003)(316002)(66476007)(6486002)(6512007)(6666004)(66946007)(4001150100001)(9686003)(6916009)(4326008)(66556008)(6506007)(5660300002)(2906002)(8936002)(8676002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Zt2+LgHALlhgrTOT1bqYQvZfM4Yd/sEEJV3amBOcMcGhUYHx07N35bTgjrOXp7s1olriwGGWMVtIvCDDRoG4vyLQnCH/1/h1ZNqiTZwSYGgKofR60DbOf7k4TLl2iWJ4Z6CgjqW0Ei/tjOv1CWOVWd2uAvqPu6HHSS1Mg7ea/yHLE+q0xO6rvWZ7sy9795UL93I8l6kZaAvgVBVDFMUdLfeu+z/Q3+hM5lWVTNAoYFE5WcpsG5EZ/R0PH6k6HqNh3iAU+tBOWA3RZcp4hGjkakx+FfDAEiZpytTs2IINN2TnwQpxm8DTpzfAxFnq6+sz0e8cwYehGEs1KesxekyWzpcCxl731cpSxTT974B44Rixj/JK7Q0hESoTOUH8zr+5Kw+o9ruvXRGBvnf4AJR2oeljqyPzfk5pm9V8sSorlcRvi7Eld1WV1FBDmGsdlAdwQTN7xyrcWfZZKW2sLzS1M3/SdkcKl9mLJn46baZRK/AZUk/VvI0HILA3oYE7EEgOVIUsoP4lDZqzh8s4D7uEdK9v7Y0TN2hyEGjdU+Sx6kJD0fB5mdx6ms3PNPPG/QMHew0Djw+1tUCzpqTuldVTaFyanwjuNIHxUsSEhSiNy/ho6KqwYla8FlSja/TUYROLXsfAKe89MEntiKNTwP98qG2tfUKrtV6nPwR8L4sx2SH0JClk9gWg4c0hcbSf/lHsFaJ8rfEofnTGeqeLdNwNyY6tixQ5gQn8Z5O2F9SHMxTpJAwVOvjjiOtpfV+gYLRDOp4hHTY5spOAST3770662vJVUYGNg0dsgP9IPUYPXmGtuszjHKEmU/IWTXcC3kWAD+W/1H3raMNeBloYeipvLa6KuM5avs/iUq3iK6zZ9PIIBe5rJqlG0jxXIbnutFE96NGu9/CMv0njFYuzQMsyiQg1o4KKnG7XbJPpM+8qJM/C+EoiORslBKgEyV39RxB2Z8phoWxJTo+tgJW7+DsV28Lq6390gh0W4J14gR+iF5nB/xFwK6I/VS1+93ZOEEAe0ZkYTH70kI7i6xPKBvgIlVC5gUd9gaXchlDbZlPIA1CW6Rxtm3ukuTHR8SDMD9saY7mBMzkNqq6wj8tJZqDsvqUSCvj5EP57QHe469BAavOWg5yud74xi7hWoqYu5/XkDlCDfvGDpn8NKPZBdgYGOYOk2YPOwVwDfEtVD7Lz5XTMtc8bG4edWXEJXKkOEZiV/JotWuKFkOJLDO4Gxe6M45vWl7Dt0OjOsm4Im8GoSO/VIdaDtzYCvi8gPMKe0CWW+cpVZ3D87+2Uu3AV1MjWM7dxw3P23kDvO7Ajzz0H2ZV9n1BgFy5N8IXFTFI2ja3bhKo9BI9kjSZAR7zbs+TP4xoCDySK0mtt3F1fk+sy5GOeOSa55mgAoEcXD5Qq8cshB2nlyZgb6yA4KdBpzg8iFlcBlKg+Io3A4wsWHcwI1482tCrvjRdkmO+7JUERg/HKayV75FZlgzXKJ1HrQGecKareNQBeukOjvVvh1W5YjqspXrrR05q3LzxfXGC5kxBPztiiwoJTxq3E7F0Nq8ssxlVwc4CTlj49JT9aDchxBdbwNbvgGmhbe9o/Gq+rOcfx2bUB43qOMnNE7jt4jFlanDvhyhywic9KcAHz8K/KVsiiKHzm4R5SzThVvff9M7Vk X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WbChvg4NB3GBoF8ypa4xa7bUK5j+AXOT6hSYOb0qVJpCo/SL23lxim2fj+nToDA0qwqkGIly86PQ6aQXaSJh+DiOepaZcTvgjSawHfkQrEnMxajszbmkYQLOWuBCg9W6qqmekxRnmHThNe2tqt0OdS4CbsHlLQlyvaj9hzgvKXWnwWTTjSlyIKewJVr8zrBuBsjX40YJ+m6U9lmEm8E7DXsuu6gvfmCjksv5dvF639STjD9qZ9MIbPMrEchfBlbRjlTxzg9BFU+bAFMmO7ZoyUgr+6hdmy3uWcZOCI5wly+CWwGeKdGCPfA5Z+FjmFaQRLs1z2Amp9kAYJbKHbIe1SRSYcyPnjmHnlfvNBznRS1L6TvJA8jj/Wxw4FzzKHalY0hMmdpJ//y/4idF9wcq9/wKNHnr69cGgkE291DTzqTRDpJ1IiGq7gzYvsR4qFigQbgdXi6gLtHwAVi+QGSSCYnos2CIOneb+ZQTtegSszukoP7iddpkTfjUT2p0O3WSxCFTnjC1Jguz4pf+KqV6S0xmspg8kSVeepuw0NxXfpWT/5kEfjDsSSlXTP5lQsEcH/OQXamxrhyjnVA7hZc+aRNU8O6qHGXMDOI+cZGtnKE= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef5cea4a-896c-433a-967e-08dc00bc54fa X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2023 18:00:06.0823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WJjig4x0fbKSPG77GZVrxzuDl2bYVEpLriDeJRHSngwjyOCUeZBDGSJZIgNWzMPqzQtROi6Jflh3bsq577tLqUiN5COjuQ0PLJi/OPFVT1k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB5854 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-12-19_10,2023-12-14_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 mlxscore=0 mlxlogscore=956 bulkscore=0 adultscore=0 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2312190134 X-Proofpoint-ORIG-GUID: -YEa95ClJIqybCm-fW3e46sNUS1Iqyb7 X-Proofpoint-GUID: -YEa95ClJIqybCm-fW3e46sNUS1Iqyb7 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org From: Vladimir Mezentsev gprofng incorrectly reads the form of the DW_FORM_ref_addr attribute for DWARF Version 3 or later. From DWARF specification: References that use the attribute form DW_FORM_ref_addr are specified to be four bytes in the DWARF 32-bit format and eight bytes in the DWARF 64-bit format, while DWARF Version 2 specifies that such references have the same size as an address on the target system. 2023-12-18 Vladimir Mezentsev PR gprofng/31169 * src/DwarfLib.cc: Fix the reader for DW_FORM_ref_addr. --- gprofng/src/DwarfLib.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gprofng/src/DwarfLib.cc b/gprofng/src/DwarfLib.cc index 90c3e6e95a2..62732829517 100644 --- a/gprofng/src/DwarfLib.cc +++ b/gprofng/src/DwarfLib.cc @@ -2034,7 +2034,10 @@ DwrCU::set_die (Dwarf_Die die) atf->u.offset = debug_infoSec->GetULEB128 (); break; case DW_FORM_ref_addr: - atf->u.offset = debug_infoSec->GetADDR (); + if (version > 2) + atf->u.offset = debug_infoSec->GetRef (); + else + atf->u.offset = debug_infoSec->GetADDR (); break; case DW_FORM_sec_offset: atf->u.offset = debug_infoSec->GetRef ();