From patchwork Tue Dec 19 12:30:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 82483 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B94D73857348 for ; Tue, 19 Dec 2023 12:32:27 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 726AD3858C42 for ; Tue, 19 Dec 2023 12:32:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 726AD3858C42 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 726AD3858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702989132; cv=none; b=VplqXW56GmYKcsk+zhi16/rC2AYblhdOok1UDMaKx8sh/nP3XzuloU13RwiJYsGzhbHCvqAq8Rt2JJL/EUZosQ8KtR1TN5ZQQMOAlykQmy0vbxTyYEmHYN3zu1KZY8AKyiIhaYCRqimjfqOpGN4lTsAgxwNmuuInpIsVUzrHrxU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702989132; c=relaxed/simple; bh=pmCrhdHB947qCQYhQRRmjwUekzqXKeP6hN+5KfbbWek=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:MIME-Version; b=Eswot0m3MvQ4wLqXGXsEVesHutoJZNDIRx3lTa/sJh3iUtrO+rzbW2gZP51ySQw7vkfS4PV0BwuiHzpOxIb5JZ1DVRVAas3Kd1JIgIpkRaFKSKb3NFmRj28GIThI3UamAcYfNL0vQruM33jmKASIGn4kgYaYR8T6TnU1YK7cceo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3795C222AA for ; Tue, 19 Dec 2023 12:32:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702989130; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=XbZjjAXA/mdKQ1+OY8G9xik1qb9rFDwtts/RLh8WP2A=; b=b/d0OfS+qIo4LiC9vNHnoPxRCbcLbRoCF/5BUQ36hlqaonIq24/9ArGIWnKEyJs8ZLl9OI v416JIkhUbwwqhePkuHX7sXXFETfizJ0J+CMZqQQabxSNqnJwGUAlFUzQiQyv6JDKH/aOW MzjUy2RuSChrgVjKKEptZQYbnhHRQt4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702989130; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=XbZjjAXA/mdKQ1+OY8G9xik1qb9rFDwtts/RLh8WP2A=; b=i/Him26Y1bz1RwtMioo3yA9afaeqoVyNOrktsY32LDwBz8WOFplopGEJnVDd4XSqbWbz/3 A8mrdA/TH6kweYDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702989129; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=XbZjjAXA/mdKQ1+OY8G9xik1qb9rFDwtts/RLh8WP2A=; b=n7VpB4fGd/hEX8A+6A2V6sT0zK2+87BbRh3Lt63IOb18GcZOBYj4nTO91OnmtI+AIlAvMa RXJaVTMOorJ4iet8fPw6PZYsd68K1nWb3AfPImIMg8DlSnyNcW7t6yfLEb+4HZ0GaNisYK kufuiYXSqENA6kL8OJ0p5uChmBQM/x4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702989129; h=from:from:reply-to:date:date:to:to:cc:mime-version:mime-version: content-type:content-type; bh=XbZjjAXA/mdKQ1+OY8G9xik1qb9rFDwtts/RLh8WP2A=; b=bSgJIoX9h5AyEDUUHG8j/+RgqokseDmGyEFXE8v7WsEZsh6sLWs26Ts3i+Xl57VMOwXP+7 +L9hCvMjCw1JRTDw== Date: Tue, 19 Dec 2023 13:30:58 +0100 (CET) From: Richard Biener To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/113073 - amend PR112736 fix MIME-Version: 1.0 X-Spam-Level: Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.78 X-Spamd-Result: default: False [-1.78 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MISSING_MID(2.50)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.18)[-0.891]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[99.99%] X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Message-Id: <20231219123227.B94D73857348@sourceware.org> The PR112736 testcase fails on RISC-V because the aligned exception uses the wrong check. The alignment support scheme can be dr_aligned even when the access isn't aligned to the vector size but some targets are happy with element alignment. The following fixes that. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/113073 * tree-vect-stmts.cc (vectorizable_load): Properly ensure to exempt only vector-size aligned overreads. --- gcc/tree-vect-stmts.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index fc6923cf68a..e9ff728dfd4 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -11476,7 +11476,9 @@ vectorizable_load (vec_info *vinfo, - (group_size * vf - gap), nunits)) /* DR will be unused. */ ltype = NULL_TREE; - else if (alignment_support_scheme == dr_aligned) + else if (known_ge (vect_align, + tree_to_poly_uint64 + (TYPE_SIZE_UNIT (vectype)))) /* Aligned access to excess elements is OK if at least one element is accessed in the scalar loop. */