From patchwork Mon Dec 18 03:44:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YunQiang Su X-Patchwork-Id: 82367 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3E7C43857C60 for ; Mon, 18 Dec 2023 03:45:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E7C43857C60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1702871117; bh=Qj//lT26B6e4K3H12M3yGUOujpvsSoHdPirhWptADCs=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=WDqo2dTFLif2SwRsrgN3BvJgyfXNJ4cNdFDmL+pGWWNSKOHCH3N24SFKi0vdCr0K5 2v13Zhu+p28p141+mcHgefEI8mFGFLb4dNXDoNZ1mnweObdSEQhLNIICOOknC7Ebii RVEV5okrB9E933uif0IJAFDlTP4hZXFi7I3qmGNg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by sourceware.org (Postfix) with ESMTPS id CCE24385828F; Mon, 18 Dec 2023 03:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CCE24385828F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CCE24385828F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702871088; cv=none; b=GiSQ1T6RmFNkWO5q/Ab2jmuhh+yHsJZHWZgmJxbm5HLdtlg3nSHZ3VDmNpLK9FGwL/UimquPHRAXTSZrc83DmZwSFVp7/b128UDW5ef2J9kiAEdZGR3wpLKu6/j/dGt7egml94Higd8L9ikipSUEfhfLS4Ufx2zsIWXun9ZdRsM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702871088; c=relaxed/simple; bh=8JK8gaGXaplK5jS26AkYi3m5obEMCqVq2ErDWQY1IIo=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=lbtu7iyMv4mPi9q+kTqmKmZSmZ9c2uIrQbZRHxxqGc8oGyVVT3lGExHsNukFlZRRbuZuAs8v65LPb513bhF5HLxZ4nz9Ngv8N2fwaqmQJAeIy3vi/a4OnO8vHHeWR0g8X2693MoWGdX/nZ1UFV2GYF2wYjPnwcYNJuKDKO0I+/Y= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6d66a0d10dcso159293b3a.0; Sun, 17 Dec 2023 19:44:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702871085; x=1703475885; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qj//lT26B6e4K3H12M3yGUOujpvsSoHdPirhWptADCs=; b=VE5/sLrPSk1716CHm5GcUUPJm6qkbxXohoX6satJWM50PquUyLhlUDQuVosprLnAV3 4wHj6fhRDOJmvB8n1QyRw4hUEq2yoBQcQ/JSqnX40YGbzMZSDfIygEdMymqjfYk7iXaP 7RycDIEdi/0cdAbI0stdfZXYwf9guMswAwcAYtlADCB0ny5IIA5vW6/6SV4W/vxj4mg8 cM/u7NX4ZFD6yQw0O/jObPwHYxgVwjyW8CVCDfwSx2x8YHQ311G9MEZmsY/vmM6sxz2M YSdFN7BmFf3azjEX79yC9Hto17pkIIi+w/z0k7LKy7aVfympKlQuT5TUaH7adaJVxkuG qxdg== X-Gm-Message-State: AOJu0YxKl+MtOhfgMJl3b9+0Yi9Q6xE/wQGFZ7/vN9cI+sz3OBIxf6// yl+OVmW5l20Zxpx59FNEP9L3pbEuZmqbbQ8C X-Google-Smtp-Source: AGHT+IGFGWEPIdkV7Rtx8S3rzFlPOkhrROdQc44QEZ0vIIuD0oGBBz4ILuFE1E1C/YkajB7zf72PfA== X-Received: by 2002:a17:90b:3b43:b0:28b:2412:ea88 with SMTP id ot3-20020a17090b3b4300b0028b2412ea88mr1852687pjb.89.1702871085256; Sun, 17 Dec 2023 19:44:45 -0800 (PST) Received: from localhost.localdomain ([149.248.38.156]) by smtp.gmail.com with ESMTPSA id 14-20020a17090a19ce00b0028b92b6c657sm431692pjj.2.2023.12.17.19.44.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 19:44:44 -0800 (PST) From: YunQiang Su To: gcc-patches@gcc.gnu.org Cc: ian@airs.com, pinskia@gmail.com, matoro_mailinglist_gcc-patches@matoro.tk, jakub@redhat.com, YunQiang Su Subject: [PATCH 1/2] MIPS: host_detect_local_cpu, init ret with concat [PR112759] Date: Mon, 18 Dec 2023 11:44:21 +0800 Message-Id: <20231218034422.2668628-1-syq@gcc.gnu.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org The function `reconcat` cannot append string(s) to NULL, as the concat process will stop at the first NULL. Let's initialize `ret` with `concat (" ", NULL)`, then it can be used by reconcat. gcc/ PR target/112759 * config/mips/driver-native.cc (host_detect_local_cpu): initialize ret with concat, so that it can be used by reconcat later. --- gcc/config/mips/driver-native.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/mips/driver-native.cc b/gcc/config/mips/driver-native.cc index afc276f5278..471d1925eff 100644 --- a/gcc/config/mips/driver-native.cc +++ b/gcc/config/mips/driver-native.cc @@ -44,7 +44,7 @@ const char * host_detect_local_cpu (int argc, const char **argv) { const char *cpu = NULL; - char *ret = NULL; + char *ret = concat(" ", NULL); char buf[128]; FILE *f; bool arch; From patchwork Mon Dec 18 03:44:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YunQiang Su X-Patchwork-Id: 82368 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 84CBA3857C7E for ; Mon, 18 Dec 2023 03:45:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84CBA3857C7E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1702871126; bh=SoONzDYY10qxtxbSNNrgdXJL5hd1Fw5SVgHN0Ww2j1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=LymtUiHNmTc73fiF/f/+r9/GVZLAL7gnFzjDpiF61pvLDolXHA1Nh8kyvPsntQLzz iUYdqNKdc0jdlNKaHDt4yjlsecLfdR0G1Y+6WKQGmWpIO2a1kE/Sd+Sy7HcnFy6IxH pAeFH1Sw+PunBiaALfTW0k93DD7SKF5opqpx82fA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by sourceware.org (Postfix) with ESMTPS id 551793857C4F; Mon, 18 Dec 2023 03:44:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 551793857C4F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 551793857C4F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.160.52 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702871098; cv=none; b=FAfsl+gnuAPjqcV4DV0lnY6wIUS+13wfd1LLn8rAlsMPc+O496ucjHgchgMnsG4sIhxYQ6BvsYBdxCSBlv+XCmnjNHlUGl18mbCpdxzi/7l8bf+QFHlq+0ANeJO1QLkmMjrFzwj09SEnDLLKW3hOX48JJKpeN9kI1CXavU7SlYA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702871098; c=relaxed/simple; bh=eyUME1gSALh9oKzk3yb5bgZrf1NonWWQlzsTWcl2WjI=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=CNVjpDVJbPp3eQ/Kxn5ZdBGh1hj+6Prus51tFDHzfvED2HRETafxkQ2+tBx58tkbIIpzc1MnsU924cdgbwQMotib4ZbHOWT4zM22knGu4iKFoiznO8WihZ1xLzytFLd1hpR3qUM9atU4yujiaTCOuxAhCRgphPFsc5hqqM0CISk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-1f5bd86ceb3so2011773fac.2; Sun, 17 Dec 2023 19:44:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702871096; x=1703475896; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SoONzDYY10qxtxbSNNrgdXJL5hd1Fw5SVgHN0Ww2j1I=; b=wlOnFjJFQlZL/lM5fiPoAcHgNZ5CPmketbqh3GOcq9F6wpYpiVPLfBsyyj+FX010A7 KXjo234V7lfzB/Qk3zqGOYKr57VDin5cVR3hbi7agIw19syNNMkDoUHXt8pQTaX9Bg02 zEcrQIJT3m5xdvRuQP/XFwV0J1dxyC6Qxly+tJqfEQ1F27cImuTGTKt+9NA9zBRACR6C H5DDG95RF8/O0SP8fSJMb0UHnLZMR5RhsBGrKj/obM0/GucHM11BRSkmxAG3IDm87sel Ymv3PN2M9QzuMYsoC7IwNZ/b+hmXeZDDMxN6O82Vldvl3QCkXe7VpewoyOjpEpEueV3K fv7Q== X-Gm-Message-State: AOJu0Yzv27XTPxV3HZvvXs0YJX1dDfn/zur4P93fjZHamG2oq5IRdXIy f0d+VFk31krBh5S8ABV1KWz2Tn4fgxnaCeax X-Google-Smtp-Source: AGHT+IFqmvAywbCrhhICglfTHZlUHDFoQlomZUSz37WaPA2X60JIK/wF0Wu8xvxpPM21FQdIDZwC8w== X-Received: by 2002:a05:6358:724e:b0:16e:2898:5de4 with SMTP id i14-20020a056358724e00b0016e28985de4mr18511759rwa.6.1702871096125; Sun, 17 Dec 2023 19:44:56 -0800 (PST) Received: from localhost.localdomain ([149.248.38.156]) by smtp.gmail.com with ESMTPSA id 14-20020a17090a19ce00b0028b92b6c657sm431692pjj.2.2023.12.17.19.44.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 19:44:55 -0800 (PST) From: YunQiang Su To: gcc-patches@gcc.gnu.org Cc: ian@airs.com, pinskia@gmail.com, matoro_mailinglist_gcc-patches@matoro.tk, jakub@redhat.com, YunQiang Su Subject: [PATCH 2/2] libiberty/reconcat: Add note about append string to NULL Date: Mon, 18 Dec 2023 11:44:22 +0800 Message-Id: <20231218034422.2668628-2-syq@gcc.gnu.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231218034422.2668628-1-syq@gcc.gnu.org> References: <20231218034422.2668628-1-syq@gcc.gnu.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org For reconcat, if the `optr` can only be used as the last one of string list, aka, we cannot append something to it. Let's add some note into the document. libiberty: * concat.c (reconcat): Add note about append string to NULL into document. --- libiberty/concat.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libiberty/concat.c b/libiberty/concat.c index 4cb1df3baf3..3a6b4ca71e8 100644 --- a/libiberty/concat.c +++ b/libiberty/concat.c @@ -169,6 +169,9 @@ loop: str = reconcat (str, "pre-", str, NULL); @end example +Note: don't try to append string(s) to the a NULL string, +as the process will stop at the first NULL argument. + @end deftypefn */