From patchwork Sun Dec 17 04:57:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 82325 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E36AD3858CD1 for ; Sun, 17 Dec 2023 04:58:06 +0000 (GMT) X-Original-To: newlib@sourceware.org Delivered-To: newlib@sourceware.org Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id EBC423858D28 for ; Sun, 17 Dec 2023 04:57:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBC423858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBC423858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702789078; cv=none; b=qrOdudHVNrWmMGG1/Ib/D6bA9FN0keYIivQ1cfnCBRmWrKKAW60S1F5zo7Qaiub0GK8El6kmmixr4tk6IE38dpS/JyDsm9PBBz1zPlwRy5J8ZexTAzFSG53pRcQCuUXR2nFBx+rw50ILvwnrsqubtQAM0n0DbAnFdm80267633E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702789078; c=relaxed/simple; bh=mfUK3dzV+ytDwuaKugKicigkrnRdmXakRPWdzQiVlkg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=i9Ov5Mqbyg4DBPW2oqb2oppojIGQK4l72/FuNLZ6geKbJfBXmFQiZct4JuTF1mP6ik3MKT8aROpzyTqHOffPikp07dpS+u0Iap+Starvm5vOtdpxIq8PHOYr3P4yE+rfeSuTb4kR2rgkdY6sRxB6LVETDxiWvigWi90aiaXlSUI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1d04c097e34so13943215ad.0 for ; Sat, 16 Dec 2023 20:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702789074; x=1703393874; darn=sourceware.org; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=GFwjv30zsig+t04izEuih3/tBe3qUVjdrg/jp0XSOb0=; b=XY6zVSuaYmuQyOE4jChwO2aVB+VFcZ9lnFk/gClmO9SO48xFh+wu1cbZNUHSTv/IOO utzO+YRxZAZwZ/v41o+hj7meXMy7IFJRSFTT1pyTuPu9kzvvtzV4P5lvsR4wtRGZjEqW H1wMvppSVNZxicwP2Oo2C3uVaHh7045WsTjMwWxh4WerPAHdKtBVvCLJWbRh4LnBsdo+ uQu7Z7IOkzdxUwQT30s1a843n7En2maHb18U6g02Ji4SgQE2chtQZJ0gPet+O0+0PgFO VoetowWDA0cRFw2wh44HNKdeEJDtXLMTFvjhuDFLVzUEdDRnitt/6On8olHE1aYSrxR5 vmMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702789074; x=1703393874; h=subject:from:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GFwjv30zsig+t04izEuih3/tBe3qUVjdrg/jp0XSOb0=; b=hou+kriKydydY2Om6QnWe82eZS2J/WgYJqCFwF3lRGafTu4o6zmrGeNpkgdrQYdhgo MY0XQW10fZjOMetpp1atE/Bs4016x7kOMypcYPXshdwZ07w7hk04bFqmkOADNCqQVfj5 H4GmJTKTnhHwTG0UxgqqCS1xMhQ4+xj+U74RMQwcVjNAyRpf2iRRnwXgsaFi9bCzB+3F JaJFcm+5SnZhm4R1r+wM+5B9SiwrI59zlYiyuwHQWTPUCzMKVz/8pQRwg8HYJrOs/WKK DT2ETI0wPqODJO14MddxDSAG7e0dZzuy6Wu1qLScb6nDLl7b132VkyjijjIW0AeiCiTx REYQ== X-Gm-Message-State: AOJu0YyB0hsoEw0fmCP6/oku0vFPoyRD3WEK1qVvxs5NZcNUlx9y5xrN f47RzFxFgvt+KhCr94C5YBfjk3LGLmg= X-Google-Smtp-Source: AGHT+IGLPdvV21tZvctyDw/+1s+Awz/+vXBqNJrhWkzvl8IUuzVE66DoCCfIAvAMdlYdMO4illhD+g== X-Received: by 2002:a17:902:8b83:b0:1d3:485a:833d with SMTP id ay3-20020a1709028b8300b001d3485a833dmr8689844plb.39.1702789074003; Sat, 16 Dec 2023 20:57:54 -0800 (PST) Received: from [172.31.1.103] ([172.56.168.60]) by smtp.gmail.com with ESMTPSA id k10-20020a170902694a00b001d1c96a0c63sm16509287plt.274.2023.12.16.20.57.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Dec 2023 20:57:53 -0800 (PST) Message-ID: Date: Sat, 16 Dec 2023 21:57:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: newlib@sourceware.org From: Jeff Law Subject: libgloss fix for bfin port X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: newlib-bounces+patchwork=sourceware.org@sourceware.org gcc-14 will complain loudly both for calling a function without an in-scope prototype or when the in scope prototype differs from the known signature. "main" happens to be one of the functions the compiler knows about. So not only do we need to prototype it, we need to make sure the prototype matches what GCC thinks it should be. This fixes the bfin libgloss port to do the right thing for bfin-elf. OK for the trunk? Jeff diff --git a/libgloss/bfin/syscalls.c b/libgloss/bfin/syscalls.c index 7bd0bede1..2282049e9 100644 --- a/libgloss/bfin/syscalls.c +++ b/libgloss/bfin/syscalls.c @@ -27,6 +27,8 @@ #include #include +int main (int, char **, char **); + register char *stack_ptr asm ("SP"); static inline int @@ -254,7 +256,7 @@ __setup_argv_for_main (int argc) do_syscall (SYS_argn, (void *)block); } - return main (argc, argv); + return main (argc, argv, NULL); } int @@ -263,7 +265,7 @@ __setup_argv_and_call_main () int argc = do_syscall (SYS_argc, 0); if (argc <= 0) - return main (argc, NULL); + return main (argc, NULL, NULL); else return __setup_argv_for_main (argc); }