From patchwork Wed Dec 13 09:21:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?6ZKf5bGF5ZOy?= X-Patchwork-Id: 82039 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D8ABE385C6DD for ; Wed, 13 Dec 2023 09:21:40 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbg150.qq.com (smtpbg150.qq.com [18.132.163.193]) by sourceware.org (Postfix) with ESMTPS id 042643857C7A for ; Wed, 13 Dec 2023 09:21:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 042643857C7A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 042643857C7A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=18.132.163.193 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702459285; cv=none; b=q6QngctbXXiH78q1eoPYUDGEFs031V7mJPsNzcUAm4R2XsZRqCGZ21IPz03rBFT3uz51Ya3tTXK0C/5A22LKwbMKiCt76PmzCRF4qZfZt09KGQTMvF/ZxRaEgFLH0biTslGoi8zYiJnblP7Ow63LjM98kTmLM5TCHPkpvV+2hbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702459285; c=relaxed/simple; bh=qj3mAyQKyc5cR/g1YSm5Osb7Jt6cIAmJx6D8bCs2yuo=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=USNcSa3YITmnR9a7XnW6O0VgMLEoDC1bJK7ZVUcjTm9gWnc0eO1KxczBsGYoN+UxUYT3jSHglgmh9HtF85PvEQxvejiDupiIBVccNE4r0Z1gCtNpFfMm2h7EAbVKgjHUcPOsgLbe4yp0h0d6Ejru1okK2QyVw/y2XmF7tTfhh/k= ARC-Authentication-Results: i=1; server2.sourceware.org X-QQ-mid: bizesmtp68t1702459271tfvarl00 Received: from rios-cad5.localdomain ( [58.60.1.25]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 13 Dec 2023 17:21:10 +0800 (CST) X-QQ-SSF: 01400000000000G0V000000A0000000 X-QQ-FEAT: zT6n3Y95oi2VnnNUTP9qWIGve55C3aCLxJ3Wvi6QIAEdXENhlzXd9D5yohQUc 4oYRLzuPGRAXqu9NvrKvhYAKtUS49eQL87j0OAvK2V+qltvZuMuz2r7/EBm5efdKa8lG3eL OBnR81x2PUtN3TCGKv+e9UhbIG7jxGzERIODI0bikeC521cPzvsrVASW48FZ39h09ov/Qbb 5NJhGirBlSvy0vYjXKh/7f+bxotmbaq/4rSvx5b8QQJAdcBRp3WdBVQev+XmmtaLh8BBGsg yuosfNDhsrKZN7PL6OzuQrmEJkf0A89up25nIpCZDePNH75H/c+Io/xcg9BfrfjTk0ZczWw NCmnl3Ej95P1yuB9P0e3korhTTI2rdITs1HJicM9qUR8wIqoFHxs9c1afaf7e2UOme9odWo tlqexlWNkBg= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 3481897667871455041 From: Juzhe-Zhong To: gcc-patches@gcc.gnu.org Cc: richard.sandiford@arm.com, rguenther@suse.de, jeffreyalaw@gmail.com, Juzhe-Zhong Subject: [PATCH] Middle-end: Adjust decrement IV style partial vectorization COST model Date: Wed, 13 Dec 2023 17:21:07 +0800 Message-Id: <20231213092107.191733-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Hi, before this patch, a simple conversion case for RVV codegen: foo: ble a2,zero,.L8 addiw a5,a2,-1 li a4,6 bleu a5,a4,.L6 srliw a3,a2,3 slli a3,a3,3 add a3,a3,a0 mv a5,a0 mv a4,a1 vsetivli zero,8,e16,m1,ta,ma .L4: vle8.v v2,0(a5) addi a5,a5,8 vzext.vf2 v1,v2 vse16.v v1,0(a4) addi a4,a4,16 bne a3,a5,.L4 andi a5,a2,-8 beq a2,a5,.L10 .L3: slli a4,a5,32 srli a4,a4,32 subw a2,a2,a5 slli a2,a2,32 slli a5,a4,1 srli a2,a2,32 add a0,a0,a4 add a1,a1,a5 vsetvli zero,a2,e16,m1,ta,ma vle8.v v2,0(a0) vzext.vf2 v1,v2 vse16.v v1,0(a1) .L8: ret .L10: ret .L6: li a5,0 j .L3 This vectorization go through first loop: vsetivli zero,8,e16,m1,ta,ma .L4: vle8.v v2,0(a5) addi a5,a5,8 vzext.vf2 v1,v2 vse16.v v1,0(a4) addi a4,a4,16 bne a3,a5,.L4 Each iteration processes 8 elements. For a scalable vectorization with VLEN > 128 bits CPU, it's ok when VLEN = 128. But, as long as VLEN > 128 bits, it will waste the CPU resources. That is, e.g. VLEN = 256bits. only half of the vector units are working and another half is idle. After investigation, I realize that I forgot to adjust COST for SELECT_VL. So, adjust COST for SELECT_VL styple length vectorization. We adjust COST from 3 to 2. since after this patch: foo: ble a2,zero,.L5 .L3: vsetvli a5,a2,e16,m1,ta,ma -----> SELECT_VL cost. vle8.v v2,0(a0) slli a4,a5,1 -----> additional shift of outcome SELECT_VL for memory address calculation. vzext.vf2 v1,v2 sub a2,a2,a5 vse16.v v1,0(a1) add a0,a0,a5 add a1,a1,a4 bne a2,zero,.L3 .L5: ret This patch is a simple fix that I previous forgot. Ok for trunk ? If not, I am going to adjust cost in backend cost model. PR target/111317 gcc/ChangeLog: * tree-vect-loop.cc (vect_estimate_min_profitable_iters): Adjust for COST for decrement IV. gcc/testsuite/ChangeLog: * gcc.dg/vect/costmodel/riscv/rvv/pr111317.c: New test. --- .../gcc.dg/vect/costmodel/riscv/rvv/pr111317.c | 12 ++++++++++++ gcc/tree-vect-loop.cc | 17 ++++++++++++++--- 2 files changed, 26 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/pr111317.c diff --git a/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/pr111317.c b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/pr111317.c new file mode 100644 index 00000000000..d4bea242a9a --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/costmodel/riscv/rvv/pr111317.c @@ -0,0 +1,12 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64gcv -mabi=lp64d -O3 -ftree-vectorize --param=riscv-autovec-lmul=m1" } */ + +void +foo (char *__restrict a, short *__restrict b, int n) +{ + for (int i = 0; i < n; i++) + b[i] = (short) a[i]; +} + +/* { dg-final { scan-assembler-times {vsetvli\s+[a-x0-9]+,\s*[a-x0-9]+,\s*e16,\s*m1,\s*t[au],\s*m[au]} 1 } } */ +/* { dg-final { scan-assembler-times {vsetvli} 1 } } */ diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc index 6261cd1be1d..19e38b8637b 100644 --- a/gcc/tree-vect-loop.cc +++ b/gcc/tree-vect-loop.cc @@ -4870,10 +4870,21 @@ vect_estimate_min_profitable_iters (loop_vec_info loop_vinfo, if (partial_load_store_bias != 0) body_stmts += 1; - /* Each may need two MINs and one MINUS to update lengths in body - for next iteration. */ + unsigned int length_update_cost = 0; + if (LOOP_VINFO_USING_DECREMENTING_IV_P (loop_vinfo)) + /* For decrement IV style, we use a single SELECT_VL since + beginning to calculate the number of elements need to be + processed in current iteration, and a SHIFT operation to + compute the next memory address instead of adding vectorization + factor. */ + length_update_cost = 2; + else + /* For increment IV stype, Each may need two MINs and one MINUS to + update lengths in body for next iteration. */ + length_update_cost = 3; + if (need_iterate_p) - body_stmts += 3 * num_vectors; + body_stmts += length_update_cost * num_vectors; } (void) add_stmt_cost (target_cost_data, prologue_stmts,