From patchwork Mon Sep 13 10:23:21 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: fche at redhat dot com X-Patchwork-Id: 44941 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D4710385780B for ; Mon, 13 Sep 2021 10:23:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4710385780B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631528620; bh=Du0CQHs7RGGGcrpugezPO5LMyH3UErK4JaGh+4i79zg=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Help:List-Subscribe:From:Reply-To:From; b=ZYrgYNx58+RAjUHOIgEaASqFN6RdmnKuuLBMs9RUXuid8Wm/Iasj3nnFbwpGRJRWM viJPZAq8Br1CVa27j4rUDtGCFixZInkiV644uVvOCFV7draJ2E1csm4aostKrkI9rL CUcJ4MBQ/7hP7lTK+IFBpnqR6T6GyN1uGgn1if7U= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: by sourceware.org (Postfix, from userid 48) id 26214385782E; Mon, 13 Sep 2021 10:23:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26214385782E To: libabigail@sourceware.org Subject: [Bug default/28320] abidw - (non-deterministic) infinite loop in XML writer Date: Mon, 13 Sep 2021 10:23:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: dodji at redhat dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: dodji at redhat dot com via Libabigail From: fche at redhat dot com Reply-To: dodji at redhat dot com Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" https://sourceware.org/bugzilla/show_bug.cgi?id=28320 --- Comment #3 from dodji at redhat dot com --- Hello, I couldn't reproduce this issue on the branch you mentioned, while compiling libabigail with gcc. However, I tried punching in the dark a little bit. Could you please try this patch and see if it as an impact at all? diff --git a/src/abg-writer.cc b/src/abg-writer.cc index 9f48dc92..46b6d456 100644 --- a/src/abg-writer.cc +++ b/src/abg-writer.cc @@ -2356,7 +2356,8 @@ write_translation_unit(write_context& ctxt, // considered "opaque". if (class_decl_sptr class_type = is_class_type(t)) if (class_type->get_is_declaration_only() - && !ctxt.type_is_emitted(class_type)) + && !ctxt.type_is_emitted(class_type) + && !ctxt.decl_only_type_is_emitted(class_type)) write_type(class_type, ctxt, indent + c.get_xml_element_indent()); continue;