From patchwork Wed Sep 8 14:28:09 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 44911 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78BF5386197E for ; Wed, 8 Sep 2021 14:28:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78BF5386197E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631111297; bh=+ejATI9m4WTnZJgyFchwVjDJHUmEo1L1vsLaOQX2wa0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=PhmNMwAWDZegxuGMj4jZkruAuOB6DTDpLgi9OwPJO2hFJO974nde884XFtcGi45j4 Pj3ySrwn1sUfvTDjU64nSSKqHokXNfpnnqtUvdxCzGxcRC7o8wAUAlO3jkE2fLvESn zYA41b9pbEQRpwrCqgOhLUAnnTYH5VGojDIdb1/Q= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 53D00385842C for ; Wed, 8 Sep 2021 14:28:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 53D00385842C Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-DdWjtWMoMhqVjj10I7gL6A-1; Wed, 08 Sep 2021 10:28:11 -0400 X-MC-Unique: DdWjtWMoMhqVjj10I7gL6A-1 Received: by mail-wm1-f69.google.com with SMTP id s197-20020a1ca9ce000000b002e72ba822dcso1145933wme.6 for ; Wed, 08 Sep 2021 07:28:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:organization:date:message-id :user-agent:mime-version; bh=+ejATI9m4WTnZJgyFchwVjDJHUmEo1L1vsLaOQX2wa0=; b=WXz6PwiKyxHbrTrcv7oF59lnl4F4JpT068f7Hgn0RBSZL6pLB3Mm3JqeUxnVcXRpUR yzJUOV1h0yBogcsw5PDxXtMebSJHsrLtnq4GO5Bf89iBDsRS2jLqkD9pSDksvpDA4FL6 +MtY2A8hQkVa04iothgvgqkJN9ohz3DSzQbJRyUMmgBm6udrVB1cEivNXsuyjuT4uFkw ztcoxZrEORf5ut8TPOLQJi9z2ERlc6mUBNsDegNs8zxl+GaoFUDn40panqK87Y2WzpJv gAss18TXXydQiP2p2HZvVoc73XA7hxNjTHm+fzrtiScVEVq54n2E9z73ZA2xDsU5L/iL S34w== X-Gm-Message-State: AOAM532XeJ1ZK2Q0Q4pnZEiySC5pqtXuJVuaAknuyVNV6aUxuQXAcqj7 9l97zKcGGZaz9LICgyKntq8CJjQiouEJGFiy2HqRcHB5AVfVQo1zYSzF0JTmB226aCwGtfcXig7 hEXuEQXyE7RVkPP0BLDCQQQ70R+jnkSdQAbdRM7uMhjmYEEe/Sfk1aLllXeZH7hbEfzVq X-Received: by 2002:a5d:5919:: with SMTP id v25mr4499076wrd.32.1631111290518; Wed, 08 Sep 2021 07:28:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwx7BIzRV9KG4DlZEK0o11BnsIh0qaQDias3EgRdFNcDAXFnaEjn0GEn/Ovkyu2AUw7eC/RmA== X-Received: by 2002:a5d:5919:: with SMTP id v25mr4499049wrd.32.1631111290235; Wed, 08 Sep 2021 07:28:10 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id d29sm2429592wrc.6.2021.09.08.07.28.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 07:28:09 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 6AD2A58000E; Wed, 8 Sep 2021 16:28:09 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] writer: Avoid sigsev on types with no translation unit Organization: Red Hat / France X-Operating-System: Fedora 36 X-URL: http://www.redhat.com Date: Wed, 08 Sep 2021 16:28:09 +0200 Message-ID: <8735qff8g6.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, referenced_type_should_be_emitted should not crash on types with associated translation unit, like e.g, "void type". Fixed thus. * src/abg-writer.cc (referenced_type_should_be_emitted): Don't crash on types with no associated translation unit. Signed-off-by: Dodji Seketeli Applied to master. --- src/abg-writer.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/abg-writer.cc b/src/abg-writer.cc index f18293dc..4940e755 100644 --- a/src/abg-writer.cc +++ b/src/abg-writer.cc @@ -2263,8 +2263,9 @@ referenced_type_should_be_emitted(const type_base *t, const translation_unit& tu, bool tu_is_last) { - if ((tu_is_last || t->get_translation_unit()->get_absolute_path() - == tu.get_absolute_path()) + if ((tu_is_last || (t->get_translation_unit() + && (t->get_translation_unit()->get_absolute_path() + == tu.get_absolute_path()))) && !ctxt.type_is_emitted(t) && !ctxt.decl_only_type_is_emitted(t)) return true;