From patchwork Mon Nov 20 01:04:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Johns X-Patchwork-Id: 80314 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9C7543858C29 for ; Mon, 20 Nov 2023 01:05:32 +0000 (GMT) X-Original-To: newlib@sourceware.org Delivered-To: newlib@sourceware.org Received: from mail.contemporary.net.au (msc1401703.lnk.telstra.net [139.130.245.200]) by sourceware.org (Postfix) with ESMTPS id 434353858D37 for ; Mon, 20 Nov 2023 01:05:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 434353858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rtems.org Authentication-Results: sourceware.org; spf=none smtp.mailfrom=rtems.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 434353858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=139.130.245.200 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700442314; cv=none; b=J5SR2cnt2rTi9NoTePDWOGWlFTp9LBWy1t+5Y9LMaThebdCB8VRdOSSqhryovQ0OW3Ox9GHrLRK9qdgsxP0DjIKTJwWu9J4Ki2wt7ce/KxLJOxl9JySBCrg+ik1v32PtXooveQ+pWKepOYMrvTdgdL5Yye/0kYBMO9mDuKQjy1s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700442314; c=relaxed/simple; bh=+ZIvNAByp6tEIIkyxZ6reR+4jOX9Jtnr80VcavfHPx0=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=ZN7g6/ul87+2enzrMSOSqY7rJXMjgNs/uVdbwaVwekQtFkfDMJj0QltlUEmt/ZWdk94Wcfh6fvA0mXydOGufexftr9QZL9JgOjHfpZAU8J9VK3M62FgTqRJ5pka5+uHMODlYYQNVXveqrE5g/blCqU++3H/LlQbUMsb7tTzFik8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from ruru.contemporary.net.au (ruru.contemporary.net.au [10.10.5.2]) by mail.contemporary.net.au (8.15.2/8.15.2) with ESMTP id 3AK14x7C029101; Mon, 20 Nov 2023 12:05:02 +1100 (EST) (envelope-from chrisj@rtems.org) From: chrisj@rtems.org To: newlib@sourceware.org Cc: Chris Johns Subject: [PATCH v2] Reclaim _REENT_MP_P5S in _reclaim_reent Date: Mon, 20 Nov 2023 12:04:58 +1100 Message-Id: <20231120010458.32916-1-chrisj@rtems.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-Spam-Status: No, score=-10.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, KHOP_HELO_FCRDNS, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: newlib@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Newlib mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: newlib-bounces+patchwork=sourceware.org@sourceware.org From: Chris Johns The _REENT_MP_P5S blocks are allocated using Balloc via i2b and linked in the pow5mult call. As a result these blocks are not on the freelist managed by the Bfree call. This change fixes a memory leak in threads that clean up using _reclaim_reent. RTEMS: Closes #4967 --- newlib/libc/reent/reent.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/newlib/libc/reent/reent.c b/newlib/libc/reent/reent.c index db80ca06e..74503fa59 100644 --- a/newlib/libc/reent/reent.c +++ b/newlib/libc/reent/reent.c @@ -59,6 +59,17 @@ _reclaim_reent (struct _reent *ptr) } if (_REENT_MP_RESULT(ptr)) _free_r (ptr, _REENT_MP_RESULT(ptr)); + if (_REENT_MP_P5S(ptr)) + { + struct _Bigint *thisone, *nextone; + nextone = _REENT_MP_P5S(ptr); + while (nextone) + { + thisone = nextone; + nextone = nextone->_next; + _free_r (ptr, thisone); + } + } #ifdef _REENT_SMALL } #endif