From patchwork Thu Nov 2 19:58:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sergei Trofimovich X-Patchwork-Id: 78962 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5E1D73858C60 for ; Thu, 2 Nov 2023 19:59:09 +0000 (GMT) X-Original-To: elfutils-devel@sourceware.org Delivered-To: elfutils-devel@sourceware.org Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id EAD773858D28 for ; Thu, 2 Nov 2023 19:58:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EAD773858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EAD773858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::329 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698955144; cv=none; b=nuKn39Yna9IsUcskE8phUtuHuIeqiI5u22EQxUbQODpydS4mwtsnBaarRGrl/gkAOi19HvN3AIqyN6xhhvYNssRYPAcPhcp19wNKoJnhi6SjrSVz/IFOCeUnOOGGjfTWcsLQwkL/4us5/Fm2ANQs1hYOABeWDDVdPev0MYvG924= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698955144; c=relaxed/simple; bh=0aXWJBCU4FHdr6UKY2jqQ0Ze2/LR83DXAxZXuMFkvns=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jJNrvIhfxIUBYy5BpAPpWWZtKyOfKp/brxK4C8VuEg0mjNHx9B+gRtt2kMgW7VilMvILbEoE1PmkkFqP4a9Qa7rG1RW+YBdEv85J/HyiD0BPbkMRxcwh+YKio51BsYatWFyU6lCpu15nqP+8ZT53UhscxzSoxgMPzeqGCp9hhmI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-40859dee28cso9960345e9.0 for ; Thu, 02 Nov 2023 12:58:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698955132; x=1699559932; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=CXsoydE3ibG3b+dECk5t76YHUG6JA7SZ032UlXGcRr4=; b=ROHxU+MRIXsFy6d132lwc1tgEBqLP7zOCH+WfaJ3oN45Uz3hBXJVMiLVV3cIhGEapl MvPtO5PfKuvF27zOj8VJAXyay2Lgz3taVVMvXlBJA2kGxkIfR60EBd0mOMSwnVHB0vit bgTKy9BOUyzIbz+MHF4qUYgvbRBqWnypIbFl5AeLK4d9OA7C/YEf7QBaNEP28MT9gID9 4adj5mt7ZSVd4Ll3asyuCQ27YwJMxuTaZ8LsfTrSlmSq3WqrEJRARPgJivvi1ImikOOD mcu2QcaWrv+Xj6Wmv4MrmbHaH6n3NFS0OjIBUIt9Pu0o55PL9l5JSp25MUpz18i7Jtw3 gxQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698955132; x=1699559932; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CXsoydE3ibG3b+dECk5t76YHUG6JA7SZ032UlXGcRr4=; b=CNVeYrlqFaMVUXVc/kx26SzWTC+kZkSGjQKGrm1HVre8R74mbF+njPeyrKqIQWGxir vJGi6g+F9pf480Ifw6xKtrvJawHwwqGzhNBJt6dNoIQOAWymoO0SGIUjDB+Gp4KORTri 9GqmP3zGTsdYYogTUf4/M414yWUnbUmjTb+Zz6R5GiNAmc7yR+5qllfSFK20NlpDTI5B 3TNoidvmp26y+JQBRWfn/DRa3HMiIbJqG971CrTZ7FgKPgODf4qJnK6/lhPRGift6Cl7 Zpe2oO7O2Sd+x5NDBRyBXKG6TSdR3yPp2y+OQhi5Ch6ZBVsaK88PAB6OIitI6u734wxW Tlvw== X-Gm-Message-State: AOJu0YxKhZ6SkAGjabY4jcaQtDWiVdSPZGzZbGw6hkpibmlQgbrh8fGf uSMSAaaD9rem7liwwtHJBWM= X-Google-Smtp-Source: AGHT+IF64bYx5sLwrWLO6K49lXK3n/6whVa4TkqnyJsPiYgbOG5Bepe0qbc0twD+3wZxBJSjjfJoag== X-Received: by 2002:a05:600c:880f:b0:405:36a0:108f with SMTP id gy15-20020a05600c880f00b0040536a0108fmr17746026wmb.41.1698955131973; Thu, 02 Nov 2023 12:58:51 -0700 (PDT) Received: from nz.home ([2a00:23c8:a613:101:6bdd:22fe:8b3:b334]) by smtp.gmail.com with ESMTPSA id o5-20020a05600c4fc500b004090798d29csm173198wmq.15.2023.11.02.12.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 12:58:51 -0700 (PDT) Received: by nz.home (Postfix, from userid 1000) id 0C71F1262CDA0F; Thu, 2 Nov 2023 19:58:51 +0000 (GMT) From: Sergei Trofimovich To: elfutils-devel@sourceware.org Cc: Sergei Trofimovich Subject: [PATCH] libelf/elf_newscn.c: fix build failure against gcc-14 (-Walloc-size) Date: Thu, 2 Nov 2023 19:58:46 +0000 Message-ID: <20231102195846.1414311-1-slyich@gmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: elfutils-devel-bounces+patchwork=sourceware.org@sourceware.org `gcc-14` adde a new -Walloc-size warning that makes sure that size of an individual element matches size of a pointed type: https://gcc.gnu.org/PR71219 `elfutils` triggers is on `calloc()` call where member size is sued as `1`. elf_newscn.c: In function `elf_newscn`: elf_newscn.c:97:12: error: allocation of insufficient size «1» for type «Elf_ScnList» with size «16» [-Werror=alloc-size] 97 | newp = calloc (sizeof (Elf_ScnList) | ^ The change swaps arguments to pass larger value as a member size. Signed-off-by: Sergei Trofimovich --- libelf/elf_newscn.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libelf/elf_newscn.c b/libelf/elf_newscn.c index d6bdf153..ec731f75 100644 --- a/libelf/elf_newscn.c +++ b/libelf/elf_newscn.c @@ -94,9 +94,9 @@ elf_newscn (Elf *elf) 1 #endif ) - newp = calloc (sizeof (Elf_ScnList) - + ((elf->state.elf.scnincr *= 2) - * sizeof (Elf_Scn)), 1); + newp = calloc (1, sizeof (Elf_ScnList) + + ((elf->state.elf.scnincr *= 2) + * sizeof (Elf_Scn))); if (newp == NULL) { __libelf_seterrno (ELF_E_NOMEM);