From patchwork Tue Aug 10 13:01:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Geissler X-Patchwork-Id: 44623 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EBBC6395ACD0 for ; Tue, 10 Aug 2021 13:02:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBBC6395ACD0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1628600521; bh=aIuAKP+dRKBPjrpUqlsHxL7iLLu5jhdqDt/wVRzE5zU=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=nGT6bBPV3dv5eMGbAyvIHQp8BKYyhQfOD1YDFzEnEnNfPCzUmzQHY9He6P9mKBZfY lF/2eMNBNUN75+B8qGJfqUTTPxXrQFwJ/a8TCVm/bkreIpOJOWjdKKi4wqDP8bxogq VrQKGMkpaUJwfad8vTr4RBj6BAohwIvO+0DzhzIo= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e1a::60d]) by sourceware.org (Postfix) with ESMTPS id 87A61385AC1C for ; Tue, 10 Aug 2021 13:01:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 87A61385AC1C ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J8NVvmxzq1wR+zpjIV6Da7vWhKYi9chUe/fhSf1UvpudYobN82PI9bTqF2VmEysfJl01j2aIbVV75RqWgHS+0Y9e/4/rFAggJKlLv8zZP//56mbYDlfHtuuc7DHiz6pLNwQ43WpEAAcKMiMZ4/pNlRIovabRnEnt64wRfSyhNzsrSROLPhwKEI8/m/fLOceGUlskm87naIPhrphplYochqP0ghnGF44a1NToJr1b0T+ZJpYWejOiA3S5hH5UXD7QiMVkL52jXYh3frklVKADos3Mbo/K9siY0roUoMgrKEOyAEQZNG6o1wJ9VnO/7QCFCS1XGkjlFHPT6Sq0GQYvsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aIuAKP+dRKBPjrpUqlsHxL7iLLu5jhdqDt/wVRzE5zU=; b=Rivkz7lVWGXPQ3RfU7+1biQ0ya1nMZObUHiOX2GwZIQJKxLqxUofPFd1lJJLpKkFWJ+DnrSzVDngEdkpU5BsSKoQ5j8+FI/d1VZ5Fad1N2wFE/iU+AILUTDoupSpKpc/wWb4QdFwRkQeDcXLQjiZiixLbE9KY0F4CJQQee9s6CVta7ai2iKbtI3saAI2sGKoQQ6Y+YbxXU+bV51TCMOMPPHDnPY9eTBXwXuTfbXgqJX4uxgWb/Dfbf4t2MBRRNYkP7kAXmJJ0PCUIw7ppElYmjZ7BSNxdio63CbsD1pTBuI9xQdYpOl7IjOyLahWxs9IFp/d/anuVvBWAt2OScjvYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amadeus.com; dmarc=pass action=none header.from=amadeus.com; dkim=pass header.d=amadeus.com; arc=none Received: from PR3PR10MB3772.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:4d::12) by PAXPR10MB4800.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:159::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14; Tue, 10 Aug 2021 13:01:28 +0000 Received: from PR3PR10MB3772.EURPRD10.PROD.OUTLOOK.COM ([fe80::84e9:c93b:af68:b407]) by PR3PR10MB3772.EURPRD10.PROD.OUTLOOK.COM ([fe80::84e9:c93b:af68:b407%8]) with mapi id 15.20.4394.023; Tue, 10 Aug 2021 13:01:28 +0000 To: "libc-alpha@sourceware.org" Subject: [PATCH] Fix tst-canon-bz26341 when the glibc build current working directory is itself using symlinks Thread-Topic: [PATCH] Fix tst-canon-bz26341 when the glibc build current working directory is itself using symlinks Thread-Index: AQHXjefU9RtWDQp7f0i3dKRaX8++ag== Date: Tue, 10 Aug 2021 13:01:28 +0000 Message-ID: <20210810130121.GA62219@ncerndobedev6097.etv.nce.amadeus.net> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mutt/1.10.1 (2018-07-13) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 11718bff-2ad2-4ba0-5943-08d95bfef782 x-ms-traffictypediagnostic: PAXPR10MB4800: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VW9JqCLCi5qPj+CI8WIPsuU3ClUwh7hM+hBRHk6JK9yS3uDUF2hxsllDAUDxNWyJCkh3L0+v4ORnc5sn6tOwJK6e6yo4QFFFT01DfSJ7UIHLtFmIBlHzKLcPr3Xkarxbns9AMVYuVg4KFbEY7lWsnnupyB2UeALlk9pgS/ZASswW8zCaY1G4Z1RQz01UcsxMUq+2iX1UAHAQBVuWXED+eCHY/AGN5sCFeRRFNdxOiJReCdn0SmQ/qaGzltZ+uQlXL9EuBCviP0RggpaKNuKpvR2za2e1bOFEO3NSTlE+/lgr3Nq0KdT9GuA8LO04PyTEvEmdZG4RXD+Iv4uuiDP/vWcEvgzL6qihg5XUAAy7q/80nGYH/nN53XV/lcwA8NkcIW8H3MtU++E+7k9poUQLj4qf15k7/NmChKMBl/UfjTrV5FYWAN0RtkWMRwxauUmDxVzFk0JBShFb9v5QJ2RreFAaU8gFB+Ptbs6Xgo8+57rYqlaD1sjawu7xT4l/d+15UtF9ACR3hQYLI7K4pGUxedx4meFc2d7Vda4LI8xWwQZmb5yGZntXpK/0Zn9HyNNjXaVfo3mV0mma3FH8ns8ghUl7ETvRCSabUN+dHw8V41lR2SIqx2jr6IG8XFp0j/5v4OQ3wGq2gIEydutuQe6c7jxK2+JhC9uU9vkGMZ54WNdRktQ7GsKCaqsDQhHQSKwR6pEcNIn4mmGGHn61ZA7i6A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR10MB3772.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(396003)(136003)(39860400002)(376002)(26005)(478600001)(186003)(86362001)(53546011)(6506007)(38070700005)(6916009)(1076003)(316002)(2906002)(5660300002)(122000001)(66446008)(71200400001)(66946007)(66476007)(8936002)(6486002)(8676002)(9686003)(64756008)(6512007)(76116006)(38100700002)(83380400001)(33656002)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: NMsCteiUUkK4L/lkGLe7DJ4WJiIiM4Kz4E/VPL/IaBhPm5xwngdKPN2PsP1p3cffkqXJHIUHy2+o/r8tg3ZTwyOlfg3BBIccKFjeQBLvYKK/AVHhDWkUMMkdpWkjNJU+c1DiJqzBHokfCTTxUDeDKqI35mUCjz2a6f3a6bDmNB4oNHJWzjOyQLHWNXraslgygyRggzwsQMO510yka4euIZBQyWfYwkB5D/QwaCcm1w+2ePX8/46fngYO4/xmPU31xGOqbYJsmaDpozBSyFsb/04CJ46+ghIvkD5miOVugya9orSeeDyJ2Sv+RzBt+h45fIugGEiVsAD2mfQC7v1m0TAd53l/6P6Yn7TjZ/nyd+THSBNLCTYWl2H0qImQ3qVAn5d9qTL/pBIKs0YLBEwf4hTLfScWde/T2peD3C260eNT2+vUBQ4tHuSrjOBdpClKwP/L1LKdX4CCRf53XLeso4+4OmfWhm70XiRBiL2qa7nlW/E2MB3kruADf5+JBljJVERt5Rix8qOC/jfhtixJ1v4dZmsR2DQBAipGqg+BkTt6mbhh7kuINdKoeL0iE9yzVy5gnwCR4202pgCUrCFBpRqWGMViEGlfoTmlybqChDpnXf5JHF5rzfCi38fGRDifcuA8xRs8Y991eFEo2f/gkLTjOx6hSdQpvnLIqzpd8xYoL6WnFs0ywoZ6dhO1Zt2NeeM0v0otl2h5M2Zws8RhPW8idPYfzb5VzEOiePRnM3tLEWgFDs7B9EJrfPF2AibBu8H3ORoXaGLf6823oHpWz/tjf7rVDET+6Lrq8NMIKtYR7hBNy7IB5iZDAmdkyHA4qhQsRJG3xfZ/oNHMhOSQFK18ZPouhr7tXI3ll7N7Ywf5byDtPvN/jg7nN0e30HrzEN63gAl1AGH48Jg94h5f+aO3o59aGXmDTRjy2ovSykI0z4z9I8K1VEq0Nyu3DLwsuRFgktDOQ5vx5pXrsdGo0slVvHDG0h4AXIKNdTXq+uj6flpbtKSc53URjk+ClPBSEBCqZLeNfSDAZC/WyUDalmpFyM3Tv1rfrGLsr4rDg/UldjzIss1JEUQwwWzWqUVW/iB5N3wR08tT49K9/8m5pkNqrWPRyicqUJ3pihSmaF2i33bIOd4SrvfO1LcF8xN6JDU5PEePY1AxLhSaYaqfZa8cwH1axhFaUCT2RZVjoZGLMq+eUJPb/O2tXVKDJET9nIPM1VRXX3YSvPZ5DfMMDxdk7VrYr2Lt3W6LgTWvKVmo6VRq18A7ZXn4TdrTl+HtXt0XzR1oVq9x0QGSJMDNdDek28VePyVRq62D1F+3ZufOX6o8RctQ6prARiWoFld+ x-ms-exchange-transport-forked: True Content-ID: <2A255CA3075FF64EB7D314C7D35BE972@EURPRD10.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: amadeus.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PR3PR10MB3772.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 11718bff-2ad2-4ba0-5943-08d95bfef782 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2021 13:01:28.0647 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b3f4f7c2-72ce-4192-aba4-d6c7719b5766 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hfNdLQLvo5FVfHxaCc+WUL3bsQhnc1sKgbdPB68x0SFZPB7zwQI9YnG5rxlpxJOrsu+7UvzgtoXi/xRS8upZIe2j5kJOAkKP51nGsZa7Gn0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR10MB4800 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Romain GEISSLER via Libc-alpha From: Romain Geissler Reply-To: Romain GEISSLER Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Hi, I am seeing test failures with tst-canon-bz26341. Using strace I found out that the problem comes from when change the current working directory to my glibc build directory, I use a path with is using itself symlinks. So at the beginning of the test the "filename" variable needs to be canonicalized properly to make it pass in these conditions. Tested on x86-64. Cheers, Romain From 99ef44560977e366c64912cfcb2a6535a0614c50 Mon Sep 17 00:00:00 2001 From: Romain Geissler Date: Tue, 10 Aug 2021 12:40:41 +0000 Subject: [PATCH] Fix tst-canon-bz26341 when the glibc build current working directory is itself using symlinks. Reviewed-by: Adhemerval Zanella --- stdlib/tst-canon-bz26341.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/stdlib/tst-canon-bz26341.c b/stdlib/tst-canon-bz26341.c index acb0fd4ec30..171ec0dc45a 100644 --- a/stdlib/tst-canon-bz26341.c +++ b/stdlib/tst-canon-bz26341.c @@ -45,6 +45,12 @@ create_link (void) TEST_VERIFY_EXIT (fd != -1); xclose (fd); + /* Make filename a canonical path. */ + char *saved_filename = filename; + filename = realpath (filename, NULL); + free (saved_filename); + TEST_VERIFY (filename != NULL); + /* Create MAXLINKS symbolic links to the temporary filename. On exit, linkname has the last link created. */ char *prevlink = filename;