From patchwork Tue Oct 24 08:01:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 78429 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 423FD3858410 for ; Tue, 24 Oct 2023 08:01:02 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 70EB83858D37 for ; Tue, 24 Oct 2023 08:00:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 70EB83858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 70EB83858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.220.28 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698134447; cv=none; b=tILlwVbGL0ImAYxVtMwnEtp3qP4Yri60XkN1sf5meZJs/XQL48lkmVXgOZzH+HoEhKOTF1RJ+Bnx5K2VpMpcPWn+iO/oEFgNNPXZ9/0cJbQZ/tuOl1zLuhOi7xysSZHa8+6I4ksU+ewikuAz8L1GYsaZl1g91Y0sylKxTRWmeL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698134447; c=relaxed/simple; bh=3rUsOldnouzLBd7+4DFMDjid1GrYjh5FmlAGDJItyLs=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-Id: MIME-Version; b=FTBbOunR6qLZ/KsdkwyPJ1VKfHU30F3NOJxWUhUSChDm1OAq4v25fXw+vHfV5f7jgjotgR72CjSmI277Ux4Hjc2Kuh2ERJzDjgshh56kh4mK2IcmRh397X0AB7xcZUDBIP1MrSe9pkv6gPVL9MofBNy7bbzFEXfl80FXmsk9v4U= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9AAA32188D for ; Tue, 24 Oct 2023 08:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698134444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fuX7At/6SNTq0oXdk8k+FLulOmcUVdYXvqMFoPVI63Q=; b=0rDgmbGABXcpBvmhS7FuJsrTuUVAH34HfbGichKPeZDmVlIBKlqzrcXyi+a6970lShVAdG 3M0FnjGwXxfgdk7c142A5AnMpRiI1/KxGyFtJnhJEGrS6odp+prI61ak1jAON5GdEcUCPF Fds6YiIYG5i56aRAsjHogSpPIUx+Pgg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698134444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=fuX7At/6SNTq0oXdk8k+FLulOmcUVdYXvqMFoPVI63Q=; b=6POJNfiQsc3yoZcIg7DAUtwPZtOBckQBWMLxA2hqbLOaQSUwOcJOE/yz+fNP0UmGPPDKfI cJO1Gh+d8hJ//hAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8994E134F5 for ; Tue, 24 Oct 2023 08:00:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EmqbIKx5N2X2VAAAMHmgww (envelope-from ) for ; Tue, 24 Oct 2023 08:00:44 +0000 From: Tom de Vries To: binutils@sourceware.org Subject: [PATCH] [readelf] Handle unknown name of main in .gdb_index section Date: Tue, 24 Oct 2023 10:01:32 +0200 Message-Id: <20231024080132.1181-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: 0.89 X-Spamd-Result: default: False [0.89 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_MISSING_CHARSET(2.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; BROKEN_CONTENT_TYPE(1.50)[]; PREVIOUSLY_DELIVERED(0.00)[binutils@sourceware.org]; RCPT_COUNT_ONE(0.00)[1]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_LONG(-3.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-0.01)[47.96%] X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org When compiling hello world and adding a v9 .gdb-index section: ... $ gcc -g hello.c $ gdb-add-index a.out ... readelf shows it as: ... Shortcut table: Language of main: unknown: 0 Name of main: ^A ... The documentation of gdb says about the "Name of main" that: ... This value must be ignored if the value for the language of main is zero. ... Implement this approach in display_gdb_index, such that we have instead: ... Shortcut table: Language of main: unknown: 0 Name of main: ... Tested on x86_64-linux. --- binutils/dwarf.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) base-commit: 8bf3b48f72728208ad09989edfac9e010a62a703 diff --git a/binutils/dwarf.c b/binutils/dwarf.c index 584c737b9ec..544ba6dff50 100644 --- a/binutils/dwarf.c +++ b/binutils/dwarf.c @@ -10949,16 +10949,21 @@ display_gdb_index (struct dwarf_section *section, display_lang (lang); printf ("\n"); - uint32_t name_offset = byte_get_little_endian (shortcut_table + 4, 4); printf (_("Name of main: ")); - if (name_offset >= section->size - constant_pool_offset) + if (lang == 0) + printf (_("\n")); + else { - printf (_("\n"), name_offset); - warn (_("Corrupt name offset of 0x%x found for name of main\n"), - name_offset); + uint32_t name_offset = byte_get_little_endian (shortcut_table + 4, 4); + if (name_offset >= section->size - constant_pool_offset) + { + printf (_("\n"), name_offset); + warn (_("Corrupt name offset of 0x%x found for name of main\n"), + name_offset); + } + else + printf ("%s\n", constant_pool + name_offset); } - else - printf ("%s\n", constant_pool + name_offset); } return 1;