From patchwork Tue Oct 17 04:50:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Modra X-Patchwork-Id: 77918 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B44163857707 for ; Tue, 17 Oct 2023 04:50:50 +0000 (GMT) X-Original-To: binutils@sourceware.org Delivered-To: binutils@sourceware.org Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id D1DE73858C01 for ; Tue, 17 Oct 2023 04:50:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1DE73858C01 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1DE73858C01 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::634 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697518236; cv=none; b=fmaAKQWaMQfMdEX5BrQXHSwTj5JkXFTAI+RT2vcfQvn77AVKLPihGpgKYAwUzyqTWSgO4mtjGwz7/w9DiT+4k25+4inBRE1QUzLHeP2q0xl1LHblLqyE2t4jMLjT6e9s452oEcd0DMXEcJWuzLb5c092AR98vEBibeGqg3fhlLE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697518236; c=relaxed/simple; bh=NuUKdBI6NYdSAm1MW+XB+lhNhBqPcscwEwdW4v4n1+4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=TOpaKaduQev2XHrD4r2xtwtjy6kH/k0EnB5rYnN+FEL1T5fjQWhdejUcXDg6SYEOtl+S62G2IndRreQV2f5ivZgkfNJDETmr6D0igEM3MzCu9UCQgAZAFm7KcNrkgDjx5HRzRk3nijFQ8Zpuv+9CBKzkDpAhOW5j4SqMEHrDN0k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1c9e95aa02dso33015425ad.0 for ; Mon, 16 Oct 2023 21:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697518233; x=1698123033; darn=sourceware.org; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=ejEBjFjh5z+8chuiTRQJR+0v5TXMpLnxYZdEBdJKEmU=; b=jQxImjY8l0RSrGd8dplE0Rv11krJodxup8AU2B/fvUr0dmlj8XMlDdE1KaEVs6C8tE x2BHcUTqP7Yfrr170ULroRMvaWk1goJelCS6HxEBQ0BmyofjzU6pJTOV+PwGz4ZDX4z5 5QuU2vO5AnflCGiZ1RcdnPCVO1wD4kmUmo/FaK03ilXX//ARxqfhgqKuBS5+k3SH5Ozs L2UBSBPy5/EB0rB6hyKwLiD22Q3dXLxO0E8fBiXUQrg3Yxayi110AUZ38iy+9ly/fYmY avOIH/vLYp2Wzn3CLBpekhfV0S5XHLHwlDCIuMW7/Ep884rTyqe2QIeSnrRnAYg5IObH 2AtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697518233; x=1698123033; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ejEBjFjh5z+8chuiTRQJR+0v5TXMpLnxYZdEBdJKEmU=; b=PWelDyA9rI7MAgly13hdp8lnZ1cPJmCoDBWxJl+iYIwQZ8fJvgpm0aijlIS+RCHc1y HR2rxt69Cps1iI5l8eSBPABrmrG0uIc40AvmQMXQQINU8cZekHJSm36eLuxATznw21PZ 1Ch3ZnLUKCuJbjyLex/vCto9qPDnLZAixn6NLo/QZxplqxEllXIVZGq9dRVqbZfbIuy0 RXJY/EZPngM4om7YtePHK/XgPGhcdyVkxnBbJbtVpruSpPk6alKUMBuG2E4t64XEBlT9 QK/tXKjpgWE5XziZ3VIhjc7oRold7PRbxIb1zJtTqwo+RJ8SiFQ4/iIzUzQ+1AbUCHfc Ki5Q== X-Gm-Message-State: AOJu0YxCtbGDNo6wtt4b6PVASfciA8k03FyNJER23xIwCf9DPHGzLk7l y0Sl74W24/jfot+4T22xA5bMsTKdaLc= X-Google-Smtp-Source: AGHT+IHkKGDs/9thm7PcPBBid+y++bgXSDPSdjGfmwS9GMYhuamQKPhD1scV/4g0v0qK+LN6Oua44w== X-Received: by 2002:a17:902:e5c3:b0:1b0:3ab6:5140 with SMTP id u3-20020a170902e5c300b001b03ab65140mr1291755plf.4.1697518233378; Mon, 16 Oct 2023 21:50:33 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id b3-20020a170902d30300b001c72d694ea5sm445789plc.303.2023.10.16.21.50.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 21:50:32 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id 2984B11422A7; Tue, 17 Oct 2023 15:20:30 +1030 (ACDT) Date: Tue, 17 Oct 2023 15:20:30 +1030 From: Alan Modra To: binutils@sourceware.org Subject: asan: Invalid free in alpha_ecoff_get_relocated_section_contents Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-3034.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: binutils-bounces+patchwork=sourceware.org@sourceware.org This fixes an ancient bug in commit a3a33af390 (which makes me think this code has never been used). There is a "free (reloc_vector)" after the end of the loop. * coff-alpha.c (alpha_ecoff_get_relocated_section_contents): Iterate through reloc_vector using a temp. diff --git a/bfd/coff-alpha.c b/bfd/coff-alpha.c index 1b34a8957c2..59476b57237 100644 --- a/bfd/coff-alpha.c +++ b/bfd/coff-alpha.c @@ -810,13 +810,13 @@ alpha_ecoff_get_relocated_section_contents (bfd *abfd, } } - for (; *reloc_vector != (arelent *) NULL; reloc_vector++) + for (arelent **relp = reloc_vector; *relp != NULL; relp++) { arelent *rel; bfd_reloc_status_type r; char *err; - rel = *reloc_vector; + rel = *relp; r = bfd_reloc_ok; switch (rel->howto->type) {