From patchwork Thu Oct 12 11:35:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 77607 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 13C8A3857C5A for ; Thu, 12 Oct 2023 11:35:21 +0000 (GMT) X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 576BD3858C5E for ; Thu, 12 Oct 2023 11:35:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 576BD3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697110517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=lsj8/+nnRJMRnjE/wIvpdrKlznNzmJtk13Sk2hWLiLg=; b=I9QrUOwCQwoyoRfRUXZxSHoIO4ak7gqQaBPYA2v81EYjqHlP/LS12CCpoS0BU3UYIIil+H kScAlsSSMO+D+K1xcZd2Zpyx2kb+cilYSgU0JPcQq4KTQt1iQSWvZYUjpaaHslOUTmXvA7 3MdRz9jJRs+/KKfEcnQECVvJ9bWnBGk= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-Y8zxrokXPPyeSyacWFS2Xg-1; Thu, 12 Oct 2023 07:35:15 -0400 X-MC-Unique: Y8zxrokXPPyeSyacWFS2Xg-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7770bfcbdc6so104072585a.0 for ; Thu, 12 Oct 2023 04:35:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697110515; x=1697715315; h=mime-version:user-agent:message-id:date:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lsj8/+nnRJMRnjE/wIvpdrKlznNzmJtk13Sk2hWLiLg=; b=ulvqMlu5EALqpM7UHzr4T6ybY7MDvomSC/OhwzZ11n/PWsh540Kzl5mwf80wu39lae J50d9v7XGvf6ZD2PwrCQUEWUhAw2AdNZcoqWwLX5cPb2WqvD31DWDAXE8oNWSQq4IpOb SaW8zbR9gooUbyUzLgisu54/67IkAygr3efxT4v1b/dVlkcypIYAshN0fm5BrMAY3E32 wroR+47cxg02DCyaqFWJrGdfXAp9oQGRFqh8aaJnXwb+jmdKJ6uK3dJ+jRaITeX4RFEE N1HdUvjxLv8OyST+r+NwkGKGS9DTUrP/OA8kJdhsIHPDVdKMdIkXumRQ8J9UCadT0klQ bHng== X-Gm-Message-State: AOJu0Yzzs3EQuNe/Y8ZwAvhdup7nmmiGyAWiMCFxXb23zPp212zYsJRv R5fsrUeQiMb+wPPxIyj1A+gsKAsgfrWRU1So4DqCMc7kfhZbbbIzrW5FvSq/rQPjbvJe4t0SIby CgRaOkCS+mIhxyLvQWzVXGYn/iOYq9y77vocc+Q0ostVr9fv18QkzmuDcsMqwpbYsbY1PSq66to gB X-Received: by 2002:a05:620a:1788:b0:771:7698:7c51 with SMTP id ay8-20020a05620a178800b0077176987c51mr28609199qkb.16.1697110515195; Thu, 12 Oct 2023 04:35:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+2dtiszzUZ+ryFSHEFSx7POGQyLkbJzYQnvCxzMuB89PJ97IVaDDLI+5DaaP/EaS2QEGCyA== X-Received: by 2002:a05:620a:1788:b0:771:7698:7c51 with SMTP id ay8-20020a05620a178800b0077176987c51mr28609184qkb.16.1697110514880; Thu, 12 Oct 2023 04:35:14 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id pj40-20020a05620a1da800b007743360b3fasm5960553qkn.34.2023.10.12.04.35.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Oct 2023 04:35:13 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 239965079000; Thu, 12 Oct 2023 13:35:11 +0200 (CEST) From: Dodji Seketeli To: libabigail@sourceware.org Subject: [PATCH, applied] ir: Remove redundant virtual member functions Organization: Red Hat / France X-Operating-System: AlmaLinux 9.2 X-URL: http://www.redhat.com Date: Thu, 12 Oct 2023 13:35:11 +0200 Message-ID: <87fs2goyz4.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Hello, G++ 13.2.1 complains that virtual member functions {qualified_type_def,pointer_type_def,class_or_union}::operator!= are redundant with type_base::operator!=, and rightfully so. This patch removes those useless virtual member functions. * include/abg-ir.h ({qualified_type_def,pointer_type_def,class_or_union}::operator!=): Remove these redundant virtual data members. Signed-off-by: Dodji Seketeli Applied to the master branch. --- include/abg-ir.h | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/include/abg-ir.h b/include/abg-ir.h index 18e95afd..5a9aed9a 100644 --- a/include/abg-ir.h +++ b/include/abg-ir.h @@ -2252,11 +2252,6 @@ public: virtual bool operator==(const qualified_type_def&) const; - virtual bool - operator!=(const qualified_type_def& other) const { - return !(*this == other); - } - CV get_cv_quals() const; @@ -2359,11 +2354,6 @@ public: bool operator==(const pointer_type_def&) const; - bool - operator!=(const pointer_type_def& other) const { - return !(*this == other); - } - const type_base_sptr get_pointed_to_type() const; @@ -2428,11 +2418,6 @@ public: bool operator==(const reference_type_def&) const; - bool - operator!=(const reference_type_def& other) const { - return !(*this == other); - } - type_base_sptr get_pointed_to_type() const; @@ -4114,11 +4099,6 @@ public: virtual bool operator==(const class_or_union&) const; - virtual bool - operator !=(const class_or_union& other) const { - return !(*this == other); - } - virtual bool traverse(ir_node_visitor& v);