From patchwork Tue Oct 3 09:40:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dodji Seketeli X-Patchwork-Id: 77006 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9F4893858C50 for ; Tue, 3 Oct 2023 09:41:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9F4893858C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1696326061; bh=UgsMWoPf9L3hjgVZsP4ILsi44VPjoQW61I1PDO7eYII=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=eC5w3uFsN86p/gaoTIvr75pngNmz/Jh6VJow6zS0Dr+GLflkRzFKt35vJnt/SD4C2 51yahTZeLzrf2JIOy6SMZ3kboYJhyDFVDPh6JSk27BftVf/JD13IpxCPVNgmdvKUYT vGW8FJUfj/LrA1k4vlgbtW12Hr3CApbibmxmlngI= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EB95E3858D28 for ; Tue, 3 Oct 2023 09:40:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB95E3858D28 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-529-gMgSEgjjOzyygtiwtIh2Ow-1; Tue, 03 Oct 2023 05:40:55 -0400 X-MC-Unique: gMgSEgjjOzyygtiwtIh2Ow-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-77574c5f713so114906885a.0 for ; Tue, 03 Oct 2023 02:40:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696326055; x=1696930855; h=mime-version:user-agent:message-id:date:organization:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UgsMWoPf9L3hjgVZsP4ILsi44VPjoQW61I1PDO7eYII=; b=cB480uFpUS7a0yfsPVl57DR2ySEY1yJ9AnLSil82uvWEpogc60B1D+j5GoYUxzyD8J 9nVlFLHsqKjlDqRrzAJM4EOB0Vo6obgudEkbFCc5oqk1XWXWilYuaMyxKD14tnrqtEAn TL0vqz1ulrybiFKQBvplGrKmzj4F8GjZsGeLd6ZBJ5csp2Kkdvp1sc7bdaUYKtUOCg6n onII4JOdLmJTSoUlNYWFxfoRlCA2zjOFqX58Ix5R1MVLm/PI04ka+zQL/nUwC29ivvKm bjRHbKupEqLHeXTkdmBpOZ6x4Lp3CuLh8qRkl5GGPMfIlf4t73eCrySuUZAIMNSSW9ch e01A== X-Gm-Message-State: AOJu0YwJL1hXPPgkDKG5i3x54daAPsNHiloG0+pmp/LD0uDtnr6oYS65 kTiYw+0gJfV4KZ+zXur0VWW0XEtVNg/usr4+Ch059EnULUB2cTe0mP40PWHRmNP0I4tddGq+oq7 wZPOTyXb1BUW9i1/T/96om6gOvsZuY6Ka+lhsWzf41kuDGaAnhWCGGmkFm9r7fTpay4ymyzO85J I5 X-Received: by 2002:a05:620a:25c9:b0:770:ef43:7638 with SMTP id y9-20020a05620a25c900b00770ef437638mr16037865qko.33.1696326054796; Tue, 03 Oct 2023 02:40:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IENyRFh1JJrUyoegz3gtOgB0tUc/SDpkp5/0UdGeDtW7373a0ZJgkjztQa2oWXhZ6DXvp613A== X-Received: by 2002:a05:620a:25c9:b0:770:ef43:7638 with SMTP id y9-20020a05620a25c900b00770ef437638mr16037851qko.33.1696326054444; Tue, 03 Oct 2023 02:40:54 -0700 (PDT) Received: from localhost ([88.120.130.27]) by smtp.gmail.com with ESMTPSA id u11-20020ae9c00b000000b0077438383a07sm306568qkk.80.2023.10.03.02.40.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 02:40:53 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 72AE4B6E87; Tue, 3 Oct 2023 11:40:51 +0200 (CEST) To: libabigail@sourceware.org Subject: [PATCH, applied] ir: Fix output of 'debug(enum-type)' Organization: Red Hat / France X-Operating-System: CentOS Stream release 9 X-URL: http://www.redhat.com Date: Tue, 03 Oct 2023 11:40:51 +0200 Message-ID: <87edicgi1o.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, RCVD_IN_SORBS_WEB, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: Dodji Seketeli via Libabigail From: Dodji Seketeli Reply-To: Dodji Seketeli Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" Hello, The output of calling the debug function on an enum type wrongly says that we are looking at a union. Ooops. Fixed thus. * src/abg-ir.cc (get_debug_representation): Don't say 'union' when we are looking at an enum. Signed-off-by: Dodji Seketeli Applied to master. --- src/abg-ir.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/abg-ir.cc b/src/abg-ir.cc index e7a2d6a8..fc3437d6 100644 --- a/src/abg-ir.cc +++ b/src/abg-ir.cc @@ -9653,7 +9653,7 @@ get_debug_representation(const type_or_decl_base* artifact) { string name = e->get_qualified_name(); std::ostringstream o; - o << "union " << name + o << "enum " << name << " : " << e->get_underlying_type()->get_pretty_representation(/*internal=*/false, true)