From patchwork Thu Jul 15 11:22:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 44371 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0FA403AAB016 for ; Thu, 15 Jul 2021 11:23:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0FA403AAB016 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626348182; bh=u19/jiQUXmgT88faqvMV7Z6NU8K1l7LR2ue7rZrJhcY=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=wMAvF7ob0ie/fGELfP2nfID4xvGyZ8U0dsVlwjC7AsQhRZXpuE00BSUc4FaHEqxLq 19tUSeanMLnaJ9xOquV4+AOgB2wfIv1AVLX1WGRdpBJ/J1ZIuBkhUloydV7HcV+VUO 8sJvv3oap2ns/OquMMe/CMTxyS51Lp7h/SQ/3rSE= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 51B063858001 for ; Thu, 15 Jul 2021 11:22:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 51B063858001 Received: by mail-pl1-x632.google.com with SMTP id n11so3087770plc.2 for ; Thu, 15 Jul 2021 04:22:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=u19/jiQUXmgT88faqvMV7Z6NU8K1l7LR2ue7rZrJhcY=; b=lOUAJaWZq2KPMu0VvEEPnBW8oeprFnN8GYG+a6A5SR9C+PVinmdbv7DXh3o7i5K554 lJ9xzcPNYv7mssx9OXcI9N6h6o9CIBahn77u7DNAGAiyEjUy6y50a4hwTmYPcrtlZ5MO ynrkG/ifWnUOel1gbxP09bcY25+0JaxK6XaFN+3ZiSBtlrkPEDTZyRFJHNshmjYdE2VJ 4PjdDq0rRRzgBMlrJC2QoZGm+DmoyHEKYADRfzH56h4eybCCTUN9TbIuoDTC8TGY89N/ f3kCcfTA7Nyuy8AW2ExMkEEBV5M6UcbvsUvS/gKnHzY4kq+q1A2YxtpOqrkKryOhgEPp Fy+A== X-Gm-Message-State: AOAM533ZvvvTVwG3QG9c2sjTzVbSbJxe1P5s/cokBgvNFtytC05ODC/b jSfg4q92DExSGgHPE8j41gqMzVgRE5Zthw== X-Google-Smtp-Source: ABdhPJymwCHZHnty9JjT2+dri+Ucwd1ZfebPPVEf2bDg96VL26dKbS6THy7+wjxCqj8VwQmSa5IGHA== X-Received: by 2002:a17:903:22c7:b029:12a:efc6:374d with SMTP id y7-20020a17090322c7b029012aefc6374dmr3120401plg.71.1626348159217; Thu, 15 Jul 2021 04:22:39 -0700 (PDT) Received: from birita.. ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id 30sm7017360pgq.31.2021.07.15.04.22.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 04:22:38 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] elf: Add -Wl, --no-as-needed for tst-tls-manydynamic*mod-dep-bad.so (BZ #28089) Date: Thu, 15 Jul 2021 08:22:34 -0300 Message-Id: <20210715112234.4168206-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The tests explicit requires the dependencies and it is required for the case the toolchain defaults to -Wl,--as-needed. Checked on x86_64-linux-gnu. --- elf/Makefile | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/elf/Makefile b/elf/Makefile index bdd5cc9e1a..4fe60947ad 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -1854,25 +1854,36 @@ $(objpfx)tst-tls-manydynamic16mod-dep.so: $(objpfx)tst-tls-manydynamic18mod-dep. # Same but with an invalid module. # Single dependency. $(objpfx)tst-tls-manydynamic0mod-dep-bad.so: $(objpfx)tst-tls20mod-bad.so +LDFLAGS-tst-tls-manydynamic0mod-dep-bad.so = -Wl,--no-as-needed # Double dependencies. $(objpfx)tst-tls-manydynamic1mod-dep-bad.so: $(objpfx)tst-tls-manydynamic2mod-dep-bad.so \ $(objpfx)tst-tls20mod-bad.so +LDFLAGS-tst-tls-manydynamic1mod-dep-bad.so = -Wl,--no-as-needed # Double dependencies with each dependency depent of another module. $(objpfx)tst-tls-manydynamic3mod-dep-bad.so: $(objpfx)tst-tls-manydynamic4mod-dep-bad.so \ $(objpfx)tst-tls-manydynamic5mod-dep-bad.so +LDFLAGS-tst-tls-manydynamic3mod-dep-bad.so = -Wl,--no-as-needed $(objpfx)tst-tls-manydynamic4mod-dep-bad.so: $(objpfx)tst-tls20mod-bad.so +LDFLAGS-tst-tls-manydynamic4mod-dep-bad.so = -Wl,--no-as-needed $(objpfx)tst-tls-manydynamic5mod-dep-bad.so: $(objpfx)tst-tls20mod-bad.so +LDFLAGS-tst-tls-manydynamic5mod-dep-bad.so = -Wl,--no-as-needed # Long chain with one double dependency in the middle $(objpfx)tst-tls-manydynamic6mod-dep-bad.so: $(objpfx)tst-tls-manydynamic7mod-dep-bad.so \ $(objpfx)tst-tls-manydynamic8mod-dep-bad.so +LDFLAGS-tst-tls-manydynamic6mod-dep-bad.so = -Wl,--no-as-needed $(objpfx)tst-tls-manydynamic7mod-dep-bad.so: $(objpfx)tst-tls-manydynamic9mod-dep-bad.so +LDFLAGS-tst-tls-manydynamic7mod-dep-bad.so = -Wl,--no-as-needed $(objpfx)tst-tls-manydynamic9mod-dep-bad.so: $(objpfx)tst-tls20mod-bad.so +LDFLAGS-tst-tls-manydynamic9mod-dep-bad.so = -Wl,--no-as-needed # Long chain with two double depedencies in the middle $(objpfx)tst-tls-manydynamic10mod-dep-bad.so: $(objpfx)tst-tls-manydynamic11mod-dep-bad.so +LDFLAGS-tst-tls-manydynamic10mod-dep-bad.so = -Wl,--no-as-needed $(objpfx)tst-tls-manydynamic11mod-dep-bad.so: $(objpfx)tst-tls-manydynamic12mod-dep-bad.so \ $(objpfx)tst-tls-manydynamic13mod-dep-bad.so +LDFLAGS-tst-tls-manydynamic11mod-dep-bad.so = -Wl,--no-as-needed $(objpfx)tst-tls-manydynamic12mod-dep-bad.so: $(objpfx)tst-tls-manydynamic14mod-dep-bad.so \ $(objpfx)tst-tls20mod-bad.so +LDFLAGS-tst-tls-manydynamic12mod-dep-bad.so = -Wl,--no-as-needed $(objpfx)tst-tls20: $(shared-thread-library) $(objpfx)tst-tls20.out: $(objpfx)tst-tls20mod-bad.so \ $(tst-tls-many-dynamic-modules:%=$(objpfx)%.so) \