From patchwork Tue Jul 13 14:17:42 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 44335 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 407F4395ACCC for ; Tue, 13 Jul 2021 14:19:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 407F4395ACCC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626185986; bh=Q31k362FMo+DsLJOdCEFrEZdZfUuzcJgr1gmwlPt70o=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=cAd2b5jyVKmRnF6exzfy3UPzZoYE6YU2TymS+sdQAuwC0+o6XdEbk4fDq89YlP64t 7SDiJJptyULvIs61IdbnFMefctSRWngZ1hhKUfx1Kv4Hc60sZOAMN2VxGd9KXTuH2N EJGlaxIOgP3YFkQL6mPpVipK0XzrKugTZeu0U5Y8= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by sourceware.org (Postfix) with ESMTPS id 6774F395C80C for ; Tue, 13 Jul 2021 14:17:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6774F395C80C Received: by mail-pg1-x529.google.com with SMTP id 37so21767868pgq.0 for ; Tue, 13 Jul 2021 07:17:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=Q31k362FMo+DsLJOdCEFrEZdZfUuzcJgr1gmwlPt70o=; b=RdtG49hYTwI5UF5UYajAGg41nGhtvjtF/wNXyiCvIsfaREWcnDlw0EzWe4xEIMHYVv kyFMW6zBDGeRFQ8X/8op+dSY5q+e30lIbeKFp6McXG1WntHvk31pogYk5SjsgVDwYO05 mwtOnJV/NkYTlmQc7Sx6ySx6ZEvTxXSsYtYbgR0TvpRevzQHP1lwNFSnHJfQJPQeVbNh ezLALcSja9yIL3rftvNir0Qc3TqGLCIrpxI7/529iqLUmcIxTwZl068hccbsjivJd2uo d0fWXVXo3/M+tAjSIIFroG2nl8vQQTB1oKE/edSkpy/wyHEgZ3ynerBQl4jgu8gRZR9e JMNA== X-Gm-Message-State: AOAM533yY0xh6WSzcBHXoQIfe+/2L/Mc1nwOOXzf+2CQmMDN3YRx5UwD ftNr8UwP7wIggX6n9fmz9mQ05JPRYTQFqQ== X-Google-Smtp-Source: ABdhPJwYOTcCdebBzd5E3roJ3/Vn5YCfhA0wiM8FWRPxI0sgB5thMh5ppAzr897tT+rkOOr70NZuOw== X-Received: by 2002:a05:6a00:124d:b029:306:878:e5b with SMTP id u13-20020a056a00124db029030608780e5bmr4705724pfi.25.1626185867080; Tue, 13 Jul 2021 07:17:47 -0700 (PDT) Received: from birita.. ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id t22sm3283652pjo.3.2021.07.13.07.17.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 07:17:46 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] time: Ignore interval nanoseconds on tst-itimer Date: Tue, 13 Jul 2021 11:17:42 -0300 Message-Id: <20210713141742.2717549-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Running the test on a 4.4 kernel within KVM, the precision used on ITIMER_VIRTUAL and ITIMER_PROF seems to different than the one used for ITIMER_REAL (it seems the same used for CLOCK_REALTIME_COARSE and CLOCK_MONOTONIC_COARSE). I did not see it on other kernels, for instance 5.11 and 4.15. To avoid trying to guess the resolution used, do not check the nanosecond internal values for the specific timers. Checked on i686-linux-gnu with a 4.4 kernel. --- time/tst-itimer.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/time/tst-itimer.c b/time/tst-itimer.c index 929c2b74c7..554caa75f2 100644 --- a/time/tst-itimer.c +++ b/time/tst-itimer.c @@ -74,6 +74,9 @@ do_test (void) { TEST_COMPARE (it_old.it_interval.tv_sec, 10); TEST_COMPARE (it_old.it_interval.tv_usec, 20); + /* Some systems might use a different precision for ITIMER_VIRTUAL + and ITIMER_iPROF and thus the value might be adjusted. To avoid + trying to guess the resolution, we do not check it. */ } /* Create a periodic timer and check if the return value is the one @@ -87,7 +90,8 @@ do_test (void) TEST_COMPARE (setitimer (timers[i], &(struct itimerval) { 0 }, &it_old), 0); TEST_COMPARE (it.it_interval.tv_sec, it_old.it_interval.tv_sec); - TEST_COMPARE (it.it_interval.tv_usec, it_old.it_interval.tv_usec); + if (timers[i] == ITIMER_REAL) + TEST_COMPARE (it.it_interval.tv_usec, it_old.it_interval.tv_usec); if (sizeof (time_t) == 4) continue;