From patchwork Wed Jun 16 11:04:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: mark at klomp dot org X-Patchwork-Id: 43856 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 042BF396E859 for ; Wed, 16 Jun 2021 11:04:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 042BF396E859 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623841466; bh=4cvHruh5CuCW63OLX6kxFSPOkg/CLEG2mzRjvUo/jGs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Help: List-Subscribe:From:Reply-To:From; b=CIdVD8RMAGNpALYtXCXUX3utjKKunK53eeNfLomHphgp5dSfN/eZV0QQ++YooIZ7o tk3lYwqNrhJUIgVR7qiyKzsD1vOjEYw/0yqC2eY9mjyZ9UXoqgUkDptUp4E/4sKPO4 X/cMDI6jhN4tJdxSdfLdee14vMSMCm/iwE2vfIY4= X-Original-To: libabigail@sourceware.org Delivered-To: libabigail@sourceware.org Received: by sourceware.org (Postfix, from userid 48) id 7C3D53839C44; Wed, 16 Jun 2021 11:04:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C3D53839C44 To: libabigail@sourceware.org Subject: [Bug default/27985] New: abidiff: bad array types in report Date: Wed, 16 Jun 2021 11:04:23 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: libabigail X-Bugzilla-Component: default X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: gprocida at google dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: dodji at redhat dot com X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status bug_severity priority component assigned_to reporter cc target_milestone attachments.created Message-ID: X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: libabigail@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list of the Libabigail project List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-Patchwork-Original-From: gprocida at google dot com via Libabigail From: mark at klomp dot org Reply-To: gprocida at google dot com Errors-To: libabigail-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libabigail" https://sourceware.org/bugzilla/show_bug.cgi?id=27985 Bug ID: 27985 Summary: abidiff: bad array types in report Product: libabigail Version: unspecified Status: UNCONFIRMED Severity: normal Priority: P2 Component: default Assignee: dodji at redhat dot com Reporter: gprocida at google dot com CC: libabigail at sourceware dot org Target Milestone: --- Created attachment 13496 --> https://sourceware.org/bugzilla/attachment.cgi?id=13496&action=edit two XML files to compare This is a regression which I've bisected to the recent commit 9681ab04d20f8dacdb14404f6234f63a62e61dd2 "Fix recursive array type definition". The attached XML files were generated straightforwardly with abidw. The source files look like the following. The resulting abidiff output contains: type of 'int numbers[2]' changed: type name changed from 'void[2]' to 'void[3]' array type size changed from 64 to 96 array type subrange 1 changed length from 2 to 3 instead of type of 'int numbers[2]' changed: type name changed from 'int[2]' to 'int[3]' array type size changed from 64 to 96 array type subrange 1 changed length from 2 to 3 --- indirect_c.0.c 2020-07-31 13:35:19.000000000 +0100 +++ indirect_c.1.c 2020-07-31 13:35:19.000000000 +0100 @@ -1,9 +1,9 @@ struct leaf { - int numbers[2]; + int numbers[3]; }; struct node { struct leaf* ptr; }; void foo(struct node *n) { (void) n; }