From patchwork Mon Jul 10 11:22:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Burgess X-Patchwork-Id: 72412 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7B35B385770D for ; Mon, 10 Jul 2023 11:23:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7B35B385770D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1688988182; bh=odSlOZXy/XX2Ef+thXwPuZ/sV2dTUjciNersuJYF+1o=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=IURBGwT9PfkEwDDIOntfPWub2PjViV3PzT0VU/8pkigNqevP/QWmDesSPIfOVcMbb D7W3MA0hUMuz/n2QRHDXYpiqkWrPu+OVuwKOoy6loVlYQyBdCiJUxFf86BjlAV8lfb tzwI3hlbdXcpPBUPNpy014I9HlCrxoBNrRmmx0dA= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5AF3F3858D32 for ; Mon, 10 Jul 2023 11:22:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5AF3F3858D32 Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208-lTqJ08lsM_ytf0rLFA4Wrg-1; Mon, 10 Jul 2023 07:22:36 -0400 X-MC-Unique: lTqJ08lsM_ytf0rLFA4Wrg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fc08d6a40cso10782645e9.0 for ; Mon, 10 Jul 2023 04:22:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688988155; x=1691580155; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=odSlOZXy/XX2Ef+thXwPuZ/sV2dTUjciNersuJYF+1o=; b=hEfNl8TqnCm1Ub8rRKbwQ8KyZ9AURS+uilRz2g2j3xCfbjFxX9gu2zD+3w2s+A89rP zpgyZBO2TopN0Dm1QWUsCqVuA4jIu8zVrwe/o/eubkGnM01SYdqt8C2t+czyJGjziVhp uNZXCtUBFD47+OV7Xv4Ym8uC/su4bn6FLA0dyxTXK5rU3eFSGGq7WeW88M9wyUMjdQDK zZ38NgeWsWfqw99JpzAW8lNkyHpJXkm2cciWk9y6TzFi7/tRjvEtxZQdT4diYu3rSYG+ PMuebzaLAuybJuW4RV1fuRWEED365B5iNxM0rDHrXKod4K3qkKuM0eFoz7Mnn0SC2HQH zOpw== X-Gm-Message-State: ABy/qLbEdQbXEWT6pX5z0bfUr5JDjPFcqaim5HBkWGHFM5qM2Hkl3RnY exppwJgCeLKQ4X6JunvnZ78/ISCR0XH6gc/7F5ygGT8CpwSi5160Fov87GrGiD5gsYA2xvA1dOb e3gmWFt+L/ioGGhg90sxzbrCfTg47vrU4TJxtzylUzqZD0hz8Tgn+6TNwzP8ugdpjNIXQvafhJY zUPLMh6w== X-Received: by 2002:a7b:c409:0:b0:3fb:b34f:6cd4 with SMTP id k9-20020a7bc409000000b003fbb34f6cd4mr5383387wmi.36.1688988155432; Mon, 10 Jul 2023 04:22:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlGyb8XyBwsZ5HpE4Hqxplgal3MEMyoMlnIvpa3nb3sMZTCd0XMsPHlGyPcehgWUEh/1Hhh/Hg== X-Received: by 2002:a7b:c409:0:b0:3fb:b34f:6cd4 with SMTP id k9-20020a7bc409000000b003fbb34f6cd4mr5383367wmi.36.1688988155035; Mon, 10 Jul 2023 04:22:35 -0700 (PDT) Received: from localhost (2.72.115.87.dyn.plus.net. [87.115.72.2]) by smtp.gmail.com with ESMTPSA id z18-20020a5d6552000000b0030fd03e3d25sm11483238wrv.75.2023.07.10.04.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 04:22:34 -0700 (PDT) To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: [PUSHED] gdb/testsuite: avoid stack addresses in test names Date: Mon, 10 Jul 2023 12:22:32 +0100 Message-Id: <9f462ddef8456dc3b47e21f5f1995d1119e18b3f.1688988130.git.aburgess@redhat.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Andrew Burgess via Gdb-patches From: Andrew Burgess Reply-To: Andrew Burgess Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" When comparing the test results for two different runs of GDB I noticed a difference in the results for gdb.base/frame-view.exp. The difference was caused by one of the tests including a stack address in the test name: PASS: gdb.base/frame-view.exp: with_pretty_printer=false: select-frame view 0x7ffff7c5cea8 0x40115b and PASS: gdb.base/frame-view.exp: with_pretty_printer=true: select-frame view 0x7ffff7c5cea8 0x40115b If for whatever reason the stack address changes between test runs then it becomes harder to compare results. Fix this by giving the test a descriptive name that doesn't include a stack address: PASS: gdb.base/frame-view.exp: with_pretty_printer=false: select thread 2 frame from thread 1 and PASS: gdb.base/frame-view.exp: with_pretty_printer=true: select thread 2 frame from thread 1 There's no change to what is actually tested after this commit. --- gdb/testsuite/gdb.base/frame-view.exp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) base-commit: 44c8334f4af5b9895d196077f23e20e15eff4c03 diff --git a/gdb/testsuite/gdb.base/frame-view.exp b/gdb/testsuite/gdb.base/frame-view.exp index d71b369fd79..b139ecf94b2 100644 --- a/gdb/testsuite/gdb.base/frame-view.exp +++ b/gdb/testsuite/gdb.base/frame-view.exp @@ -73,7 +73,8 @@ proc test_select_frame_view { with_pretty_printer } { # Select thread 2's frame in thread 1. gdb_test "thread 1" "Switching to thread 1 .*" - gdb_test_no_output "select-frame view $frame_sp $frame_pc" + gdb_test_no_output "select-frame view $frame_sp $frame_pc" \ + "select thread 2 frame from thread 1" if { $with_pretty_printer } { # When the pretty printer does its infcall, it is done on the currently