From patchwork Fri Jun 2 11:38:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 70506 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0F0B2385697F for ; Fri, 2 Jun 2023 11:38:24 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [81.169.146.163]) by sourceware.org (Postfix) with ESMTPS id 7CE883858D3C for ; Fri, 2 Jun 2023 11:38:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7CE883858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gjlay.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=gjlay.de ARC-Seal: i=1; a=rsa-sha256; t=1685705885; cv=none; d=strato.com; s=strato-dkim-0002; b=SFidwm1uYO4pjo4DSJjikDg6GSjPkOoMSBXT4a1lJgVuf8OLj8XL6wbR/xsgzZR9xg k8sVzSpCDI3LCJU4u30Ydl16QWpYz6zWGt7/SfA4AtdI5yciauoow2fAybXvWiCc48fl CJ+uI2SZNAeMm5hQy2qVWCVInGkaukEzMwrGKOd40KRZWuejv0DX7VDvpwSM5mYQnJRz vQ8kDoY0D4xKsxUs9/iHfb3WPvAwQfw2CdO2Mku/9fuBpGvRNiDnANoOdyZuoEJfu7uj m6vZsphvusVMLtpZ2RLOJ71oNB8Qd+zZFc21OZGYtmCagXm1o/wCW8r6ImrVyOOjMniV DHwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1685705885; s=strato-dkim-0002; d=strato.com; h=Subject:From:To:Date:Message-ID:Cc:Date:From:Subject:Sender; bh=3DnaJegJuy0/36fpx9vQAHtCcvBVZz/Wl9fbRmJIA2o=; b=l4snuZ7BiawNl5B0ZqEqiYeHv865T72OqML6iKZ7Mz+qOPA4rvF/HILbZZ09wcPMdn l5R2gXBu0HdVOqPRC7sBzKOW44wE5mMOsBXdl3IqPqusllFQFhoMw9ciI0qbSpPNDWtu 1S6k8n2jhD3arCU8pAXyx1rShi7A7ORdk9XOROV7Q3t1EJZgwcCn/DN1t5fPJ62czqXg PaauzWmrvrOGqGjmNTO/K/GyzktiwKjkAwzrdCyEY2v4Q80fl/RQsBtE4iKRogk8b2nU 6QT3JAkL6dKmCVM+vx01sAkLy91IbeS5IdlnECX8yqiXyPKmuH0FRLGqcOfUeHDCignz x5Xg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1685705885; s=strato-dkim-0002; d=gjlay.de; h=Subject:From:To:Date:Message-ID:Cc:Date:From:Subject:Sender; bh=3DnaJegJuy0/36fpx9vQAHtCcvBVZz/Wl9fbRmJIA2o=; b=EU+5RjCQdCcyBFFRtYPaEyDATYDUDyvSaDYiHN6nkJ1sEujfU5fCU7MzLGpS6UUIES xdIT7sJhCwrdF89pu31HEb2qS77CtUlb3D8jM9xztu7FECo5OFiwA/gWOkNlhCYj3gRS 6oAo51/qww7Y2GeFyS8vg4RTKhCWJSsJ5GElQErm4w96iKaRPvjZwwf0ip4+clUaq0Q9 +z7cMSngAu3FckfSR4YyllYYzfrPc2pdS8SMsWDqBE4fuyGSf7wnNgeNJvxXVuIz07yR rz4GQHK1cwh9POd/91FR5QTIjD+33ly1JzYdQjwveHcZsqiGyTHFMHGckpUW6SYQH2ep yoEw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1685705885; s=strato-dkim-0003; d=gjlay.de; h=Subject:From:To:Date:Message-ID:Cc:Date:From:Subject:Sender; bh=3DnaJegJuy0/36fpx9vQAHtCcvBVZz/Wl9fbRmJIA2o=; b=xIKBwcv0S+gLn6R9BIr2jFScmEccQGXqlMzeGK8Lt9AinrT7M/0XIZdVPlqDTktFyg +rqXV1IRh441M2bikyAQ== X-RZG-AUTH: ":LXoWVUeid/7A29J/hMvvT3koxZnKT7Qq0xotTetVnKkRmM69o2y+LiO3MutATA==" Received: from [192.168.2.102] by smtp.strato.de (RZmta 49.5.3 DYNA|AUTH) with ESMTPSA id 638aecz52Bc45oZ (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate) for ; Fri, 2 Jun 2023 13:38:04 +0200 (CEST) Message-ID: Date: Fri, 2 Jun 2023 13:38:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: gcc-patches@gcc.gnu.org From: Georg-Johann Lay Subject: [avr, committed] Improve operations on non-LD_REGS when the operation follows a move from LD_REGS. X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" Applied the following patch to improve operations on no-LD_REGS when the operation follows a move from LD_REGS. Johann target/110088: Improve operation of l-reg with const after move from d-reg. After reload, there may be sequences like lreg = dreg lreg = lreg const with an LD_REGS dreg, non-LD_REGS lreg, and in PLUS, IOR, AND. If dreg dies after the first insn, it is possible to use dreg = dreg const lreg = dreg instead which is more efficient. gcc/ PR target/110088 * config/avr/avr.md: Add an RTL peephole to optimize operations on non-LD_REGS after a move from LD_REGS. (piaop): New code iterator. (define_code_iterator eqne [eq ne]) @@ -4727,6 +4729,43 @@ (define_split DONE; }) +;; If $0 = $0 const requires a QI scratch, and d-reg $1 dies after +;; the first insn, then we can replace +;; $0 = $1 +;; $0 = $0 const +;; by +;; $1 = $1 const +;; $0 = $1 +;; This transforms constraint alternative "r,0,n,&d" of the first operation +;; to alternative "d,0,n,X". +;; "*addhi3_clobber" "*addpsi3" "*addsi3" +;; "*addhq3" "*adduhq3" "*addha3" "*adduha3" +;; "*addsq3" "*addusq3" "*addsa3" "*addusa3" +;; "*iorhi3" "*iorpsi3" "*iorsi3" +;; "*andhi3" "*andpsi3" "*andsi3" +(define_peephole2 + [(parallel [(set (match_operand:ORDERED234 0 "register_operand") + (match_operand:ORDERED234 1 "d_register_operand")) + (clobber (reg:CC REG_CC))]) + (parallel [(set (match_dup 0) + (piaop:ORDERED234 (match_dup 0) + (match_operand:ORDERED234 2 "const_operand"))) + ; A d-reg as scratch tells that this insn is expensive, and + ; that $0 is not a d-register: l-reg or something like SI:14 etc. + (clobber (match_operand:QI 3 "d_register_operand")) + (clobber (reg:CC REG_CC))])] + "peep2_reg_dead_p (1, operands[1])" + [(parallel [(set (match_dup 1) + (piaop:ORDERED234 (match_dup 1) + (match_dup 2))) + (clobber (scratch:QI)) + (clobber (reg:CC REG_CC))]) + ; Unfortunately, the following insn misses a REG_DEAD note for $1, + ; so this peep2 works only once. + (parallel [(set (match_dup 0) + (match_dup 1)) + (clobber (reg:CC REG_CC))])]) + ;; swap swap swap swap swap swap swap swap swap swap swap swap swap swap swap ;; swap diff --git a/gcc/config/avr/avr.md b/gcc/config/avr/avr.md index 371965938a6..9f5fabc861f 100644 --- a/gcc/config/avr/avr.md +++ b/gcc/config/avr/avr.md @@ -279,6 +279,7 @@ (define_code_iterator any_extend2 [sign_extend zero_extend]) (define_code_iterator any_extract [sign_extract zero_extract]) (define_code_iterator any_shiftrt [lshiftrt ashiftrt]) +(define_code_iterator piaop [plus ior and]) (define_code_iterator bitop [xor ior and]) (define_code_iterator xior [xor ior])