From patchwork Wed May 31 16:04:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lancelot SIX X-Patchwork-Id: 70397 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32FC93857707 for ; Wed, 31 May 2023 16:06:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32FC93857707 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685549206; bh=7rTxLzZoEAMNLD0Z7mzvtdtyk1kvSRBYhF8yIqBxz7g=; h=To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=NiviaN5f8+i/34BvDFpZ9vjrPis7OkooDQilR6lQA6kBpqtX35K3uY5NrO7Hcfwds j1jccDGLRLSCBND2ADAM5BC2z+FRuvbKpsADNLlBmCiKFQUPR3E3wFUu6UYnUojTTL QqxKtPbQ3/F1JpHvPBJmySLv+aY0uheGhssVVsx8= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2084.outbound.protection.outlook.com [40.107.93.84]) by sourceware.org (Postfix) with ESMTPS id 3BDF13858CD1 for ; Wed, 31 May 2023 16:05:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BDF13858CD1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTYd2QVjvA2TjEd+/hcV4WdhBtcFtdCiXdxAsKvBUXK2CdOFLvFGTZvuPG0vEXHpC32khjo7UwfyYaR+C22npumX0Yp/DfF7bQ5IDjdnmPT0sMqPPXrFk6crX7pmY0/PkvMooHHLOP3BnLy5QMAbO57kIH5OeFgXY1nMHLc6ygfqeC7qyk+qh1D8Eqqf3ZA4uR6uKoOgUXE4zgAR4KyJRqZBATw7C3QsJBqpItzmOtC0TKIdat8wnhwndYNVIYC2/tkkzFGJTD3znlz+4wcCtqcbVHSmKV0uQDXS7/JzbrKY2/hwwvdPTphZl8DyNh7pFhRGHxJjxFDFjeaoRnamWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7rTxLzZoEAMNLD0Z7mzvtdtyk1kvSRBYhF8yIqBxz7g=; b=DjBWFjc5KpJgzwUz0Yt9rxhttaYlusOzxK+HZmEq3FA/sSqxtSpnysGc9wZ+XwaNCoemZ+9U2fcz35JYuVhxBd0V71dDlGyrJTlXoGs/ot1y6Nb5k8FmYHwnccwxfLDcZmtplVhkrL9tJxIOcQYW/iNK+a/IT5+kBEhppD9Qu0Q7WZP2T3J4sJPe2NWgOILk9t2Jd/OR2CVgmwitaYv0J8e1ykGXbbUJMpmpvEpQ/IY1hlt9WR/qSxaA8wiFVZccMdlECERy4EU6KKA5DijBMOk54R/wypsAcyl82b3OnbwB7VfnKBsmnwNggBzj0ySifsCEPz3j8GJs2O2lzEPO8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from MN2PR05CA0052.namprd05.prod.outlook.com (2603:10b6:208:236::21) by MW6PR12MB8898.namprd12.prod.outlook.com (2603:10b6:303:246::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Wed, 31 May 2023 16:05:37 +0000 Received: from BL02EPF000145B8.namprd05.prod.outlook.com (2603:10b6:208:236:cafe::7d) by MN2PR05CA0052.outlook.office365.com (2603:10b6:208:236::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.22 via Frontend Transport; Wed, 31 May 2023 16:05:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF000145B8.mail.protection.outlook.com (10.167.241.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6455.18 via Frontend Transport; Wed, 31 May 2023 16:05:36 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 31 May 2023 11:05:34 -0500 To: CC: , Lancelot SIX Subject: [PATCH 1/3] gdb/corelow.c: fix use-after-free in build_file_mappings Date: Wed, 31 May 2023 17:04:04 +0100 Message-ID: <20230531160406.3932028-2-lancelot.six@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230531160406.3932028-1-lancelot.six@amd.com> References: <20230531160406.3932028-1-lancelot.six@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000145B8:EE_|MW6PR12MB8898:EE_ X-MS-Office365-Filtering-Correlation-Id: 94d32c63-d0d4-4339-3229-08db61f0df3e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QKL333gjTuNToBcHHSpN5uX6EkaTI63s45/NTn+KkAbH71FtT/V2fLy6ezvscg7NSkc4e5Q6Dn9kWjhLQ9fgEdfjzBDGp+c1A4V2m2TyTZN5fgihg1KjWAQ43wQpzQzSdCj40+OmWU3IIhBhw4aZ8wNFRyptEsIcf8txykAMIKEBS+cTFTT19IHFCl7uvsUkKAhyxy/wNrAulUfuy7wbZbafI1e+nMNpU7AwHQXZ8xcbcgSpj9RWWFJm/4FtEppKUxN9Jm9mG99nsC4Kt2FH/+M0FXdTljuyf3sDFJSyHaBGp5A+87hKlXxbV+oi9W5V5CsyDA375vg78IHyHoZmTg5+VoS+a3YGk1Hc3HvZq50JaHEHiKJzxXEy3QWqi9vTpXZAH3LP8KVt7sH+ljcGoGWbe+jBz+5GKIDXXcB4+MVAL9QsmLAzF5emfm3uaB8HjjOio4cREPP1URsbzttSF5mNy+WmQ/YPSX8R6NfE125aduv+8dLYT+A9o8JRVMd1vVr91sl801sxyeD4Hbgi1jczQ4qdIzidLyu6I2ybktj8kbbcvFIBHpcR0TQQ39fTWDxvM7J7L97jc35LfLHnyxS8l3WftwxZPAKuHz/0RJQBK1GiMPMvRVfkUxuSk2wLRM5YZkohiwELDL8kRCM6JTZzIWcvkAUPOn2hmTjAlF13vY00dt31fYF2bNOQF5bodweIHCTh/CMeiGWgW/Ejr+rmzREc+oOU1+KlEhlVlWGZ04NaSJ4EZVf2fHNE1OHG3c36B+LU7CI9dBAMggACCg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(396003)(136003)(346002)(376002)(451199021)(36840700001)(46966006)(40470700004)(82310400005)(478600001)(86362001)(41300700001)(7696005)(40480700001)(40460700003)(6916009)(4326008)(6666004)(316002)(36756003)(70586007)(70206006)(36860700001)(5660300002)(186003)(16526019)(2906002)(26005)(1076003)(426003)(336012)(47076005)(83380400001)(2616005)(8936002)(8676002)(54906003)(82740400003)(81166007)(356005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 16:05:36.8028 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94d32c63-d0d4-4339-3229-08db61f0df3e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000145B8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8898 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lancelot SIX via Gdb-patches From: Lancelot SIX Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" In core_target::build_file_mappings, GDB tries to open files referenced in the core dump. The process goes like this: struct bfd *bfd = bfd_map[filename]; if (bfd == nullptr) { bfd = bfd_map[filename] = bfd_openr (expanded_fname.get (), "binary"); if (bfd == nullptr || !bfd_check_format (bfd, bfd_object)) { if (bfd != nullptr) bfd_close (bfd); return; } } asection *sec = bfd_make_section_anyway (bfd, "load"); ... The problem is that if bfd_check_format fails, we close the bfd but keep a reference to it in the bfd_map. If the same filename appears another time in the NT_FILE note, we enter this code again. The second time, bfd_map[filename] is not nullptr and we try to call bfd_make_section_anyway on an already closed BFD, which is a use-after-free error. This patch makes sure that after closing the bfd, it is removed from the bfd_map. This error got exposed by a recent change in BFD (014a602b86f "Don't optimise bfd_seek to same position"). Since this change, opening a coredump which contains mapping to some special files such as a DRI render node (/dev/dri/renderD$NUM) exposes the issue. This happens for example for processes using AMDGPU devices to offload compute tasks. --- gdb/corelow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index db489b4280e..77fc4453f94 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -277,7 +277,10 @@ core_target::build_file_mappings () "during file-backed mapping note processing"), filename, expanded_fname.get ()); if (bfd != nullptr) - bfd_close (bfd); + { + bfd_close (bfd); + bfd_map.erase (filename); + } return; } /* Ensure that the bfd will be closed when core_bfd is closed. From patchwork Wed May 31 16:04:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lancelot SIX X-Patchwork-Id: 70395 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 263023857034 for ; Wed, 31 May 2023 16:06:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 263023857034 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685549177; bh=Cvcx1bY9iQgyseKH5X9Jpi4/DZ+tYLCRq78UXsh/OCs=; h=To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=MBGJqg0h6Xb01JBuDG6/qHE3uI0/2KP/wTqJ4eDwbyhtblaZlkL6m4GyBEEfd8Awx txck1/vRLqSSrGZT+r/a2V6ftsSCynFTGJH48W8cE97VVCKkmV9y+mYRrRfIWGLxij jQAFu0Q+B/zzh6/rZMKvVzI+qCZgiTSEu6F/iXQE= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2076.outbound.protection.outlook.com [40.107.223.76]) by sourceware.org (Postfix) with ESMTPS id 3BC1E3858D20 for ; Wed, 31 May 2023 16:05:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3BC1E3858D20 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fTRWRNoQYYAeFFTB0jR0AlAhElMnFa2tpVy2TR9JnTrQkV2qyewsrgykl9XZQrvgqrpcy6Qiw1NhY9byCzpvnsDQu6wFFgb0z8tiznVZ1KVX9UNQQormG6/fHn7lpbk3EllCjB+8+zBVihV9Z2Ie5jLwC2gLrPYx2ymoiTGEVvrpFCU4YP2WuJVOcIDeKU8LpfW9Z/jqYhGiLxJTBPv/DashkN16QWpOFS2GpShHOsIgfvdtDPQzYB1dPkLB721QXW4w8pLAkOGPxjILoe5eyjzoVkbO38qukWM7FzmV+TptztfY70YOavGz0Ty/hFgjJqNKOOTqfnvtxUvoD/eH3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cvcx1bY9iQgyseKH5X9Jpi4/DZ+tYLCRq78UXsh/OCs=; b=NVA5UKSgSV8Fut8VpQLXa1tTYJ5KAdytRyYHetfacVoKefqtsBmkQ71rEcrHgEdP4kUA6W8LaENjm1b9Ehk9DE3NSdQH5l3Za3RocILSK2asKY6dwyM3MZYW0peUFVGb0SeSKAQNYJdtnTFEIQ2KWSBwR3bjfhF2mchII2yOaNbJHAunMH59ybOf791AgeAPkRXhJxtPzvdVmgEHns6atVQpKO2DcVO5foo7Zui+CY2aSDYne2r6ViKvoZvbQgAn4+zkWmHl3X+hXvf0spnsNzcrJGkCa7OET2RKGci1e4M38JBdJeDfUc7FUktDlLLDLRkIA1aMZ1K5rfgVp0s7xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from MN2PR05CA0059.namprd05.prod.outlook.com (2603:10b6:208:236::28) by IA0PR12MB8981.namprd12.prod.outlook.com (2603:10b6:208:484::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.23; Wed, 31 May 2023 16:05:37 +0000 Received: from BL02EPF000145B8.namprd05.prod.outlook.com (2603:10b6:208:236:cafe::36) by MN2PR05CA0059.outlook.office365.com (2603:10b6:208:236::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.22 via Frontend Transport; Wed, 31 May 2023 16:05:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF000145B8.mail.protection.outlook.com (10.167.241.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6455.18 via Frontend Transport; Wed, 31 May 2023 16:05:37 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 31 May 2023 11:05:36 -0500 To: CC: , Lancelot SIX Subject: [PATCH 2/3] gdb/corelow.c: avoid repeated warnings in build_file_mappings Date: Wed, 31 May 2023 17:04:05 +0100 Message-ID: <20230531160406.3932028-3-lancelot.six@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230531160406.3932028-1-lancelot.six@amd.com> References: <20230531160406.3932028-1-lancelot.six@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000145B8:EE_|IA0PR12MB8981:EE_ X-MS-Office365-Filtering-Correlation-Id: 3ee376b1-53a0-4e79-b636-08db61f0dfc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0QqpxBaeSKvSXd+O6Dg9uztrk5q+7Md+OfDZNTfu+UH4+gALa2b5g50GsBnxfKYyyqzIlDB5Y9+OG9PW/xqz7T4n5l5wd3tAxjDPxC5jcAs9KMW5lALIQSrOhhXxXqiGuY9CrUv7Ocdtg85U1aVctrEExxVIMgNbFOtaZB9yLdPQ1MNn2uAPRF0wiapTI4WSfCDkEIoxcu3hiuUiwuyEHL4ErdlSknzo1rJdnNUZndm8BANBxzc50uG0kMMjOFOJSfsoMqJXwnGCNKpoo6bGNjpV+jLe/Qc/XObtvS+8PHni5Tu05PCqs9pkf4rGnwyC7njE2g7A7udG9r10dy9mqMvdJde04KH5LpcuLH20LArTS1BKi8NIbu8RrshHJigWRtiDcT8lFIi0mA2ULWBvyPKQXiFZ/gxe8yn7mzJCmncdDN1/ca4l6olQyCzOlQiO4E7OMfr6aSwu+3mPWsRZM4Su/S75BqMDCR6q+KrG2JiUD9DQhmq4f2H2yReVr1v+fjN/U55SeGqvTw1n9EsFeEvqJj+2gScfwhD+l5cXfEhS3nJADC06Wp+VyhIgYWpv7bp88kYr9pOssKdd5qAmsbzU5WtAVYFQFZoqG/50BqIqwIk6ETjCszqtvSlAvrZB1EtvRfctCuHYEqGGU9m2jH8wo+YHPl471yYmxqXTxhR4p94ii2o61lcqLbafmOoTxhvNQ2hDKRRaiT7l1T0CIxm0ls8fH1gDEv/7JJgjnzZW0BaPYhA/6V0L8eTedJtDr58a4/0S7fntj8faF1ZjjQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(136003)(346002)(396003)(39860400002)(376002)(451199021)(40470700004)(36840700001)(46966006)(86362001)(36756003)(316002)(4326008)(478600001)(54906003)(6916009)(70206006)(70586007)(6666004)(7696005)(47076005)(82310400005)(82740400003)(40480700001)(8676002)(8936002)(41300700001)(2906002)(5660300002)(2616005)(356005)(81166007)(336012)(16526019)(426003)(26005)(186003)(1076003)(36860700001)(83380400001)(40460700003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 16:05:37.6779 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3ee376b1-53a0-4e79-b636-08db61f0dfc3 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000145B8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8981 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lancelot SIX via Gdb-patches From: Lancelot SIX Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" When GDB opens a coredump it tries to locate and then open all files which were mapped in the process. If a file is found but cannot be opened with BFD (bfd_open / bfd_check_format fails), then a warning is printed to the user. If the same file was mapped multiple times in the process's address space, the warning is printed once for each time the file was mapped. I find this un-necessarily noisy. This patch makes it so the warning message is printed only once per file. There was a comment in the code assuming that if the file was found on the system, opening it (bfd_open + bfd_check_format) should always succeed. A recent change in BFD (014a602b86f "Don't optimise bfd_seek to same position") showed that this assumption is not valid. For example, it is possible to have a core dump of a process which had mmaped an IO page from a DRI render node (/dev/dri/runderD$NUM). In such case the core dump does contain the information that portions of this special file were mapped in the host process, but trying to seek to position 0 will fail, making bfd_check_format fail. This patch removes this comment. Reviewed-By: Andrew Burgess --- gdb/corelow.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index 77fc4453f94..ce68f91132e 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -264,18 +264,11 @@ core_target::build_file_mappings () if (bfd == nullptr || !bfd_check_format (bfd, bfd_object)) { m_core_unavailable_mappings.emplace_back (start, end - start); - /* If we get here, there's a good chance that it's due to - an internal error. We issue a warning instead of an - internal error because of the possibility that the - file was removed in between checking for its - existence during the expansion in exec_file_find() - and the calls to bfd_openr() / bfd_check_format(). - Output both the path from the core file note along - with its expansion to make debugging this problem - easier. */ - warning (_("Can't open file %s which was expanded to %s " - "during file-backed mapping note processing"), - filename, expanded_fname.get ()); + if (unavailable_paths.insert (filename).second) + warning (_("Can't open file %s which was expanded to %s " + "during file-backed mapping note processing"), + filename, expanded_fname.get ()); + if (bfd != nullptr) { bfd_close (bfd); From patchwork Wed May 31 16:04:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lancelot SIX X-Patchwork-Id: 70396 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 405393857006 for ; Wed, 31 May 2023 16:06:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 405393857006 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1685549180; bh=Kgf4UOxf5X4I5gCLfSzhFCqzh0syQ8RsMa7zmJxc9xY=; h=To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TVYi9TGsBecUtcURbauhH7ptYU302tGwgtjEN128BSYwNzHIz+tFkg8S516r9dmcv slLIg4EtXMnYC4ZCqkW42MkIJz0yRiRgo+pvfSTuXwtdgvk5YYsYPA56Mgl0NBC2cY cfw+x6bmADi5FsISvSuXb/z0fXHh41lS7ye87t9o= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2056.outbound.protection.outlook.com [40.107.212.56]) by sourceware.org (Postfix) with ESMTPS id C4DAC3858CDB for ; Wed, 31 May 2023 16:05:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4DAC3858CDB ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eOV0vQftYyDESHcj63uwVw9ljtEXsVoV+bLpOS7kJZDwJXLTQ6xFon/o9SQgeuXsnduCd3defmwe0Bcs4yRIEMUGhEfGpqWgtUW9r8TiZtlL/OyAEivt2DVEJRheq2KNrQqDZz/HYgChEGnhPudV/du7/w/S/sq0QjxN68NDJWjSCqhBm/D4CBlo7Ml9aanEiXzURBbgN+H6YBtVFGoXB66uehcg4rPaOGmtUQgyJ+sOSMgN9Iv0kyggfqokrcRBJeIgIahvqlrZpZH7VMfcXf2E01UpLLl27lCdOTQKuvmVj/alWm313iVDiYzGg7eZkTbZxnRBYv3eMiHC4WHdyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kgf4UOxf5X4I5gCLfSzhFCqzh0syQ8RsMa7zmJxc9xY=; b=m1gaFBE1DHNF9F8Jow04iocq7VydW2sGLZwQWFL3QjH9cfMnk9vQTDWS/DEdyKkmBNWoRqERSp0PXajk+O9/bFoJlTesMqB+pnUdeTaU4x2riLPzHyIoSoEJVoYcgMam+u67wi7wBykxVy7+jgKIAoUtF95W9Kz7wRloDAO+j8Gfsn9Aca1HkaWpTMYyse+ZzHHLnPjRZz7NzjpvNDWLDXSEhxzZuYPWYDu7W9AEQ+4hYbmnoCU2xpea5Zm2k64Itigk9uYP8ec3i/hGW+4DDXpv08HTxflgkoPDr41zE8QAKPM0QHxE6YCLNx+xvDr5b+j5heI+pZssvOdy0es1vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none Received: from MN2PR05CA0061.namprd05.prod.outlook.com (2603:10b6:208:236::30) by SA3PR12MB7806.namprd12.prod.outlook.com (2603:10b6:806:31d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.25; Wed, 31 May 2023 16:05:38 +0000 Received: from BL02EPF000145B8.namprd05.prod.outlook.com (2603:10b6:208:236:cafe::e7) by MN2PR05CA0061.outlook.office365.com (2603:10b6:208:236::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.22 via Frontend Transport; Wed, 31 May 2023 16:05:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL02EPF000145B8.mail.protection.outlook.com (10.167.241.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6455.18 via Frontend Transport; Wed, 31 May 2023 16:05:38 +0000 Received: from khazad-dum.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 31 May 2023 11:05:37 -0500 To: CC: , Lancelot SIX Subject: [PATCH 3/3] gdb/corelow.c: do not try to reopen a file if open failed once Date: Wed, 31 May 2023 17:04:06 +0100 Message-ID: <20230531160406.3932028-4-lancelot.six@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230531160406.3932028-1-lancelot.six@amd.com> References: <20230531160406.3932028-1-lancelot.six@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF000145B8:EE_|SA3PR12MB7806:EE_ X-MS-Office365-Filtering-Correlation-Id: bef01e69-2139-43ad-c4de-08db61f0e033 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hRN2LIQ9KYvOSFfxWbWjIQnuc59VB7fsDZNHsnLcRiza6HTYRhNbf9lZkNBg8QRDQzUeOsStgP/p1/tebD73oY4JM7AwT4v9RsP7opksHFCeapnzj2PmZJSojs4sTiftl9n18G6HSVFFEubYbki/BS1gTw0J7yEV5bMDnubipID4BTcSTZKciKP6hKffAQkb4KFGPIGIfc6rv16DkuygI8nDJKdVcWAKKy42APLp9S6QtfNu1kRUXVq9hqdtXszi7lSe/+SCFLpAxffqXycVZLMazyL68X849idnyvors/hLxV9EBWvdVm6nd5mOr/V/4+h/yOyDbuBRWzKA6yKK/Nue22ufuPyneyK3zLSz0ULTyt+I+uT12jGEyMlhjm857zqVCwMpGD1+jx8ePfkm5FJpl+YYPR353CUMslI2mXplud9xXshlg9vK+L2UCmuOoYeIYrtPO+CEqvwGsOV/GnCFVivDZVfM2n5sqMF1eQ2zz2Xv1IUVhP9vQBE3/jNmPoQx4kvRobPjQL8pYX1SfYh4gkOQjZPUf8lwDDlUtrbMPAcWMQEpT3DxYstUH2lZPzLzbyzdVPhXYQfuBSNKIu3AKIjVhJLMb+vjhZBvhJZOW10p1k3/MbUfqXxqZfhYnoFOyDkqYNr7FDT12BIfXoLatdJn6WjY1X95CQMnOhSApiwsAIXoXJ3vBWU1Y9SlOeWxhk3fvFPS5gIiOK4sLTsOI0dj59liTqa3wjwqoVfB56I3AOCm7U7zgSDBL/Flov2Zcy1TWzzWpcF7tkzVJQ== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199021)(36840700001)(40470700004)(46966006)(356005)(186003)(82740400003)(81166007)(26005)(1076003)(40460700003)(426003)(47076005)(36756003)(336012)(2616005)(36860700001)(16526019)(2906002)(40480700001)(70586007)(41300700001)(54906003)(7696005)(6666004)(316002)(82310400005)(478600001)(6916009)(86362001)(4326008)(70206006)(8676002)(83380400001)(8936002)(5660300002)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2023 16:05:38.4122 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bef01e69-2139-43ad-c4de-08db61f0e033 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF000145B8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7806 X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FORGED_SPF_HELO, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lancelot SIX via Gdb-patches From: Lancelot SIX Reply-To: Lancelot SIX Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" In the current implementation, core_target::build_file_mappings will try to locate and open files which were mapped in the process for which the core dump was produced. If the file cannot be found or cannot be opened, GDB will re-try to open it once for each time it was mapped in the process's address space. This patch makes it so GDB recognizes that it has already failed to open a given file once and does not re-try the process for each mapping. Reviewed-By: Andrew Burgess --- gdb/corelow.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/gdb/corelow.c b/gdb/corelow.c index ce68f91132e..b831a90792c 100644 --- a/gdb/corelow.c +++ b/gdb/corelow.c @@ -233,6 +233,16 @@ core_target::build_file_mappings () weed out non-file-backed mappings. */ gdb_assert (filename != nullptr); + if (unavailable_paths.find (filename) != unavailable_paths.end ()) + { + /* We have already seen some mapping for FILENAME but failed to + find/open the file. There is no point in trying the same + thing again so just record that the range [start, end) is + unavailable. */ + m_core_unavailable_mappings.emplace_back (start, end - start); + return; + } + struct bfd *bfd = bfd_map[filename]; if (bfd == nullptr) { @@ -250,11 +260,10 @@ core_target::build_file_mappings () if (expanded_fname == nullptr) { m_core_unavailable_mappings.emplace_back (start, end - start); - /* Print just one warning per path. */ - if (unavailable_paths.insert (filename).second) - warning (_("Can't open file %s during file-backed mapping " - "note processing"), - filename); + unavailable_paths.insert (filename); + warning (_("Can't open file %s during file-backed mapping " + "note processing"), + filename); return; } @@ -264,10 +273,10 @@ core_target::build_file_mappings () if (bfd == nullptr || !bfd_check_format (bfd, bfd_object)) { m_core_unavailable_mappings.emplace_back (start, end - start); - if (unavailable_paths.insert (filename).second) - warning (_("Can't open file %s which was expanded to %s " - "during file-backed mapping note processing"), - filename, expanded_fname.get ()); + unavailable_paths.insert (filename); + warning (_("Can't open file %s which was expanded to %s " + "during file-backed mapping note processing"), + filename, expanded_fname.get ()); if (bfd != nullptr) {