From patchwork Mon May 29 08:29:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 70225 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 06E973952022 for ; Mon, 29 May 2023 08:35:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 06E973952022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1685349347; bh=54xIBg9vd5EDjr2dhzJ0SN18ptdP6gG3s80O19f8oHA=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=a355qnCXB/x+RnGM7nlMlJDtRhQeBrOkdLt4jDSjKO1xbURwywNy4ZG51R8uzstDG X2NPKm93aXAxZnWui+4c9/7i8GpL1w0S6QyP6Imcan2SdMhTBji3OAZnIpUOH1XdiV udyqFXSdSPKX92a6u1NiU7y2uGZrBks6QJQl0LLA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id E906E3857347 for ; Mon, 29 May 2023 08:29:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E906E3857347 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f606a80d34so19716595e9.0 for ; Mon, 29 May 2023 01:29:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685348985; x=1687940985; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=54xIBg9vd5EDjr2dhzJ0SN18ptdP6gG3s80O19f8oHA=; b=J7JEjOdHPFXa41Sd2d7u/CJCZK6UY+g5xDWzJOdvQU33NOVDXej3Bq/ZFWJWoBZKPH 4KKbUSXzSUe/v2UHRGS0CKpUnTvlXiXPE6Ju3Ofe9CwnsO+zuUf3KkB1hHJ3bbGPmFHV QSSwsbgmZwjPqVAe6DBsFmibfVz9ZHNEJgrqx5GgVFpNkaPh7dpjyCfKjIxam6XLSY3n UMeiNHYtKVUdO2oqUZpQpw21nAFx8WYUxjh/j+csBrt2lC59EYMi0cKGstOduYT2x7Tx 5GNb/Y0urKCxh/s5kyfYq73wx/qIZgfD6n1KaGoYceNNfBlKH1UFFelLB24U5T4PrXPz FHMw== X-Gm-Message-State: AC+VfDwPV3fkkOtbpoAZtl+rDWcVV2Dp+De6oeKf18Ho0QbKb4nSzjwy Lftc1/EVSrSIrmI0g5Q3COyaGr6gM41gGENwn6O8qA== X-Google-Smtp-Source: ACHHUZ69h7j2W5pH9xfhrg46mFWg7sg9vzX2Octr4afz4AnbZjEAM+Bn/crNhNjSiskqmlwpuQP0GA== X-Received: by 2002:a7b:c044:0:b0:3f6:be1:b8d9 with SMTP id u4-20020a7bc044000000b003f60be1b8d9mr7476882wmc.6.1685348985834; Mon, 29 May 2023 01:29:45 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id 13-20020a05600c24cd00b003f4dde07956sm17040796wmu.42.2023.05.29.01.29.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 01:29:45 -0700 (PDT) To: gcc-patches@gcc.gnu.org Cc: Piotr Trojanek Subject: [COMMITTED] ada: Remove redundant protection against empty lists Date: Mon, 29 May 2023 10:29:44 +0200 Message-Id: <20230529082944.2410880-1-poulhies@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Marc_Poulhi=C3=A8s_via_Gcc-patches?= From: =?utf-8?q?Marc_Poulhi=C3=A8s?= Reply-To: =?utf-8?q?Marc_Poulhi=C3=A8s?= Errors-To: gcc-patches-bounces+patchwork=sourceware.org@gcc.gnu.org Sender: "Gcc-patches" From: Piotr Trojanek Calls to First on No_List intentionally return Empty, so explicit guards against No_List are unnecessary. Code cleanup; semantics is unaffected. gcc/ada/ * sem_util.adb (Check_Function_Writable_Actuals): Remove guard against a membership test with no alternatives; simplify with a membership test. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_util.adb | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb index a42b2dff60f..34ea06432cf 100644 --- a/gcc/ada/sem_util.adb +++ b/gcc/ada/sem_util.adb @@ -2882,9 +2882,7 @@ package body Sem_Util is Collect_Identifiers (Right_Opnd (N)); end if; - if Nkind (N) in N_In | N_Not_In - and then Present (Alternatives (N)) - then + if Nkind (N) in N_Membership_Test then Expr := First (Alternatives (N)); while Present (Expr) loop Collect_Identifiers (Expr);